From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0B62C761AF for ; Mon, 27 Mar 2023 11:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232540AbjC0Ltb (ORCPT ); Mon, 27 Mar 2023 07:49:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbjC0Lt2 (ORCPT ); Mon, 27 Mar 2023 07:49:28 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C42902D47 for ; Mon, 27 Mar 2023 04:49:18 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4dd9da1c068so97513e87.0 for ; Mon, 27 Mar 2023 04:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679917757; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NSFETURvKeKlJ69zBNiZIDisEWdoIMslqYt90Emqjk4=; b=n5GVJradJsYF48fo16f5GWVhvJlsEGHoexdX4ykmCZOblBK4aNRQzxFXR+DPlgSA4h GihrA9TjOKQCmpBmnzMuo2sSpLHjAGO3pqNjQ3pAJ4fqdpa5Rc6q6CDNdl7r7AeI92hw xd5KRzdaXCAkHLkGKAXlVeLDOQSaz4Q7UTYlI39UbPqJ/H4j3dfbxN8psY3Pb31seHaY 8FRy54XH4TKadFbFdhS8Rvw10XpJUCCQPHu2jjz0LxqFtWVYkxJCWCeVJzClVs2Pkj7q 9MQ8aphVGb5OBnnNvvRjvq2X6nEpszRkGDSMtUMfXQsEfPvEDQACuKcuLRzuvbUBk/DL FSNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679917757; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NSFETURvKeKlJ69zBNiZIDisEWdoIMslqYt90Emqjk4=; b=B5uN/Ud2h5ZbQDY15QEQK/4iuv/+S22KKQso/Yb0ZJk7qnsnvVByWqICyuqZrsIAw+ QHKux1Gl7v3MlFIs6SykK5Z7vOD4bQVDhDocnNuI4wYGMyZK5bMdED0Wsq2UK01u7pRW O5D0ha5MSCWFe/Wj1Y/UW7AvER3RbVAzJHlD+4OAiQ/UnHEqfQGBnJddtLu4tQ7CGdVL AUq9IGWDFYwcPb8bfCpGq+UkpTYZD5uEskwbSMatlj/KFPYYnVfFKgBOUcp68aNCRUIg 7gXYuVBgYrT/k+liL2SFspnaGba3OfFda2OkH5Mc5sTQBUlPV+UswZ2XVSyoDRbsYv59 3Keg== X-Gm-Message-State: AAQBX9eMpC5ZM0DqN5jiofmS3nl/rlTn3oF215ibyZeIJ9Jeym0FQWCV V7P8HL2j60tzvobh9/3ClcaI6A== X-Google-Smtp-Source: AKy350YJXhj3arGqXXTpc2VgZV6Qr9pWR9vJmoZ6WgNyjGx7wXKME8/6rq0oTj3BTzcWTCBwndVW9A== X-Received: by 2002:ac2:4a66:0:b0:4e0:2e20:b663 with SMTP id q6-20020ac24a66000000b004e02e20b663mr2515470lfp.6.1679917757081; Mon, 27 Mar 2023 04:49:17 -0700 (PDT) Received: from [192.168.1.102] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id p16-20020a05651238d000b004e8508899basm4676361lft.86.2023.03.27.04.49.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 04:49:16 -0700 (PDT) Message-ID: <333081a2-6b31-3fca-1a95-4273b5a46fb7@linaro.org> Date: Mon, 27 Mar 2023 14:49:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v2 03/10] dt-bindings: qcom-qce: Fix compatibles combinations for SM8150 and IPQ4019 SoCs Content-Language: en-US To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: agross@kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, andersson@kernel.org, bhupesh.linux@gmail.com, krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, konrad.dybcio@linaro.org, rfoss@kernel.org, neil.armstrong@linaro.org References: <20230322114519.3412469-1-bhupesh.sharma@linaro.org> <20230322114519.3412469-4-bhupesh.sharma@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20230322114519.3412469-4-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bhupesh, On 3/22/23 13:45, Bhupesh Sharma wrote: > Currently the compatible list available in 'qce' dt-bindings does not > support SM8150 and IPQ4019 SoCs directly, leading to following > 'dtbs_check' error: > > arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dtb: > crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: > ['qcom,sm8150-qce', 'qcom,qce'] is too long > ['qcom,sm8150-qce', 'qcom,qce'] is too short > > Fix the same. > > Signed-off-by: Bhupesh Sharma > --- > Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > index e375bd981300..90ddf98a6df9 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > @@ -24,6 +24,12 @@ properties: > deprecated: true > description: Kept only for ABI backward compatibility > > + - items: > + - enum: > + - qcom,ipq4019-qce > + - qcom,sm8150-qce > + - const: qcom,qce > + thank you for the fix, the change is correct, please apply the tag: Fixes: 00f3bc2db351 ("dt-bindings: qcom-qce: Add new SoC compatible strings for Qualcomm QCE IP") But let me ask you to split the "items" into two: - items: - const: qcom,ipq4019-qce - const: qcom,qce - items: - const: qcom,sm8150-qce - const: qcom,qce and put each of these two new items below a list of compatible values, where a family compatible describes the list. Nevertheless, please also add my tag: Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir