mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: dhowells@redhat.com, Paulo Alcantara <pc@manguebit.org>,
	Matthew Wilcox <willy@infradead.org>,
	Namjae Jeon <linkinjeon@kernel.org>,
	Marc Dionne <marc.dionne@auristor.com>,
	Stefan Metzmacher <metze@samba.org>,
	Eric Van Hensbergen <ericvh@kernel.org>,
	Dominique Martinet <asmadeus@codewreck.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	netfs@lists.linux.dev, linux-afs@lists.infradead.org,
	linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
	ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v19 04/17] netfs: Add some tools for managing bvecq chains
Date: Thu, 19 Nov 2026 11:49:19 +0000	[thread overview]
Message-ID: <3331436.1795088959@dhowells-thinkpadp1gen8.rmtgb.csb> (raw)
In-Reply-To: <20261119083851.3306418-5-dhowells@redhat.com>

Hi Christian,

If you pull this patch, can you apply the attached diff to it to fix some
issues that Sashiko brought up[1]?

- In bvecq_alloc_buffer2(), fix OOM discard where the requested number of
  pre-slots fills up a entire bvecq.

- In bvecq_alloc_buffer2(), add comment on why we want to exit the buffer
  alloc loop immediately.

- In bvecq_put(), clear the prev pointer of the next bvecq if it points
  back to the one being released.

- Fix bvecq_append() kdoc.

- Change %flags to @flags in function kdoc when referring to func arg.

Thanks,
David

[1] https://sashiko.dev/#/patchset/20261119083851.3306418-1-dhowells%40redhat.com
---
diff --git a/fs/netfs/bvecq.c b/fs/netfs/bvecq.c
index b140cd47a1fa..1b2ad42e6d50 100644
--- a/fs/netfs/bvecq.c
+++ b/fs/netfs/bvecq.c
@@ -61,7 +61,7 @@ EXPORT_SYMBOL(bvecq_dump);
  * that at least some progress can be made.
  *
  * Return: The node pointer or NULL on allocation failure.  BVECQ_HIT_OOM is
- * set in *flags if an allocation failure occurs.
+ * set in *@flags if an allocation failure occurs.
  */
 struct bvecq *bvecq_alloc_one(size_t nr_slots, gfp_t gfp, unsigned int *flags)
 {
@@ -136,10 +136,10 @@ EXPORT_SYMBOL(bvecq_alloc_one);
  *
  * Allocate a chain of bvecq nodes providing at least the requested cumulative
  * number of slots.  Each node is a maximum of 4KiB in size.  If
- * %BVECQ_SHORT_OKAY is set in *%flags, then the chain may be shortened on OOM.
+ * %BVECQ_SHORT_OKAY is set in *@flags, then the chain may be shortened on OOM.
  *
  * Return: The first node pointer or NULL on allocation failure.  BVECQ_HIT_OOM
- * is set in *flags if an allocation failure occurs.
+ * is set in *@flags if an allocation failure occurs.
  */
 struct bvecq *bvecq_alloc_chain(size_t nr_slots, gfp_t gfp, unsigned int *flags)
 {
@@ -191,7 +191,7 @@ EXPORT_SYMBOL(bvecq_alloc_chain);
  * refcounts set to 1 and can be passed to MSG_SPLICE_PAGES.
  *
  * Return: The first node pointer or NULL on allocation failure.  BVECQ_HIT_OOM
- * is set in *flags if a bvecq chain allocation failure occurs (though if
+ * is set in *@flags if a bvecq chain allocation failure occurs (though if
  * %BVECQ_SHORT_OKAY is set, the func may return early but will have at least
  * one bvecq in the allocation).
  */
@@ -200,6 +200,7 @@ struct bvecq *bvecq_alloc_buffer2(size_t size, unsigned int pre_slots, gfp_t gfp
 {
 	struct bvecq *head = NULL, *tail = NULL;
 	size_t count = pre_slots + DIV_ROUND_UP(size, PAGE_SIZE);
+	bool got_page = false;
 
 	_enter("%zx,%zx,%u", size, count, pre_slots);
 
@@ -258,7 +259,12 @@ struct bvecq *bvecq_alloc_buffer2(size_t size, unsigned int pre_slots, gfp_t gfp
 
 		bvecq_filled_to(tail, slot);
 		count -= got;
+		got_page = true;
 
+		/* TODO: If we got an OOM trying to allocate a bvecq, we should
+		 * probably stop allocating pages unless/until we have an
+		 * emergency pool of those also.
+		 */
 		if (unlikely(*flags & BVECQ_HIT_OOM) && (*flags & BVECQ_SHORT_OKAY))
 			break;
 	} while (count > 0);
@@ -273,7 +279,9 @@ struct bvecq *bvecq_alloc_buffer2(size_t size, unsigned int pre_slots, gfp_t gfp
 		bvecq_put(tail);
 	}
 oom:
-	if (!head || (tail == head && head->nr_slots == pre_slots))
+	if (!head)
+		goto out;
+	if (!got_page && size > 0)
 		goto discard; /* Allocated no pages */
 	if (*flags & BVECQ_SHORT_OKAY)
 		goto out;
@@ -328,6 +336,8 @@ void bvecq_put(struct bvecq *bq)
 		for (int slot = 0; slot < bq->nr_slots; slot++)
 			bvecq_free_slot(bq, slot);
 		next = bq->next;
+		if (next && next->prev == bq)
+			next->prev = NULL;
 		netfs_stat_d(&netfs_n_bvecq);
 
 		if (bq->from_pool != BVECQ_USE_NO_POOL)
diff --git a/include/linux/bvecq.h b/include/linux/bvecq.h
index f670a031ac44..da2385c91e9a 100644
--- a/include/linux/bvecq.h
+++ b/include/linux/bvecq.h
@@ -162,7 +162,7 @@ static inline bool bvecq_acquire_slot(const struct bvecq *bvecq, unsigned int sl
 }
 
 /**
- * bvecq_append - Get the next bvecq with appropriate barrier
+ * bvecq_append - Attach new bvecq to chain with appropriate barrier
  * @to: The bvecq to append to
  * @add: The bvecq to append
  *


  parent reply	other threads:[~2026-11-19 11:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:38 [PATCH v19 00/17] netfs, iov_iter: Use a chain of bio_vec arrays instead of folio_queue David Howells
2026-11-19  8:38 ` [PATCH v19 01/17] iov_iter: Fix kunit test to remove __init and __refdata marks David Howells
2026-11-19  9:21   ` Wang Yibo
2026-11-19  8:38 ` [PATCH v19 02/17] block: Add a function to kmap one page of a multipage bio_vec David Howells
2026-11-19  8:38 ` [PATCH v19 03/17] iov_iter: Add a segmented queue of bio_vec[] David Howells
2026-11-19  8:38 ` [PATCH v19 04/17] netfs: Add some tools for managing bvecq chains David Howells
2026-11-19  8:38 ` [PATCH v19 05/17] iov_iter: Add an API document for the bvecq structure David Howells
2026-11-19  8:38 ` [PATCH v19 06/17] iov_iter: Add a bvecq kunit test David Howells
2026-11-19  8:38 ` [PATCH v19 07/17] afs: Fix an inconsistency in the symlink code David Howells
2026-11-19  8:38 ` [PATCH v19 08/17] netfs: Explicitly pass tail padding to netfs_writeback_single() David Howells
2026-11-19  8:38 ` [PATCH v19 09/17] netfs: Change netfs_writeback_single() to not look inside the iterator David Howells
2026-11-19  8:38 ` [PATCH v19 10/17] netfs: Pass the write length to request creation where appropriate David Howells
2026-11-19  8:38 ` [PATCH v19 11/17] afs: Use a bvecq to hold dir content rather than folioq David Howells
2026-11-19  8:38 ` [PATCH v19 12/17] cifs: Use a bvecq for buffering instead of a folioq David Howells
2026-11-19  8:38 ` [PATCH v19 13/17] smbdirect: Support ITER_BVECQ in smbdirect_map_sges_from_iter() David Howells
2026-11-19  8:38 ` [PATCH v19 14/17] netfs: Switch folioq to bvecq David Howells
2026-11-19  8:38 ` [PATCH v19 15/17] smbdirect: Remove support for ITER_FOLIOQ from smbdirect_map_sges_from_iter() David Howells
2026-11-19  8:38 ` [PATCH v19 16/17] iov_iter: Remove ITER_FOLIOQ David Howells
2026-11-19  8:38 ` [PATCH v19 17/17] netfs: Remove folio_queue David Howells
2026-11-19 11:49 ` David Howells [this message]
2026-11-19 11:49 ` [PATCH v19 14/17] netfs: Switch folioq to bvecq David Howells
2026-11-20  9:38 ` [PATCH v19 00/17] netfs, iov_iter: Use a chain of bio_vec arrays instead of folio_queue Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3331436.1795088959@dhowells-thinkpadp1gen8.rmtgb.csb \
    --to=dhowells@redhat.com \
    --cc=asmadeus@codewreck.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=christian@brauner.io \
    --cc=ericvh@kernel.org \
    --cc=hch@infradead.org \
    --cc=idryomov@gmail.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    --cc=metze@samba.org \
    --cc=netfs@lists.linux.dev \
    --cc=pc@manguebit.org \
    --cc=v9fs@lists.linux.dev \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®