From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C586409122; Tue, 19 May 2026 17:38:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779212289; cv=none; b=I4SdDhZhPgMmwvmjMR+o/dMQ6TxDcf7h0LogmrVOJOcmzz6yHLc+xTx+hw+d3/9Yhv9ZNNwFxxp9Zh47ZOBJBjC9V29TmcAbbKZMwLBs5llBAD8zFMm0M6N+mYsycUVtqZ1E+nvSZzj257Uoafib6MOEGoG2CqFblSbbSmzvrcA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779212289; c=relaxed/simple; bh=AtrT929H9sA3accdr0mH/7h6YGVnKrtINt2hya3nOuc=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=AIW8zmx/pnJejKCgb/ifOardt9e6VFlrRC0QG8UFc7xcgLGYhSWAOWIjFeHk7ukC+vz4bEfIk02TerZ07lCJARi36vizoTSFtkDg+qMCgRGbf6AgHo9IamwMGlFLBtE1aexT7Ukiwg5G7+0XTiRW1CkmEsuRGlhp2G97YO/vaLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com; spf=pass smtp.mailfrom=perches.com; arc=none smtp.client-ip=216.40.44.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perches.com Received: from omf10.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 68521160FB5; Tue, 19 May 2026 17:37:59 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA id 036D530; Tue, 19 May 2026 17:37:56 +0000 (UTC) Message-ID: <33318503dca54fd9401ca99213632c59d5deec12.camel@perches.com> Subject: Re: [PATCH net] net: fec_mpc52xx: Fix resource size format From: Joe Perches To: Rosen Penev , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , open list Date: Tue, 19 May 2026 10:37:56 -0700 In-Reply-To: <20260518044047.1002235-1-rosenp@gmail.com> References: <20260518044047.1002235-1-rosenp@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: 036D530 X-Stat-Signature: yfzwabfdt3kbtxtc3g84g4s3iuthot93 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18yIAiw2nrCp2W6h9tC531K0QNLmsaiPHc= X-HE-Tag: 1779212276-903603 X-HE-Meta: U2FsdGVkX19Agru9PSoG/6heNx52oYfDd17MI1CKBhsWQks7LClVOnJuSgrkeGTwwn5b/cu8MP9Z2+6WXNYGGef6Pql/enzGCsqa1LtkgUXDf6Hn++frW3XKT5xX/yqoLGiWY7xKIQvFtavuEC+EB/vWkoD3XmBRXjaVWZeBMPiiFRp/KBazO2TZ+nJPfsQ9I603Tw9qPyIgMcHORjJmRO0KlQn1DWdJopw/shoLNDm7ncSuK9nOGNH4vC0t1JA/AbLRe3mXcoQJvU5t1rAIis0TR2WFMxqXIQVKdPOHAQNghd2ZIvn/9KAAQv2os/1s32UItuwVeI8/1eLPfFZ1sPWM+002wUujB+zC3v/LZPlbEs7mbQtOE0CGcZR6+hQy4KJSv2XhJNHqIergVf79FJG0cli2zgZd On Sun, 2026-05-17 at 21:40 -0700, Rosen Penev wrote: > resource_size() is printed after casting to unsigned long, but > sizeof() returns size_t. trivia and I wonder if this code path is even possible > diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx.c b/drivers/net/e= thernet/freescale/fec_mpc52xx.c [] > @@ -834,7 +834,7 @@ static int mpc52xx_fec_probe(struct platform_device *= op) > goto err_netdev; > } > if (resource_size(&mem) < sizeof(struct mpc52xx_fec)) { > - pr_err("invalid resource size (%lx < %x), check mpc52xx_devices.c\n", > + pr_err("invalid resource size (%lx < %zx), check mpc52xx_devices.c\n", > (unsigned long)resource_size(&mem), > sizeof(struct mpc52xx_fec)); mpc52xx_devices.c does not exist. It was deleted nearly 20 years ago by: commit 917f0af9e5a9ceecf9e72537fabb501254ba321d Author: Paul Mackerras Date: Mon Jun 9 14:01:46 2008 +1000 and It's possible to remove the cast to unsigned long and use %pa and %zx could be %#zx to match output prefixes.