From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932915AbbIDOYH (ORCPT ); Fri, 4 Sep 2015 10:24:07 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:53284 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932795AbbIDOYD (ORCPT ); Fri, 4 Sep 2015 10:24:03 -0400 From: "Rafael J. Wysocki" To: Shreyas B Prabhu Cc: Thomas Renninger , pavsubra@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] cpupower tools: Fix error when running cpupower monitor Date: Fri, 04 Sep 2015 16:51:47 +0200 Message-ID: <3332765.Ktj2LzF70A@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <55E7E6E2.3090900@linux.vnet.ibm.com> References: <1438582560-13352-1-git-send-email-shreyas@linux.vnet.ibm.com> <55DC58BD.4070108@linux.vnet.ibm.com> <55E7E6E2.3090900@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 03, 2015 11:51:22 AM Shreyas B Prabhu wrote: > > On 08/25/2015 05:29 PM, Shreyas B Prabhu wrote: > > > > > > On 08/17/2015 01:22 PM, Shreyas B Prabhu wrote: > >> > >> > >> On 08/10/2015 05:58 PM, Thomas Renninger wrote: > >>> On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote: > >>>> get_cpu_topology() tries to get topology info from all cpus by reading > >>>> files in the topology sysfs dir. If a cpu is offlined, since it doesn't > >>>> have topology dir, this function fails and returns -1. This causes > >>>> functions relying on get_cpu_topology() to fail. For example- > >>>> > >>>> $ cpupower monitor > >>>> Cannot read number of available processors > >>>> > >>>> Fix this by skipping fetching topology info for offline cpus. > >>> > >>> Looks fine. > >>> > >>> Thanks! > >>> > >>> Acked-by: Thomas Renninger > >>> > >> > >> Thanks Thomas! > >> Rafael, can you please pick this patch? > >> > >> > > > > > > Hi Rafael, > > > > If this patch looks good can you please pick this up? > > > > > > Thanks, > > Shreyas > > > > Hi Rafael, > > If this patch looks good can you please pick this up? I picked it up last week, sorry for being silent about that. It should be in the Linus' tree already. Thanks, Rafael