From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3468C6FD18 for ; Tue, 28 Mar 2023 13:42:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233039AbjC1NmT (ORCPT ); Tue, 28 Mar 2023 09:42:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232842AbjC1NmJ (ORCPT ); Tue, 28 Mar 2023 09:42:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86CE67A88; Tue, 28 Mar 2023 06:41:53 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3D5286603152; Tue, 28 Mar 2023 14:41:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680010911; bh=mdZaeHtWUcUws+H6KHaUGd/J+/ss4cO3a1++cudlA0E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LZG/eBD8utsG50ZHCgvDv2s5UltJ6GMYEzujJ260sZbFSgxCRB/ndUNYo8UTgpOOL 5Cc4T7oYgSQBhbd/KU+xGIwgwNj+ikhxH1KEL/jyD5KGCnGwEjxK/dL/gkCM1YcCiu z0/ido9OaQyUi2aogP5cMgAurotCLPcr4+ay34Pen7CFJViiovacmbEuNv74jRn7Zs OX2nx2h9AG/TjxUkH/3fPUP5eZZ/+lS71Uvmw8cG7Qiyc1TxhAbGXarYODvSfaG8vK /NemcTJ5C6JSYBnZuN76G1gsJd7dWSklXXKPbk5+rRkfI6kLgYDUolu+Xanq10LbL3 KizIBlytgiuNg== Message-ID: <334089fd-f0e8-bf63-5100-d8632c478ccc@collabora.com> Date: Tue, 28 Mar 2023 15:41:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: mediatek: deprecate custom drive strength property Content-Language: en-US To: Alexandre Mergnat , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Zhiyong Tao , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230327-cleanup-pinctrl-binding-v1-0-b695e32e4f2e@baylibre.com> <20230327-cleanup-pinctrl-binding-v1-1-b695e32e4f2e@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230327-cleanup-pinctrl-binding-v1-1-b695e32e4f2e@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 28/03/23 15:06, Alexandre Mergnat ha scritto: > Deprecate mediatek,drive-strength-adv which shall not exist, that was an > unnecessary property that leaked upstream from downstream kernels and > there's no reason to use it. > > The generic property drive-strength-microamp should be used instead. > > Signed-off-by: Alexandre Mergnat > --- > .../devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++++-- > .../devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 6 +++++- > 2 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > index c30cd0d010dd..b82a066b91ec 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml Thanks for doing MT8183!!! > @@ -110,8 +110,13 @@ patternProperties: > drive-strength: ..snip.. > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > index 4b96884a1afc..347f533776ba 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > @@ -91,8 +91,13 @@ patternProperties: > > input-schmitt-disable: true > > + drive-strength-microamp: > + enum: [125, 250, 500, 1000] > + > mediatek,drive-strength-adv: > + deprecated: true In the case of MT8365, since there's *no* devicetree using this property, *at all*, I think you can even just entirely remove this block, as that should not be considered an ABI breakage in that case. Krzysztof, can you please confirm? Cheers! Angelo