From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF9E3C7EE24 for ; Mon, 5 Jun 2023 19:27:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235684AbjFET06 (ORCPT ); Mon, 5 Jun 2023 15:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233417AbjFET0x (ORCPT ); Mon, 5 Jun 2023 15:26:53 -0400 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74800A7 for ; Mon, 5 Jun 2023 12:26:51 -0700 (PDT) Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-77479a531abso36969639f.1 for ; Mon, 05 Jun 2023 12:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1685993211; x=1688585211; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SDo7XtFOYBpwy+0dVg9gsbUS6v4geWCMhu075220fa0=; b=ZrV6yYS5Q7Arc+OZCGzuRFxx156ccGPF1+IFPv8QOz0CAoPS6NBJXtaLbMTK98wy2c ac6jEGfPTIzTWvniehv2QEjc+/6qls46EqTOG02uWYCCiL4UL7Zhlk+1FZJ1kUHUE6t7 bqFoICbiAGR2RLw+NRe2AxDp5EAWevmCBi2sU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685993211; x=1688585211; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SDo7XtFOYBpwy+0dVg9gsbUS6v4geWCMhu075220fa0=; b=QRcOTQPpSmNMpR56x1+WOe8T2KIK/0h0X92l9ncHszC6PluMrMii5U5/ovldFCHHKR AWoKeJLcBWK8PHCNwPlgdsgUfciQ0vHIufDusD5WQKLaPl+y2NME4jCTdhAfH5+M3L3e gCy+wRkdV0TS/CYedbEwrwoY9AT9OSLtFVjh07sw5oQaEGcEoWK3iY8l75hIvcMuDW4u wuv+mrSsfvYvmcX5hRxD1QZS2BJM06Jx94i7z0IFur6VqatGJ9ZjFAxNF+qZicGpOSMt 4nR2QTQypz+OTgF/tQiGiehNhuixygnLX8irbtxzD75cUPe8CWd5Qx1dSbzmKWFFNWWn P3AA== X-Gm-Message-State: AC+VfDySSVTQ2/DrGGOOu02Zbs1h1Lzw96kalMtla2s4OagYGLVQoXSP bsfpJ5+XJ/7b+aHWX8lbOGDYDQ== X-Google-Smtp-Source: ACHHUZ4JUvhFOhBUpHnL0B6iiTL4Nk5qsfPPHNU1HgYjdVHcWP6cRnvamLzwzcLKW9Rax8D/DGM/4Q== X-Received: by 2002:a92:7113:0:b0:338:83c6:ae9a with SMTP id m19-20020a927113000000b0033883c6ae9amr58364ilc.0.1685993210824; Mon, 05 Jun 2023 12:26:50 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id c16-20020a92d3d0000000b00325df6679a7sm2591199ilh.26.2023.06.05.12.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 12:26:50 -0700 (PDT) Message-ID: <33481784-f1c8-cc0f-4c68-404efcf2258d@linuxfoundation.org> Date: Mon, 5 Jun 2023 13:26:49 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs Content-Language: en-US To: Christian Brauner , Ziqi Zhao Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20230523232207.363136-1-astrajoan.ref@yahoo.com> <20230523232207.363136-1-astrajoan@yahoo.com> <20230524-tausend-erlitt-b3163dd1dd05@brauner> From: Shuah Khan In-Reply-To: <20230524-tausend-erlitt-b3163dd1dd05@brauner> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/23 03:12, Christian Brauner wrote: > On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote: >> An output message: >> >>> # # waitpid WEXITSTATUS=0 >> >> will be printed for 30,000+ times in the `pidfd_test` selftest, which >> does not seem ideal. This patch removes the print logic in the >> `wait_for_pid` function, so each call to this function does not output >> a line by default. Any existing call sites where the extra line might >> be beneficial have been modified to include extra print statements >> outside of the function calls. >> >> Signed-off-by: Ziqi Zhao >> --- > > Fine by me, > Reviewed-by: Christian Brauner Thank you. Applied to linux-kselftest next for Linux 6.5-rc1. thanks, -- Shuah