From: Chao Yu <yuchao0@huawei.com>
To: <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <chao@kernel.org>
Subject: Re: [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite
Date: Mon, 19 Aug 2019 14:30:12 +0800 [thread overview]
Message-ID: <3349ceea-85ac-173a-81a4-1188ce3804ca@huawei.com> (raw)
In-Reply-To: <20190816030334.81035-1-yuchao0@huawei.com>
On 2019/8/16 11:03, Chao Yu wrote:
> There is one case can cause data corruption.
>
> - write 4k to fileA
> - fsync fileA, 4k data is writebacked to lbaA
> - write 4k to fileA
> - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet
> - write 4k to fileB
> - kworker flush 4k to lbaA due to SSR
> - SPOR -> dnode with lbaA will be recovered, however lbaA contains fileB's
> data
>
> One solution is tracking all fsynced file's block history, and disallow
> SSR overwrite on newly invalidated block on that file.
>
> However, during recovery, no matter the dnode is flushed or fsynced, all
> previous dnodes until last fsynced one in node chain can be recovered,
> that means we need to record all block change in flushed dnode, which
> will cause heavy cost, so let's just use simple fix by forbidding SSR
> overwrite directly.
>
Jaegeuk,
Please help to add below missed tag to keep this patch being merged in stable
kernel.
Fixes: 5b6c6be2d878 ("f2fs: use SSR for warm node as well")
Thanks,
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/segment.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 9d9d9a050d59..69b3b553ee6b 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2205,9 +2205,11 @@ static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
> if (!f2fs_test_and_set_bit(offset, se->discard_map))
> sbi->discard_blks--;
>
> - /* don't overwrite by SSR to keep node chain */
> - if (IS_NODESEG(se->type) &&
> - !is_sbi_flag_set(sbi, SBI_CP_DISABLED)) {
> + /*
> + * SSR should never reuse block which is checkpointed
> + * or newly invalidated.
> + */
> + if (!is_sbi_flag_set(sbi, SBI_CP_DISABLED)) {
> if (!f2fs_test_and_set_bit(offset, se->ckpt_valid_map))
> se->ckpt_valid_blocks++;
> }
>
next prev parent reply other threads:[~2019-08-19 6:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 3:03 Chao Yu
2019-08-19 6:30 ` Chao Yu [this message]
2019-08-20 1:00 ` Jaegeuk Kim
2019-08-20 9:16 ` Chao Yu
2019-09-26 20:37 ` [f2fs-dev] " Eric Biggers
2019-09-26 21:46 ` Jaegeuk Kim
2019-09-27 0:32 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3349ceea-85ac-173a-81a4-1188ce3804ca@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®