From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: use patch subject when reading from stdin
Date: Tue, 08 Oct 2019 11:50:01 -0700 [thread overview]
Message-ID: <334aea9d82188d0cec300d7c02e59afff29b1d0a.camel@perches.com> (raw)
In-Reply-To: <CAMuHMdUpqimKRn_VO+K5TB7+jhvxay1p61kPqgyLVOLwAsfJFw@mail.gmail.com>
On Tue, 2019-10-08 at 20:39 +0200, Geert Uytterhoeven wrote:
[]
> > I still think the patch I suggested is better as it
> > functions for other use cases too.
>
> I agree it would be better if checkpatch would handle the splitting in
> patches itself, as that would be easier for the user.
>
> However:
> 1) That requires getting the state reset right,
Not really difficult and maybe not necessary.
The process subroutine contains very limited state.
The biggest issue is resetting the "$in_header_lines"
states and such when a new multi-patch bundle
start is detected. I'm not sure it actually impacts
the checkpatch output much. Maybe it'd not emit a
>75 character warning when scanning commit log messages.
> 2) Using formail is the classical old UNIX way (combine small tools
> to get the job done ;-)
Which doesn't impact your use case as formail is
already running checkpatch multiple times.
cheers, Joe
next prev parent reply other threads:[~2019-10-08 18:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:40 Geert Uytterhoeven
2019-10-08 12:50 ` Joe Perches
2019-10-08 12:59 ` Geert Uytterhoeven
2019-10-08 15:20 ` Joe Perches
2019-10-08 15:28 ` Geert Uytterhoeven
2019-10-08 17:02 ` Joe Perches
2019-10-08 18:10 ` Geert Uytterhoeven
2019-10-08 18:25 ` Joe Perches
2019-10-08 18:39 ` Geert Uytterhoeven
2019-10-08 18:50 ` Joe Perches [this message]
2019-10-14 9:20 ` Geert Uytterhoeven
2019-10-14 14:48 ` Joe Perches
2019-10-15 6:49 ` Geert Uytterhoeven
2019-10-15 15:50 ` Joe Perches
2019-10-15 16:40 ` Geert Uytterhoeven
2019-10-15 17:24 ` Joe Perches
2019-10-16 6:57 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=334aea9d82188d0cec300d7c02e59afff29b1d0a.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®