From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935202AbdLSKIc (ORCPT ); Tue, 19 Dec 2017 05:08:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:50741 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934835AbdLSKI1 (ORCPT ); Tue, 19 Dec 2017 05:08:27 -0500 Subject: Re: [Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host memory as UNUSABLE To: Jan Beulich Cc: christian.koenig@amd.com, helgaas@kernel.org, xen-devel@lists.xen.org, Boris Ostrovsky , linux-kernel@vger.kernel.org References: <1513635771-11779-1-git-send-email-boris.ostrovsky@oracle.com> <5A38DA840200007800198579@suse.com> <5A38E9A502000078001985CF@suse.com> From: Juergen Gross Message-ID: <334c80f2-92a6-7e24-8cf1-c6472194f813@suse.com> Date: Tue, 19 Dec 2017 11:08:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5A38E9A502000078001985CF@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/12/17 10:27, Jan Beulich wrote: >>>> On 19.12.17 at 10:21, wrote: >> On 19/12/17 09:23, Jan Beulich wrote: >>>>>> On 18.12.17 at 23:22, wrote: >>>> +void __init arch_xen_balloon_init(struct resource *hostmem_resource) >>>> +{ >>>> + struct xen_memory_map memmap; >>>> + int rc; >>>> + unsigned int i, last_guest_ram; >>>> + phys_addr_t max_addr = max_pfn << PAGE_SHIFT; >>> >>> PFN_PHYS() as right now you still have an issue on 32-bit. >> >> Why? PFN_PHYS is defined as: >> >> #define PFN_PHYS(x) ((phys_addr_t)(x) << PAGE_SHIFT) > > Well, that's why I suggested its use (just like you did in your > own review). IOW - now I'm confused. Sorry, just got your answer wrong. As I had already found the same issue somehow I assumked this remark would be referencing my review. Sorry for the noise. Juergen