mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stanimir Varbanov <svarbanov@suse.de>
To: Ricardo Ribalda <ribalda@chromium.org>,
	Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Vikash Garodia <quic_vgarodia@quicinc.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 01/10] media: venus: Use flex array for hfi_session_release_buffer_pkt
Date: Wed, 14 Aug 2024 00:38:50 +0300	[thread overview]
Message-ID: <3352aa92-6c50-45c6-b5a7-215e359bdf0c@suse.de> (raw)
In-Reply-To: <20240813-cocci-flexarray-v6-1-de903fd8d988@chromium.org>

Hi Ricardo,

On 8/13/24 15:31, Ricardo Ribalda wrote:
> Replace the old style single element array with a flex array. We do not
> allocate this structure, so the size change should not be an issue.
> 
> This fixes the following cocci warning:
> drivers/media/platform/qcom/venus/hfi_cmds.h:204:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Could you inverse the order of the tags, please. "Signed-off-by" must be
first and then the others.

All patches in the series has this issue.

~Stan


  reply	other threads:[~2024-08-13 21:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 12:31 [PATCH v6 00/10] media: Fix the last set of coccinelle warnings Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 01/10] media: venus: Use flex array for hfi_session_release_buffer_pkt Ricardo Ribalda
2024-08-13 21:38   ` Stanimir Varbanov [this message]
2024-08-14 11:40     ` Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 02/10] media: venus: Refactor struct hfi_uncompressed_plane_info Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 03/10] media: venus: Refactor struct hfi_session_get_property_pkt Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 04/10] media: venus: Refactor struct hfi_uncompressed_format_supported Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 05/10] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 06/10] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 07/10] media: venus: Refactor hfi_sys_get_property_pkt Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 08/10] media: venus: Refactor hfi_session_fill_buffer_pkt Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 09/10] media: venus: Refactor hfi_buffer_alloc_mode_supported Ricardo Ribalda
2024-08-13 12:31 ` [PATCH v6 10/10] media: venus: Convert one-element-arrays to flex-arrays Ricardo Ribalda
2024-08-14  4:41   ` Sergey Senozhatsky
2024-08-14  8:06     ` Ricardo Ribalda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3352aa92-6c50-45c6-b5a7-215e359bdf0c@suse.de \
    --to=svarbanov@suse.de \
    --cc=bryan.odonoghue@linaro.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vgarodia@quicinc.com \
    --cc=ribalda@chromium.org \
    --cc=stanimir.k.varbanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®