From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Brent Lu <brent.lu@intel.com>, alsa-devel@alsa-project.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Yong Zhi <yong.zhi@intel.com>,
Vamshi Krishna Gopal <vamshi.krishna.gopal@intel.com>,
linux-kernel@vger.kernel.org, Rander Wang <rander.wang@intel.com>,
Bard Liao <bard.liao@intel.com>,
Malik_Hsu <malik_hsu@wistron.corp-partner.google.com>,
Libin Yang <libin.yang@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Paul Olaru <paul.olaru@oss.nxp.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Mac Chiang <mac.chiang@intel.com>,
Gongjun Song <gongjun.song@intel.com>
Subject: Re: [PATCH 0/3] Multiple headphone codec driver support
Date: Wed, 6 Oct 2021 11:50:08 -0500 [thread overview]
Message-ID: <33538866-03a3-4866-2edc-f5fb5928b08f@linux.intel.com> (raw)
In-Reply-To: <20211006161805.938950-1-brent.lu@intel.com>
On 10/6/21 11:18 AM, Brent Lu wrote:
> Support multiple headphone drivers in same machine driver. In this
> case, both rt5682 and rt5682s are supported and enumerated by different
> ACPI HID "10EC5682" and "RTL5682".
Ah, now I get what you're trying to do. I like this a lot!
This is really a 'compatible_id' that the machine driver is capable of
handling.
It would be quite useful indeed to prune some of the tables we have, e.g.
"10EC5640" "10EC5642", "INTCCFFD"
"10EC5645" "10EC5648", etc
In your case you pushed the logic a bit further in that the codec driver
might be different, but the machine driver can deal with it with
run-time autodetection.
Would you mind going through the tables and suggest additional
simplifications with more patches when relevant?
> Brent Lu (3):
> ASoC: soc-acpi: add alternative id field for machine driver matching
> ASoC: Intel: sof_rt5682: detect codec variant in probe function
> ASoC: Intel: sof_rt5682: use id_alt to enumerate rt5682s
>
> include/sound/soc-acpi.h | 2 ++
> sound/soc/intel/boards/sof_rt5682.c | 34 +++----------------
> .../intel/common/soc-acpi-intel-adl-match.c | 8 +++++
> .../intel/common/soc-acpi-intel-byt-match.c | 6 ++++
> .../intel/common/soc-acpi-intel-cht-match.c | 6 ++++
> .../intel/common/soc-acpi-intel-cml-match.c | 8 +++++
> .../intel/common/soc-acpi-intel-icl-match.c | 6 ++++
> .../intel/common/soc-acpi-intel-jsl-match.c | 32 +++++------------
> .../intel/common/soc-acpi-intel-tgl-match.c | 8 +++++
> sound/soc/soc-acpi.c | 21 +++++++++++-
> 10 files changed, 76 insertions(+), 55 deletions(-)
>
prev parent reply other threads:[~2021-10-06 16:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 16:18 Brent Lu
2021-10-06 16:18 ` [PATCH 1/3] ASoC: soc-acpi: add alternative id field for machine driver matching Brent Lu
2021-10-06 16:44 ` Andy Shevchenko
2021-10-06 16:50 ` Pierre-Louis Bossart
2021-10-06 16:18 ` [PATCH 2/3] ASoC: Intel: sof_rt5682: detect codec variant in probe function Brent Lu
2021-10-06 16:18 ` [PATCH 3/3] ASoC: Intel: sof_rt5682: use id_alt to enumerate rt5682s Brent Lu
2021-10-06 16:46 ` Andy Shevchenko
2021-10-06 17:18 ` Hans de Goede
2021-10-06 17:24 ` Pierre-Louis Bossart
2021-10-07 2:46 ` Liao, Bard
2021-10-07 13:49 ` Lu, Brent
2021-10-06 18:34 ` Curtis Malainey
2021-10-06 18:43 ` Pierre-Louis Bossart
2021-10-06 19:21 ` Curtis Malainey
2021-10-06 19:58 ` Pierre-Louis Bossart
2021-10-06 20:07 ` Curtis Malainey
2021-10-06 16:50 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33538866-03a3-4866-2edc-f5fb5928b08f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=cujomalainey@chromium.org \
--cc=gongjun.song@intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=libin.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=malik_hsu@wistron.corp-partner.google.com \
--cc=paul.olaru@oss.nxp.com \
--cc=perex@perex.cz \
--cc=rander.wang@intel.com \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome