From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbdHIID3 (ORCPT ); Wed, 9 Aug 2017 04:03:29 -0400 Received: from mout.web.de ([212.227.17.11]:63059 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbdHIIDZ (ORCPT ); Wed, 9 Aug 2017 04:03:25 -0400 Subject: [PATCH 2/4] ALSA: emux: Improve a size determination in two functions From: SF Markus Elfring To: alsa-devel@alsa-project.org, Jaroslav Kysela , Kees Cook , Takashi Iwai , Takashi Sakamoto Cc: LKML , kernel-janitors@vger.kernel.org References: <412aa3a5-c8b6-c1fe-febb-0d62927dacc2@users.sourceforge.net> Message-ID: <3354241b-cb2e-3d91-5dca-5e3ea427ee03@users.sourceforge.net> Date: Wed, 9 Aug 2017 10:02:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <412aa3a5-c8b6-c1fe-febb-0d62927dacc2@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:IuR5mqTYnGG1L3z4Npg6mDP6f017ZMHGt8q5rzP6mCRb6g+vE7N aKY4uAp4/yK0jKYW92VL/8jjHIX8xRgkqGZU4dznvOa9glNeJ2jNPiWptnCIm4nNqc+R8IE rj9B1WNO+eo0Eit3npneJglEGf1cxuytLLcChxm3gLd+NHJ/zOzoTq4yNJYf7+bBmyUZHLF yNyjDUGt7I0K/qJj4zsVA== X-UI-Out-Filterresults: notjunk:1;V01:K0:4qRqtDHdcQ8=:dn2SLLuUCSyNrVS3wwTyOa I6+kPKmge5hKrBsve9frRs2mvMiFT6g2Oul+zhLGVNw3XogJbA7Sn2zIQBbv724JbGtCeYbAM lES3sPcVBr/0nf0ywqLMbPA39iQzD/1AVXtgLfhTdZE7GEBRpx+u+qlMQzJm0AUHMKPateWFF 1R2YFmxnJuBlBRxT0wPefHb+LGDOPlywSkt2w1psjV87XvXPlc6jr1q9F8j5CUOSQk2LFURk3 8q4NXF/CVDrFhmp3aBRmMoK+dIoxR5toqB9JjJef3NCpTzkIDoDLpycoch04Jr8a+kPJD0lnu sa3Kd6h9NFpGr/n3FaI5CS0Uctx2Uwer6+W+xKC7KrZwkCbQEK9dUt8PMDwZPeGtgbPKeTekN dFRy+42zNOeUfoN1B2stL2/6YdHdVtaqQI0jd4trq/ha5ML/QwZPYtxPhztISXiUfaO6X3apP FqzEXzSGYGcQ1FCJfsGAuVUEDMKwnWEZsuGxdcs/z+A2QFOPb44RwNEpN8x1tn0lQmvG22zac YB+WzoiFZX8LhmU5Ex6yjR6Nt1c+U+fgNum2pmGMNphmv5ud4rUNZkvSmt1Nx0EwTOsCRrx26 /vu2HEjYdPwmsYhV1who8+G0HebovTOdJmrM4ulgpl3+rjUaJmqd4oPaSeY+Je1Y9ijQeQVzJ yewUFp9mwKFCtThaFLDDkpbEzY9ZENpOr9b79DwOGVuNPDMEFUlGJb5rI4jhFn2cCBMND8AYo jSHnx97dbWAYgsVingw9TJ6OsbvQ7Nsy7Doc7e+crAsGbT1vAeiz7yFA7GwBV759BfKqVFLpc iUhjnSCRQTVUF0P0o8YsXeP480GZqp8odQHp6ZWY4duaz8dHk4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 9 Aug 2017 09:11:26 +0200 Replace the specification of data types by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- sound/synth/emux/emux_seq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c index 53820f75ba3e..12acf18c5be4 100644 --- a/sound/synth/emux/emux_seq.c +++ b/sound/synth/emux/emux_seq.c @@ -149,7 +149,8 @@ snd_emux_create_port(struct snd_emux *emu, char *name, snd_printk(KERN_ERR "no memory\n"); return NULL; } - p->chset.channels = kcalloc(max_channels, sizeof(struct snd_midi_channel), GFP_KERNEL); + p->chset.channels = kcalloc(max_channels, sizeof(*p->chset.channels), + GFP_KERNEL); if (p->chset.channels == NULL) { snd_printk(KERN_ERR "no memory\n"); kfree(p); @@ -371,7 +372,7 @@ int snd_emux_init_virmidi(struct snd_emux *emu, struct snd_card *card) if (emu->midi_ports <= 0) return 0; - emu->vmidi = kcalloc(emu->midi_ports, sizeof(struct snd_rawmidi *), GFP_KERNEL); + emu->vmidi = kcalloc(emu->midi_ports, sizeof(*emu->vmidi), GFP_KERNEL); if (emu->vmidi == NULL) return -ENOMEM; -- 2.13.4