From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210AC2E8E08 for ; Thu, 25 Sep 2025 09:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758791932; cv=none; b=pd0FNbMT8gWMuBA6P6B+VzNBkuiZq9y24frN34a6/OHzY//EewJvCiR0Ov3QgpVC6HXwf/7qPR+LlWHdgk/bYpBsBAZUfYhRVVwi0z4izF6i/dIg3Wi9/b5BZmH+EkN4bipyg2ZiWhjhOjZXgQiueOC1FV2O1cTCwYDTgJY5BNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758791932; c=relaxed/simple; bh=aBzVgiUoATjDskwmV+O0A19hA27wGt/bIlMwuurcLQY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q9shWZh8LC36qWpVLXFXZ0+kAIRzcf+yY6sMlmChei0885mvI/JtRc9J76Vo8b9iiAnzpZFV2e2fy4qWjux0URzctjWpv9DZ1yFuDgbfXbxb4GqZFHNNDyh6bmxykOVHwoD0xkBVr8n9mL1zfvDXMBsg1b+7Py9Bf2UycWcUtos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T3fPcCME; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T3fPcCME" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58P9433g018678 for ; Thu, 25 Sep 2025 09:18:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ea+frmUPjgVv+Mq8YyoARL2w4ombZur44q+lIGeQf9A=; b=T3fPcCMEvUb2K267 hcXjAwxtuGRjOQXEtY7F18Opc1UfFKz3aC+Fd52JdfA0fgp5BH4/B6yKoBzfEybg h0EXKNlVe2fecrLcuiC8MBfTilQaTAUN3G64nwhCIq18TX32wn/7w/ZnFg8X3Shz wSXgbchIicsYgIKDPYnKbBmqIvOAK6wMYI/jCue88QPixWauH5BR14VbRMMq0Xmi eldLpRKbmTOjLuYMxK8MmasER+CICnb3/+gENHqVppB9hOft83l9PV0AiY3XeJ4j NRsD6MoxSn0PAG+n7XfbiNVzcUMYQJCb+MqyAwKDI0rH3fPWiwXb5vYZ5jT6jHJd uVVEug== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49b3kkbgcb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 25 Sep 2025 09:18:48 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-85bb4e88394so18079085a.1 for ; Thu, 25 Sep 2025 02:18:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758791928; x=1759396728; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ea+frmUPjgVv+Mq8YyoARL2w4ombZur44q+lIGeQf9A=; b=vcDRYXlJhzb5USNNTQKc24V59BITvatPhGEA4oQ4+NtXDKHBM7CD6UeQhSDccAFOIO I967BLJVMoSIDbmypN8aS8xY9mqibGGSiJXi7RS8QflrfKmCDTTvVVH43LK11uFlDJ7E dEXEzn4oUhZ+Ood+oRy7EYQplqeynp05avCW2KbwqDnLAK30yGvH8+4jWSRRJE8H2961 /M2n3UrgZ9cYvCYLROw0PvoxajdmAZ0zvuMiFTvEVuvth+n42J+joPQn4XocKBtn1004 xy7VxPg2YHCH1kGNT5dsX1gbAzB0fb6woRIjf6RibSZqWxlrIU/MBfXJudVgpsz23KSk yaCQ== X-Forwarded-Encrypted: i=1; AJvYcCVbg2bWspjnvBTYYgZHmaj+i3IgikH8wmc7kjShtunpz3QfBhSeAwhqLxEXXXVPYKYpHDEmIq6Z4kd6S0Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4BLA1zuRmC/twUtnJRP5rAMw7xSzF/dc27w4KXXL9ShM4XcbV h1N57ak/Rc69q7r/WdVaRdPNXryUxlM9KAg8yBKWFF4xsxqXlBSR5vVVN2jEI/E9jKAJQGRz1Kv 4xCwY/h4GLaelZ1KX1sMX8dLS9Y9erfhKF4U1EKV76coQDCLZcqdIZTUC6YojWJX424l3jWpfVz g= X-Gm-Gg: ASbGncsqxpseiabJwytjeRHU4r8Br0aJz/ikXA/Q0sS1wq7k243FnEnjcZUIiVXJw4a wV5lOjovrcgduYq31xfTWFFYa+UsesaZ0pQDaK2NQReGJ2qrzoLzZJWO2ohX7aplQK1LPVTpaxs 5FvGkg+o8IrWv9JbzNlLjVOpNQCLGbugS0gkDDBYRuWqTjdo42Yqv/DyplMIVIc+HD1ocjORWnO 5RSqK4tP3JOg8+GUdDavsg9KYGKVwRi1AmUaEVXQs8MsnfQNdqQKmG4uM4TrTCwxSEFSjw8bh9L G0tQ81aOpGy5Nx59WCo9FKmo4rvIYkRa5xOAmJw0w7/0nOUvbs3udVYr7dG9fI8SLTwcCW9/NaG KFUZhzkyBARy+WhC+jwS8yQ== X-Received: by 2002:a05:620a:2948:b0:7e3:297d:ec32 with SMTP id af79cd13be357-85ae6b98c31mr219202585a.10.1758791928103; Thu, 25 Sep 2025 02:18:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9ZYl0aa3NdV1AUBuLFOtIFJqHnpIWD3oOeW+CrL7tUMx6aQqFaHJq4P9k7znBgc2to9oBTg== X-Received: by 2002:a05:620a:2948:b0:7e3:297d:ec32 with SMTP id af79cd13be357-85ae6b98c31mr219200385a.10.1758791927534; Thu, 25 Sep 2025 02:18:47 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b3544fd0a54sm128782566b.86.2025.09.25.02.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Sep 2025 02:18:47 -0700 (PDT) Message-ID: <3355306e-4059-4af5-8865-3b5335356382@oss.qualcomm.com> Date: Thu, 25 Sep 2025 11:18:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] media: iris: Introduce vpu ops for vpu4 with necessary hooks To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20250925-knp_video-v1-0-e323c0b3c0cd@oss.qualcomm.com> <20250925-knp_video-v1-7-e323c0b3c0cd@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250925-knp_video-v1-7-e323c0b3c0cd@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: OA0zvLDy1xqzyVisl_ossKuoH0JCE8-E X-Proofpoint-ORIG-GUID: OA0zvLDy1xqzyVisl_ossKuoH0JCE8-E X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTIyMDA4OSBTYWx0ZWRfX0aASCk+x2l6l swsKv6ouA70ZqPctwniObERoCaCN5e8fOHeCbNNY+ENzW1Fi1xMozYU/6p6eXQEy95WqQ9VgikT 5mXpppgmxAG7KvnG/MADN4+blkxG3exUqgovnED4XD4ls/P6hKVjQvqNqW/ZoppvHPdBRBRRhFq zssMh40e3Gcfq8Iqvz2N637EeNMfXTkyIB/Fbm99x6g1a2jS6e/PLiXofw4IecB3B4lVlyyLu1L OT8EcA7gMuD+0ln9jTQTkrEx1pvlP2DsE5X6OFxrm9Q3AcfaKrnTEmjUp45MVVVrk5eTYYIxV1x ymrL8Q67GtkJW0dpSyq3xt/tQsTNk6w/32mC100+UldnC0KbXgZ8z+S0TP3B2Lvq4Rgm35q39Ro /GuzORFR X-Authority-Analysis: v=2.4 cv=BabY0qt2 c=1 sm=1 tr=0 ts=68d508f9 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=Z7GqTKoUbcai2g_QebIA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-24_07,2025-09-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509220089 On 9/25/25 1:14 AM, Vikash Garodia wrote: > Add power sequence for vpu4 by reusing from previous generation wherever > possible. Hook up vpu4 op with vpu4 specific implemtation or resue from > earlier generation wherever feasible, like clock calculation in this > case. > > Co-developed-by: Vishnu Reddy > Signed-off-by: Vishnu Reddy > Signed-off-by: Vikash Garodia > --- [...] > +#include > +#include > +#include "iris_instance.h" > +#include "iris_vpu_common.h" > +#include "iris_vpu_register_defines.h" > + > +#define WRAPPER_EFUSE_MONITOR (WRAPPER_BASE_OFFS + 0x08) > +#define AON_WRAPPER_MVP_NOC_RESET_SYNCRST (AON_MVP_NOC_RESET + 0x08) > +#define CPU_CS_APV_BRIDGE_SYNC_RESET (CPU_BASE_OFFS + 0x174) > +#define DISABLE_VIDEO_APV_BIT BIT(27) > +#define DISABLE_VIDEO_VPP1_BIT BIT(28) > +#define DISABLE_VIDEO_VPP0_BIT BIT(29) > +#define CORE_CLK_HALT BIT(0) > +#define APV_CLK_HALT BIT(1) > +#define CORE_PWR_ON BIT(1) > + > +static int iris_vpu4x_genpd_set_hwmode(struct iris_core *core, bool hw_mode) > +{ > + u32 value = readl(core->reg_base + WRAPPER_EFUSE_MONITOR); I think this could use some explanations. I'll go ahead and assume that the eFuse tells us that parts of the IP are disables (hopefully not all three at once.. we shouldn't advertise the v4l2 device then, probably) You read back the fuse register a lot, even though I presume it's not supposed to change at runtime. How about we add: bool vpp0_fused_off bool vpp1_fused_off bool apv_fused_off instead? [...] > + if (!(value & DISABLE_VIDEO_VPP0_BIT)) { > + ret = iris_enable_power_domains(core, core->pmdomain_tbl->pd_devs > + [IRIS_VPP0_HW_POWER_DOMAIN]); Maybe the iris_en/disable_foo functions could get a wrapper like: int iris_enable_power_domains_if(core, pd_devs[IRIS_VPP0_HW_POWER_DOMAIN], !foo->vpp0_fused_off) I'm not super sure about it, but that's something to consider [...] > + readl_poll_timeout(core->reg_base + VCODEC_SS_IDLE_STATUSN, value, > + value & 0x7103, 2000, 20000); That's a nice magic number.. but what does it mean? [...] > + writel(0x070103, core->reg_base + AON_WRAPPER_MVP_NOC_RESET_REQ); > + readl_poll_timeout(core->reg_base + AON_WRAPPER_MVP_NOC_RESET_ACK, > + value, value == 0x070103, 200, 2000); That's a slightly different magic number, but it's oddly similar to the one above Konrad