From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbdEIL1t (ORCPT ); Tue, 9 May 2017 07:27:49 -0400 Received: from mail-by2nam01on0056.outbound.protection.outlook.com ([104.47.34.56]:15136 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751210AbdEIL1r (ORCPT ); Tue, 9 May 2017 07:27:47 -0400 Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH] gpu: drm: amd: amdgpu: remove dead code To: "Gustavo A. R. Silva" , Alex Deucher , David Airlie , Tom St Denis , Chunming Zhou , Monk Liu , Huang Rui References: <20170508164113.GA9196@embeddedgus> CC: , , , Peter Senna Tschudin From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <3356a8d8-2cb0-7572-7bd4-2b2e4c509441@amd.com> Date: Tue, 9 May 2017 13:27:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170508164113.GA9196@embeddedgus> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:cc01:fd02:e71b:fe7f] X-ClientProxiedBy: DB6PR0802CA0033.eurprd08.prod.outlook.com (10.172.252.147) To DM5PR12MB1306.namprd12.prod.outlook.com (10.168.237.149) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bfa2977-792d-436d-59d3-08d496ce6a67 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:DM5PR12MB1306; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;3:cwWSNyjgrvKUFdVKoO62MpUxdyBEE+YqOG6TG8755863oyIj8agU+8xGuL7R0WbuUJyR2b6sYMYwU2P7PP7+w3+3Fj659djAJvBiAg1Yx/zC7rlx0dUXz1ksNPKFkkqji69V3qd8cMNU30zh8Znbcepy10AAPCAc59x1rK4KP16LtbFAL0KLoAUchG7dQ4965UqYm3O5g5u5uLw9Mjd2HVxcaOUxVpl5nIelS0eZqAN6WbZlCA/Ywq9ryuTcAZnt2a/aXQY5ul40CAkbUAbUopINbKPWtARCaWPeYAJ43iR/wYcbEg/Lx5/SRS42v+ikqd9nf/Ba7t34bXB+lpmBjkP78PeOkXGo0M6Snd/vJQo=;25:d2ssmLyO2dht1Ar38XAVoU4hsvP+ZUvzPtMnXIujmBNZa8BdMsTDobCy++pLFcpLsu3WiXs0/NuUSpJNHHn8wVfS+pWRWAvAIVaQofwUi9MRJwYfoGxqX5fQfHrdC0c5NSt4yA6UOHMbkk9xA2pl5yTxN+SShCwNGRTsIkqZ4YSV8TFkNpc8zT1R0LuiBpiRfmyjTWea0YR67AzNQsEez9HsG7+F3mC5bLMgs0kNJJkw3ipvmqfhsS86dQDmWIWQPOJ4TnAFrCeKmBYaIWn6DVmQbsnq5ROW4se3lTL7Pzcuvq1TrN9qjaXABKZB6/0qBC19oM0wSk5uNCiAqwz81dh/hUJBVnZy6kMbM8vsL4y+UO5WS5L5TkdV7umBR2qAdwdXIbVFIl2NsQtU4+BQTNsbmJfEC8Xq7EtSnh6DKD8qoFVQ10t4/jhyKT7MXsR0nX7XdXTVb6mSymgePHTCASfVpa299aZ7ecbXeZXLyIk= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;31:1vRPs0SPAwmrRs55NLk24y1939vIZ+bfM8ymaDGBieB1lCiSFmGNehWXXpKbMKddoBEaYQ6XiigWefwH8o+13erCok99bUtEosPz4rI9HcwpH2EfPoOGMMz0uJHHfgAttcBgk7d2Ry4vykJKBJLMYq+ogau+9DGJ+jSRP0lv6gb3IHVOZfSyJFkwx9/UQdjDGcdRIPgH0nV2AYuzuZLK/dgALNPG7DVHANznlA4r+Rk=;20:gnzGkeBwQjKE7Fb7zuRUiXzYtIjoiVZ5C2SoZ1YgFhZytYlRzuL12+6W5CxYFGEGAYk9yfdeockwE4CdYW/V7DbFhWycLGYpikxnK4L1qZt3G7XiJ3VWsFP7Irw77IYlETN1EIe/eSq6IDxZUzqZ6gSk4bL+tuJS+uRHKNJFysUwI3GdmevAeMpCNLDjotNvyLQd9e+MAj1zuR2tIoeALnxEZ5jp7hZYmlQeVDfqKsPJM8QZtSvPckfc5DFXRGSDAwy274aAtznl5KvZl4LwME5dj7A+d72UnyCiRXpBXrBJ6CPPuZL7ZHEIFZRhPW7juPhCLUkJTDePoXFEzESpVKRLDaD4iMlwhiwS/pvwdGabeRAsDPf+CaH3lTM8iIkllXwpiaFJV3VYjYtCs6JqRhzT7SAP87I1pws/rfyT8u6+RUqtGSjcfLUwdZsTABtgJap4gYw0uUGCALwIVj6KM8rxtQLqU4q3lVJacuT0enip3p+JMIEADuI69wA0/L29 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123562025)(6072148);SRVR:DM5PR12MB1306;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1306; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;4:3vSgBHbhMFTgcWfK7qYRg2VrP2XDu6w2hbQdMUVMzRr5etKcX4YPKMmVuuU6XU+Q5uJBgth+tSz9vsg234EvHj6e+1C+4y1tJHzX515YThrDm9E1svGzsIsVq4r/odoX9vQ8NgYdazx0QMMzq9sX/B2k//in++RMvG5pn0vnnPOmM0eRWiPBpEthGDB0/4OJoa9vafr8i2kcMXiQ/fEF4e7AvCNHZ/mOah/YhPgKCxvxm6HLEle7P17pOqkZ1LedfHERPmHchAt54ZFSkkQ4Pe1FmDGgfabudgDYrE1Enyf/xYAeyoZqk697kY8bomF7QpD3Fvcf6NAGzd7zmPFudPDMiYxwFq+o1WRgANSKj8fTYboWHN7qY73NC2WLhkVctvvLR8dVxfBZ9eD/HMinhGFwzo/bhw/Cg/uN9aUGi6K3IInpev8L4gopVMAnY+iQ7BgZynvCIFJuG2K1ZjUOIJxPNRxBadbodsOCar6gRkYG1viMH6JfmJJye60nmOYa0JPveIaXrXsY26d3STgSajsrxMfaUhISPh6kyiGOuQ8aNAcX+YeUKDei6YkyV8QtdBBPjij/YIO5kyLHRnqs9bxsFUVSRmIRMJhEbRxBrEp9Ded6aNMXTOYk8Yk90k95v1yGlf5TZb3D3xLu1dPhBUfbz30PEAOZZlJgD7jURi9wSiorMi6AMoMDonr8xSAqmv4NU8+Wuzw0YdZnmlv3QnsjuINQoqeH7iVCK92PPHh9lIjrLJedI5anpsMr+mA3eJ8iC1gCPHAqDkax3JrYczh4MwPRmhAnrcPPFke0hlu0Sxc25yBPiMvLjqRuLkZ6ZXgK9PoOw39rKylNKk5CLQ== X-Forefront-PRVS: 0302D4F392 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39840400002)(39450400003)(39410400002)(39400400002)(39850400002)(6636002)(2870700001)(23746002)(47776003)(50986999)(53936002)(65826007)(36756003)(76176999)(54356999)(8676002)(5660300001)(305945005)(6486002)(64126003)(4326008)(38730400002)(50466002)(54906002)(81166006)(478600001)(33646002)(25786009)(2950100002)(42186005)(7736002)(189998001)(31696002)(31686004)(86362001)(229853002)(2906002)(6116002)(6666003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1306;H:[IPv6:2a02:908:1251:7981:cc01:fd02:e71b:fe7f];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR12MB1306;23:qo3f+kHLXbUtKJFr72UngrsgyO2bcMKo3x3sS?= =?Windows-1252?Q?Cl0IV3J2bhOOdfBjOghbugbdKxrOzgy1xu7hHHBAnPVDlC3gpDT8SMss?= =?Windows-1252?Q?ajTJtqrbHfWImHyVtmpRZmiIsIFxpKumyOcmuEI4hE0LrccYzu4jVuXJ?= =?Windows-1252?Q?/Fri0Q3G5NKou4VfKQ8sn1geN/fuj0LkBIpD5umMrJAfMQZhF2CN3sVe?= =?Windows-1252?Q?F/8DOdXGMYlTuYqL6R+Pjt+CdfLF+NqUybrM2JzmLVvd2dv6XBN5mdan?= =?Windows-1252?Q?A2OB/Wwu7QWWJKs5eFVrm1D/fy70D/5nQehGAl9kSzCe+1ba4sYT5baA?= =?Windows-1252?Q?uUXP8wZR9jh1r+/r3ccmGaqrQxXN1I1+2wSyPD2UpR60VvPqEbq300xp?= =?Windows-1252?Q?c5ODzC8dguFrs1ENgqvacI7PW96SFPscx9XRV83SmYPPuUn01Zi5Gj0q?= =?Windows-1252?Q?Yz3NIe9FW9EpvFVU8pHk9qvggjnSCgx/y8ozd7WM3I+3d8+W7GoLPOjK?= =?Windows-1252?Q?axmza/HVHximw1r+xS7zt0zOzPM10wzoF2pqnyu73EKLVpu5R3YECx7D?= =?Windows-1252?Q?Sw6P4kglmeA8vrZPy6DAApQRyFCoNM6zvkGb4cPt1BAwfi704B/G2oVk?= =?Windows-1252?Q?2zhgAt6qPVqhm4gaLMA47G6aebrVWBUmcT8IhWhMDTXjwDa5PMHQIGem?= =?Windows-1252?Q?e6iaE+gu0mZcqNI4RdS7K7oBVrWgt4uLMsG/rbSqYK9EvXyU+AeNHLXf?= =?Windows-1252?Q?nE0Q2hosocRVxtjD0aDa+C4q9EycDUcQ8DWeL7bySlVECpxEl7/eTXX/?= =?Windows-1252?Q?YtpJqKvwcRROWFEvRC6t3cqz6LFVqzB46ZeAekWltxEkFiD/SSpU3HfQ?= =?Windows-1252?Q?d8ZrrLjTKg1qwSWABQjRisuT08927nlzomQJ/bRPOcHWCYqdN2FpLgfc?= =?Windows-1252?Q?sfdplolNJZFtd0Jq+5/DbT7q3eVAqTTZIQPlc1rFmNNOBj2Dd7AN0X7D?= =?Windows-1252?Q?bF3hTLqdbwvpz7usV9T5Ljlu+76WUz8tONtusfKYkpHKWPD3/8zZ55F8?= =?Windows-1252?Q?oW9Es9pJJYbmEDirMK8OwcR26bJ/X31NQt2ddpgV1FVuBfvHpR+36Zfe?= =?Windows-1252?Q?7cQzbnmsb5if+Wu9yLXJ3k=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;6:tLcbcZ0Q7czAhFW7pBohE3fFoPskIY3w+eMgoVAsqTFOhH19rmP1/MPstwKaAIi4muQT6wsS9Xu+SNQekfjmHG9QD1f6VQj7OGsmCMGxOUOPLxhGt+t8aS2QTICHBhsmJKFf8PpvdcpEx+JA5mmXl2JtfEvFbB9Tkerh4nVvjKDBOXm+Q0m0gS0Vxp0Nn+dGQQ6DajF3czmXWq8syMkuQitt0EafMI0m31Z9M3Dyg6HXBO3vcYxaD6u/N6b8kHB0zoa5BjYvFgGOOuB8MVL86vgSO3mWdRT4I2UY9tCJ78kr+45uNHq0nSghv7pDO+d3ku2KmIuezLptyk4L+gJ3oGmBiURUFVg/t/v41GOhSulNsGM8KZk71w7J2dTHbIop0jBhUyGbereFBTlTY5riB7B9PP7YfFMEp4mTfUonwHN4xfk/dIqgDfZwfhgX0HWhm69Nilr2wVhSV7C10R3EsoT7rGvKnQPYjo2BN7PSv2cgDKKJkxjO+eyJhxI++UlcKutUHkiXZ3bnPCR0ybnqUfBLQ7ags/q5u+bmCO4a1aA=;5:hJNDWveEz1mF+/CWftjoSF8kGLao3I2LPKnDEC1x/KnQAFL4JEvGIlcXv9CA0734RU41ACjo3IwzO43/+q9mJG9+nCdY5Y7s/fg96ko2EbZNEX8i9w41rNb7Jt6MaZ2vArihX5rI6jjAHohj9SOF0w==;24:cQTKep3NhRO+7an9wcq1WVh9d0GafactmQL1tZnGYWAaomPWBxV22XQt6am8xlp4iRwmJQOH0NiNmvMliEN1UoLC8HLcCKzljDERIXfL9LE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;7:hp07wxYAbUtcSqyWC9lyWJWLPELYPJW+og0MpwsOFr0yvsB7UwPB4ZvgZf9O+KDNTwfpNOvUsoaALBLJ8YPuvyYTUyU61GxvFeelcKj4clWcRQ+65xC0mK8RY5r3cLFLtSu/n0ACKzmI4GmrF+WzaZXXTRu9ZrJAbC54Ub+XYQMVVR6uz+o3zHkydpM+wYSP6qOYdd/Ty19UvNxQzDnV9nIPBXjlPOzUG8S5LI+/Qzt0bWET6uFE/3GkvCJTnJxAbnS++P8VuHn0eCOVNbFgz7DoRMfl7LSfGsFk2PlVFg+Hdc1qJPzDrJpHHLiwsIVHbfPUsVgf7rFx/JGi8ru8ng==;20:657D1sAfXVHYcozMkAuhnShQtHKZw4TeE5xkWLZ0mDiM2L/2zRk+232IMi4KRnTgUgYbM97duKgHcNXaV/MtjYBaqrHWudop7uxP3r+mHIUG4Eu+mtsCcvxVSO7oRnKV8Gav+h12ACeM7ArxB0yBulja1DOrMubs4Ch/4V5YF93Sh2msde0pPy5u1wyuFQGFozktCsU7JB51arFGbDPth1YukJRPAMm0uEG6nzSzf44h7YUfEKV4srZWmyIHNKX2 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2017 11:27:43.8323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1306 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 08.05.2017 um 18:41 schrieb Gustavo A. R. Silva: > Local variable use_doorbell is assigned to a constant value and it is never > updated again. Remove this variable and the dead code it guards. > > Addresses-Coverity-ID: 1401837 > Signed-off-by: Gustavo A. R. Silva Acked-by: Christian König for this one and the same patch for gfx_v8. > --- > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 20 ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > index 1f93545..27ea28f 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > @@ -2936,7 +2936,6 @@ static int gfx_v7_0_cp_compute_resume(struct amdgpu_device *adev) > { > int r, i, j; > u32 tmp; > - bool use_doorbell = true; > u64 hqd_gpu_addr; > u64 mqd_gpu_addr; > u64 eop_gpu_addr; > @@ -3034,10 +3033,7 @@ static int gfx_v7_0_cp_compute_resume(struct amdgpu_device *adev) > /* enable doorbell? */ > mqd->queue_state.cp_hqd_pq_doorbell_control = > RREG32(mmCP_HQD_PQ_DOORBELL_CONTROL); > - if (use_doorbell) > - mqd->queue_state.cp_hqd_pq_doorbell_control |= CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_EN_MASK; > - else > - mqd->queue_state.cp_hqd_pq_doorbell_control &= ~CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_EN_MASK; > + mqd->queue_state.cp_hqd_pq_doorbell_control |= CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_EN_MASK; > WREG32(mmCP_HQD_PQ_DOORBELL_CONTROL, > mqd->queue_state.cp_hqd_pq_doorbell_control); > > @@ -3116,23 +3112,19 @@ static int gfx_v7_0_cp_compute_resume(struct amdgpu_device *adev) > mqd->queue_state.cp_hqd_pq_rptr_report_addr_hi); > > /* enable the doorbell if requested */ > - if (use_doorbell) { > - mqd->queue_state.cp_hqd_pq_doorbell_control = > + mqd->queue_state.cp_hqd_pq_doorbell_control = > RREG32(mmCP_HQD_PQ_DOORBELL_CONTROL); > - mqd->queue_state.cp_hqd_pq_doorbell_control &= > + mqd->queue_state.cp_hqd_pq_doorbell_control &= > ~CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_OFFSET_MASK; > - mqd->queue_state.cp_hqd_pq_doorbell_control |= > + mqd->queue_state.cp_hqd_pq_doorbell_control |= > (ring->doorbell_index << > CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_OFFSET__SHIFT); > - mqd->queue_state.cp_hqd_pq_doorbell_control |= > + mqd->queue_state.cp_hqd_pq_doorbell_control |= > CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_EN_MASK; > - mqd->queue_state.cp_hqd_pq_doorbell_control &= > + mqd->queue_state.cp_hqd_pq_doorbell_control &= > ~(CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_SOURCE_MASK | > CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_HIT_MASK); > > - } else { > - mqd->queue_state.cp_hqd_pq_doorbell_control = 0; > - } > WREG32(mmCP_HQD_PQ_DOORBELL_CONTROL, > mqd->queue_state.cp_hqd_pq_doorbell_control); >