From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3946C76196 for ; Fri, 24 Mar 2023 07:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231189AbjCXHMf (ORCPT ); Fri, 24 Mar 2023 03:12:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjCXHMd (ORCPT ); Fri, 24 Mar 2023 03:12:33 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 729F123310 for ; Fri, 24 Mar 2023 00:12:31 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id w9so4195687edc.3 for ; Fri, 24 Mar 2023 00:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679641950; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GHYARhcu7fqeGh+Mo9qe8pAsnwrLQZJjJYTNVl5/co0=; b=eQ/gIFjOOzT1h/PfMelahxCE+q5DGqaPZzYpkuWS8Ix50crh+8pLukozCcpxvnN1lN Rdwy0u6DYTq0gHaf+n5q65JduEvxaCK/TZzYMp6uI7n6DD8N3Kw1i9bT9de6O9LNSK4U JhxUYb6OL65cMdC2sMceG64Tz43ZBnCKhKjahnwMpGp0xrPFIyl1+Kb65j20+ja1tu79 PW/oSDbUmfpV+A8hH2x/MQWi22+4MviE4dpyMLpayOys3ctYUtv5Y/SPO8lH4Q+8O3aQ ZxZrG2MAX6NnYhQcP98DRhzBSMXt+Zzxm7h7rDx1LzZPkwBAOTFCwqoVddQyJovSS0Df M8pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679641950; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GHYARhcu7fqeGh+Mo9qe8pAsnwrLQZJjJYTNVl5/co0=; b=551ZaLrIpKE1VxkaI45LUDSSZzTfhFkaL+vaZaoVRqq7DMFSHvkDHSXqmfkn5dFpUN h5I8ljsAstdEWMP2w+SxYxPBK7W9f7rIc83wmA3nRt8RrAlFFknP/cYmiwFkfyZ0t/d1 Y/q9h96pqA8Elwi5R9+dR5tsotvrPhtcmU/XW9x87VM84ytKEurRSKpzBOql496OAnOh lDe4xJpFFeqbRXCmwFP5pk20vGh7njpR6GVuh4ZbwUkN9okqytM3kmwP5znI+rAhwgmI 4sRUj39rIyMsSCGk8ojvDmB80tWiYATvROSkCxcmNt/Zw6maYFyzfhH2VG9oaxwMamyK 2BnA== X-Gm-Message-State: AAQBX9fa2k2ftDm8/BDwXAZsb8cJKdMlFYhQv3xt6YpNFp72DfrxbeZd g1+gZusLnyYaE2Swt2q0yyboBw== X-Google-Smtp-Source: AKy350ZgsGG14ir1cibTF8MCHhqvpjZXYXE75aJ1CLRl2+x6YiTaEEn8kXqhVNjwE/4L8/Vzwx87Yg== X-Received: by 2002:a17:906:54cc:b0:932:c315:b0d with SMTP id c12-20020a17090654cc00b00932c3150b0dmr1642754ejp.34.1679641949969; Fri, 24 Mar 2023 00:12:29 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ce50:243f:54cc:5373? ([2a02:810d:15c0:828:ce50:243f:54cc:5373]) by smtp.gmail.com with ESMTPSA id kb1-20020a1709070f8100b00933c4a25735sm7128368ejc.100.2023.03.24.00.12.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 00:12:29 -0700 (PDT) Message-ID: <3356ecee-4e6c-8707-c26e-73329b4f4728@linaro.org> Date: Fri, 24 Mar 2023 08:12:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Content-Language: en-US To: neil.armstrong@linaro.org, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Stephen Boyd , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , linux-scsi@vger.kernel.org References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org> <0bcad5cc-112f-386c-b70e-146530ac4898@linaro.org> <215efc34-68bf-53d7-2191-a5132c3d2198@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <215efc34-68bf-53d7-2191-a5132c3d2198@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/03/2023 14:14, Neil Armstrong wrote: > On 23/03/2023 11:51, Krzysztof Kozlowski wrote: >> On 23/03/2023 11:25, Neil Armstrong wrote: >>> Fixes the following DT bindings check error: >>> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: >>> 'pinctrl-[0-9]+' >>> domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: >>> 'pinctrl-[0-9]+' >> >> I don't get from the commit msg why these properties are not correct >> here. The idle states allow them, so maybe something is missing in the >> binding? At least commit msg should explain this. > > The domain-idle-states bindings doesn't document those 2 properties, so perhaps it's missing ? Ah, you are right. These were copied from CPU idle states, so here they do not make sense. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof