From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932641AbcEKNcj (ORCPT ); Wed, 11 May 2016 09:32:39 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:55336 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932593AbcEKNcc convert rfc822-to-8bit (ORCPT ); Wed, 11 May 2016 09:32:32 -0400 From: Arnd Bergmann To: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Tejun Heo , Andy Shevchenko , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: dwc: add DMADEVICES dependency Date: Wed, 11 May 2016 15:32:18 +0200 Message-ID: <3357570.y2pHcSUkFV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1462970683-451525-1-git-send-email-arnd@arndb.de> <4546329.1O9421M58I@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Provags-ID: V03:K0:drznKk1aepwKR1luEclPqQosoL2QR12y85Xmm7k4lovFrRoOaVn k7xGcKlm2crmAxsLlvNySeNYs/4Tmz7SzZZbJbwbk2vrJq4hpoX9OxYzCjGIHReL+JUYDQ8 s9T1kqP02gY/Fa//UikePoioVYl1HXvuYxqnD/iVKyOgEApIWwj2/sQcuoXYzUiVXVCwlqR DZt0/mE0Z7IDW5w2srchQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:G7U25Lcxj0U=:K6MRJwpkpuJ46lZi7CA4qG z5XxxpP8uR6Aatd86iKnttxPJC+iCCVq++RCrnbNPCiRD4fsjsSS9xFOwhMSBZXy7K5Qp576Y NNun1fFXRAVeUMwrjrZc3ZGN7blHtb2MkpoXE47X4ZQIFT3un4ui/VoK6mff/AaiHwfp7Txik iLbbHjDyPpQ0gTILYNDmpu1pgQAzeWQx3NX6qkFRfkhdY02HReDY2wx/+r0lPI+mn8PGKQ4Ms E01ZdA3DCVdg2RL6vB1CwXQLnEeny0povRQoPmlKoADyJqmfmGswvGii7bimZLI/Qat6hGh55 0R2K/SK9zLho8hQbsm5lb1d8qctDRCLNP2cLEqLX1VP4MY0ahhwTZIFIjzDv4cRkdSD7C96mP Kt1N5vkkCVv0RJRrJr4Z6rQiXs2cp0K1O77bI7bRDAz36z6LxbVS+DiNKbV2MdoZW8awcxjL4 F79TJkJLvfoRvy+HTnXDAGRoma40uT/aELusCj8wWkolVIcT5p4BXCZwn2Fi4QctLemMBTVZl 1ihtSxNYbGVxTgbDs/T1esEd8nX9Qw797neKOVsb2faaIRnlMU6/b2I95WUp+8DalNjubRKLo ATb6/p8eX+qoQbo8KMFPxDHO7GIPdT0d0ZVS2WxnfLHlcIJX2DtuWYsOZYVL6TVq1FQLjFZmO UjlQEhX78jzEOd309Kn7S5C63Mb+kprJ4URjo+SdO8/L5Wgc4qngsyxxCKZVXfqGtgLXHYNds RMvD9GV8/eqzQ/33CmQw74OmYBDzYgR6vItrjvwJXFZ6BD1v57eM0YUwgUoUMLArE8X4hMNp5 DcToe6I3MgZ2ZUIY3S5HVT7DheGRq2SZqx3lJA4g5b0KLEzTbUV7bTbQesyqWupP1KtP0ln7b 5t0zXb4wgpBztR2XOIzn+nb9jBkoezYY4ue8unZd4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 11 May 2016 14:19:05 Måns Rullgård wrote: > Arnd Bergmann writes: > > > On Wednesday 11 May 2016 13:57:08 Måns Rullgård wrote: > >> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > >> > index 41b0725e58ad..8f7a4a4d2566 100644 > >> > --- a/drivers/ata/Kconfig > >> > +++ b/drivers/ata/Kconfig > >> > @@ -322,7 +322,7 @@ config SATA_DWC > >> > > >> > config SATA_DWC_OLD_DMA > >> > bool "Support old device trees" > >> > - depends on SATA_DWC > >> > + depends on SATA_DWC && DMADEVICES > >> > select DW_DMAC_CORE > >> > default y if 460EX > >> > help > >> > -- > >> > >> Isn't the proper fix here to have DW_DMAC_CORE select DMADEVICES? > > > > No, all dmaengine drivers depend on DMADEVICES, so that would > > cause a circular dependency. > > > > The normal behavior for DMA slave drivers is to use the generic > > DMA API and have a dependency on DMADEVICES but not on a particular > > DMA engine implementation. In this case, the driver uses an exported > > interface of the dw_dma driver directly, so we also need to select > > that one, but it doesn't mean we can skip the normal dependency. > > OK, but then shouldn't the main SATA_DWC have this dependency since it > uses the DMA API? > Right, I missed that and thought only the SATA_DWC_OLD_DMA variant used dmaengine at all. I'll send a new version of my patch then. Thanks, Arnd