From: Melissa Wen <mwen@igalia.com>
To: "Maíra Canal" <mcanal@igalia.com>,
"Emma Anholt" <emma@anholt.net>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: "André Almeida" <andrealmeid@igalia.com>,
"Juan A . Suarez" <jasuarez@igalia.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Balance mutex_init and mutex_destroy calls
Date: Thu, 10 Nov 2022 11:59:54 -0100 [thread overview]
Message-ID: <335b511f-ecfd-6e83-ef2e-7a74c8293b00@igalia.com> (raw)
In-Reply-To: <20221108175425.39819-1-mcanal@igalia.com>
On 11/8/22 16:54, Maíra Canal wrote:
> This series introduces some changes to assure the correct resource release on
> the V3D driver, especially the mutex. Currently, the V3D has no mutex_destroy()
> calls, which means that a mutex is being instantiated, but it is not being
> released by the end of its use.
>
> So, use the DRM-managed mutex_init variants when possible to manage the mutex
> release and add mutex_destroy() calls when not possible.
>
> Best Regards,
> - Maíra Canal
>
> v1 -> v2: https://lore.kernel.org/dri-devel/20221107224656.278135-1-mcanal@igalia.com/T/#m3c23e3f21fe6aaae51138c746c74e94b2a7b3bfc
>
> - Move mutex_destroy() to v3d_perfmon_put() (Daniel Vetter).
> - Add mutex_destroy() on error case in v3d_perfmon_create_ioctl() (Daniel Vetter).
> - Add Daniel Vetter's tags.
Applied to drm-misc-next.
Thanks,
Melissa
>
> Maíra Canal (2):
> drm/v3d: switch to drmm_mutex_init
> drm/v3d: add missing mutex_destroy
>
> drivers/gpu/drm/v3d/v3d_gem.c | 17 +++++++++++++----
> drivers/gpu/drm/v3d/v3d_perfmon.c | 6 +++++-
> 2 files changed, 18 insertions(+), 5 deletions(-)
>
prev parent reply other threads:[~2022-11-10 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 17:54 Maíra Canal
2022-11-08 17:54 ` [PATCH v2 1/2] drm/v3d: switch to drmm_mutex_init Maíra Canal
2022-11-08 17:54 ` [PATCH v2 2/2] drm/v3d: add missing mutex_destroy Maíra Canal
2022-11-10 12:59 ` Melissa Wen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=335b511f-ecfd-6e83-ef2e-7a74c8293b00@igalia.com \
--to=mwen@igalia.com \
--cc=airlied@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=jasuarez@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcanal@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®