From: Vladimir Zapolskiy <vz@mleia.com>
To: Charles Han <hanchunchao@inspur.com>,
vkoul@kernel.org, piotr.wojtaszczyk@timesys.com
Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: Add NULL check in lpc32xx_dmamux_reserve()
Date: Mon, 16 Jun 2025 18:26:00 +0300 [thread overview]
Message-ID: <335bf854-1a73-4370-93f4-77e9fd3febca@mleia.com> (raw)
In-Reply-To: <20250616104639.1935-1-hanchunchao@inspur.com>
Hi Charles,
On 6/16/25 13:46, Charles Han wrote:
> The function of_find_device_by_node() may return NULL if the device
> node cannot be found or if CONFIG_OF is not defined, dereferencing
please see my comments provided for lpc18xx-dmamux.c driver, all of
them are applicable here as well.
There is no problem to be fixed, the change also shall be dropped
in my opinion.
> it without NULL check may lead to NULL dereference.
> Add a check to verify whether the return value is NULL.
>
> Fixes: 5d318b595982 ("dmaengine: Add dma router for pl08x in LPC32XX SoC")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
--
Best wishes,
Vladimir
prev parent reply other threads:[~2025-06-16 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 10:46 Charles Han
2025-06-16 15:26 ` Vladimir Zapolskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=335bf854-1a73-4370-93f4-77e9fd3febca@mleia.com \
--to=vz@mleia.com \
--cc=dmaengine@vger.kernel.org \
--cc=hanchunchao@inspur.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®