Re: [PATCH v4 06/10] dt-bindings: clock: Add required "interconnect-cells" property

[Luo Jie <quic_luoj@quicinc.com>]

On 8/29/2025 3:37 PM, Krzysztof Kozlowski wrote:
> On Thu, Aug 28, 2025 at 06:32:19PM +0800, Luo Jie wrote:
>> ICC clocks are always provided by the NSS clock controller of IPQ9574,
>> so add interconnect-cells as required DT property.
> 
> Does not make sense. If clocks are always, you require different
> property?

The '#interconnect-cells' property is mandatory in the DTS so that the
client driver such as PPE driver can acquire the ICC clocks from the NSS
CC provider. This is already part of the IPQ9574 DTS which is merged. We
had missed adding it as 'Required' at that time and fixing it now.

I will update the commit message to describe this better in the next
version to avoid confusion.

> 
>>
>> Fixes: 28300ecedce4 ("dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions")
>> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
> 
> Fixes cannot be in the middle of patchset.
> 
> See submitting patches and your internal guideline explaining it with
> great details.
> 

I understand that fixes should not be placed in the middle of a
patchset. I will reorder the patches to ensure that all fixes are at the
beginning of the series.

>> ---
>>   Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
>> index 17252b6ea3be..fc604279114f 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
>> @@ -57,6 +57,7 @@ required:
>>     - compatible
>>     - clocks
>>     - clock-names
>> +  - '#interconnect-cells'
> 
> ABI break without explanation.
> 
> Best regards,
> Krzysztof
> 

This property is already present in the current IPQ9574 SoC DTS file
which is already merged, and hence no ABI break is introduced for
IPQ9574. I will update the commit message in the next version to clarify
this.