From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751450AbdISFvN (ORCPT ); Tue, 19 Sep 2017 01:51:13 -0400 Received: from mga04.intel.com ([192.55.52.120]:56124 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbdISFvK (ORCPT ); Tue, 19 Sep 2017 01:51:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,416,1500966000"; d="scan'208";a="136893529" Subject: Re: [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS To: Vijay Viswanath , ulf.hansson@linaro.org, will.deacon@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, asutoshd@codeaurora.org, stummala@codeaurora.org, riteshh@codeaurora.org, subhashj@codeaurora.org References: <1504097509-58983-1-git-send-email-vviswana@codeaurora.org> <1504097509-58983-6-git-send-email-vviswana@codeaurora.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <33605097-6881-50a3-4526-a2ac6448a60d@intel.com> Date: Tue, 19 Sep 2017 08:44:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/17 07:03, Vijay Viswanath wrote: > > > On 9/14/2017 12:04 PM, Adrian Hunter wrote: >> On 30/08/17 15:51, Vijay Viswanath wrote: >>> Enable CONFIG_MMC_SDHCI_IO_ACCESSORS so that SDHC controller specific >>> register read and write APIs, if registered, can be used. >> >> Missing signed-off >> >> Why don't you put this patch earlier in the patch set and then you don't >> need all the ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS ? >> > > This will involve merging the current patches 3 & 4 into one (Some functions > defined under ifdef in patch 3 are used only in patch 4). Will that be fine ? Sure > >>> --- >>> drivers/mmc/host/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >>> index 2db84dd..64a9298 100644 >>> --- a/drivers/mmc/host/Kconfig >>> +++ b/drivers/mmc/host/Kconfig >>> @@ -420,6 +420,7 @@ config MMC_SDHCI_MSM >>> tristate "Qualcomm SDHCI Controller Support" >>> depends on ARCH_QCOM || (ARM && COMPILE_TEST) >>> depends on MMC_SDHCI_PLTFM >>> + select CONFIG_MMC_SDHCI_IO_ACCESSORS >> >> CONFIG_MMC_SDHCI_IO_ACCESSORS -> MMC_SDHCI_IO_ACCESSORS >> >>> help >>> This selects the Secure Digital Host Controller Interface (SDHCI) >>> support present in Qualcomm SOCs. The controller supports >>> >> >