From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C7C2BCF45 for ; Tue, 28 Apr 2026 16:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777393611; cv=none; b=hxvBKiau44VbLOuQXqTUPF70pRZXN2AHWA3oSkw4O1sgGdzMuygPZWxL1swWn2IE8OCfVHuCYtZOweOnyU82oGNajI6zqqr+39xWGDfJgaHp7BrVbfr1pyk0GwBHxGMqJJk8D/mnfzlXyyvDGWf7tH4PexpVW3EuGMf4duS2yEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777393611; c=relaxed/simple; bh=YOxrYOW2XiUYIkrw5Ws4BEeoJlv7piRCf57Qrembd30=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Tnl0Olf5i3u50vWC9zsz3QV37RVuPLyPFYgXxi76M6GX1fMspD7SLrWHv44V0hl3AlZvQpnyuuZjNCWp37zKFrsT3bY0oPJ+gtiaAQ+4I2hJuIqJGyDHGmasUZSeDRCa6Gamk4rTf4fMmPRXMEh+BXmSNwcMnfpITBlO4CkPPcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JYh+wyVH; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jhXNmfsu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JYh+wyVH"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jhXNmfsu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777393609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xrFHh+IXnC+/GYwS6dyvxdLC3SMZIfTMFwt74S3Tudw=; b=JYh+wyVHyA0poGbEghbO0T6zKPF8c2X0vr+FdDH4QyGuIxJ/+XpJpaCpY5GCsAvS1WrGTz +PUEPo14MRz4lDKYhL2BEoBXJtATpsPsOo2whlE3k41XzOY5QbG5QgQaXjrHmuottkeD7r geNVfodFsy+a+3XoQqnjRQ/JRfXL7l8= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-AurLYmCNMwesY07jppz6Sg-1; Tue, 28 Apr 2026 12:26:48 -0400 X-MC-Unique: AurLYmCNMwesY07jppz6Sg-1 X-Mimecast-MFC-AGG-ID: AurLYmCNMwesY07jppz6Sg_1777393607 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8d5107ec672so2827882485a.0 for ; Tue, 28 Apr 2026 09:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777393607; x=1777998407; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=xrFHh+IXnC+/GYwS6dyvxdLC3SMZIfTMFwt74S3Tudw=; b=jhXNmfsu4bYUEMxedP+/sjOWgeAhKqxQaHh+vGoII/R0XuC8m9cAW6OX1AlolBvDUy TINF2YO2RVwGUCvexlMGpVJlwgFAU3cExGSl9NNLOS2l/BpsS4oDB4TkrixbybRXvSlY JLOI7lKoTPZZiTG4k4qrDbm3u/XlUtuWbxfHbIGk2R5edfVkRAWf8EGdsFHq3UtfnqyR rfIKjmMW4NPzJ7Qn6ziblpUarFjgl+zcnHbwmk1MRqTFvp2jVoWmYII0rXzSy56O2gYI byn5e6707b/UAwNti2+vsvAs9DkS84SzNVAEZ4CRk0K9wLP870G4TDMCDfvp/3YB35tD 689w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777393607; x=1777998407; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xrFHh+IXnC+/GYwS6dyvxdLC3SMZIfTMFwt74S3Tudw=; b=eSNOlBxshEOFDCVKsIxhNyqjIq88DJT1tz2jdN8wup0HM/bJXDsjL8Mqp8cQeeSe0c hrC5sXqS+eHgKwmSnpEclPVfgQm+fkmKdZ8653FI1gpAEaXrF+S1sZSVcL9LzQZXWcmL qbYjHjtZEdCKsAuhxMtqoo6XZVtNQ+sF/4JRcODY/ieYHJNGOnBp56ZP4nsOdnfOzgYR PZJ9GrsAf15wJaecxY9bzTapW+2GtGnl1udf7QTR18Qddu7z6xMoFO3WIIvdOnaNBiTv oB2IR/ryLrrrji+Aj4aIYNdi6l0syy4iZ9jyfuK+V8Eu7TwwLNj8lgEifMTHbDa4+Nmp hUBw== X-Forwarded-Encrypted: i=1; AFNElJ+5b9iywnRwV5bcKZybGiv4OG3RUlaDD2YRjptIfHTYbmRsUS4Um1udDFCt1a8U8gXxj4J9zoP8WHYZy0s=@vger.kernel.org X-Gm-Message-State: AOJu0YwpnATIckxQDDMPzpAtJAcaW+m016LshjEwsy+qOUEN224mg8If bqhDUFfeRx/SGz0wrS06dDfHYDe3iXUCvTHDH7oXNEe2sFDUT/QCzwwfs20jz/GgWzKNz32KnWi xzqUcK7zc283DnTSZko7bRCWWfuMffR8ojNx7cnOwdE+1lORZN1pXOtxDEsiOOf3Th0iNAqKm5T eO X-Gm-Gg: AeBDiesRs2nijEiNqfxTp8LCSLYG9zcSqhC42Oh6LzfkMPt1MqkJcn/26vz8Z6I35vm 3HwqHgppy4jCXslf5azf3ad9amtsonoaGwb51EET2qKEN3BHf2BBqj4bx/kZXvn2azrUeY1WcQY s6f3ZhqFLMri4jA+tnVhYGGiJQO8VJVYbquz3BTLQ1ikKYXkuRgNcx396kcc/4OGXi6GoGM18AO zFyxQAjsZbpWVROtkAvZ8gvIoplWbuZn7pFne961QKVJAxYDjZ8B0KvWsxu66Uzv3YJ927Q1lAR kyauNVTwqRXPLWeWPdToleSOslginTEigt2SqQLV9SfeztqutfmqJfyhZJ7nZGwdIxshY7Zg2QA IkOr+8iNFViRW/4D6Rsa1NTzTONY= X-Received: by 2002:a05:620a:17ac:b0:8eb:f3c7:2248 with SMTP id af79cd13be357-8f7d98fdd73mr490613185a.42.1777393607478; Tue, 28 Apr 2026 09:26:47 -0700 (PDT) X-Received: by 2002:a05:620a:17ac:b0:8eb:f3c7:2248 with SMTP id af79cd13be357-8f7d98fdd73mr490605285a.42.1777393606834; Tue, 28 Apr 2026 09:26:46 -0700 (PDT) Received: from m8.users.ipa.redhat.com ([2603:7000:9400:fe80::fc6]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8f7c7cd2c68sm233679985a.22.2026.04.28.09.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 09:26:45 -0700 (PDT) Message-ID: <33613b11328d830f8683fc6ec6900da2b479ae27.camel@redhat.com> Subject: Re: [PATCH net-next v2 0/5] Reimplement TCP-AO using crypto library From: Simo Sorce To: Eric Biggers , Dmitry Safonov <0x7f454c46@gmail.com> Cc: netdev@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Neal Cardwell , Kuniyuki Iwashima , "David S . Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Simon Horman , Ard Biesheuvel , "Jason A . Donenfeld" , Herbert Xu , Dmitry Safonov Date: Tue, 28 Apr 2026 12:26:44 -0400 In-Reply-To: <20260427232054.GA2700@sol> References: <20260427172727.9310-1-ebiggers@kernel.org> <20260427200116.GA3454259@google.com> <20260427232054.GA2700@sol> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-04-27 at 16:20 -0700, Eric Biggers wrote: > On Mon, Apr 27, 2026 at 08:01:16PM +0000, Eric Biggers wrote: > > > - Ronald P. Bonica (the original RFC5925 author), together with Tony > > > Li do have an active RFC draft to support the additional algorithms > [...] > > > [1] https://www.ietf.org/archive/id/draft-bonica-tcpm-tcp-ao-algs-00.= html >=20 > For what it's worth, that draft makes very little sense. For example, > it proposes three variants of HMAC-SHA3, instead of just making the > modern choice of KMAC256. And it proposes both HMAC-SHA384 and > HMAC-SHA512, despite them being redundant with each other after the > specified truncation to 128 bits. Which is bogus in itself without proper security considerations, the only considerations cited is an RFC from 1997 ... clearly the pinnacle of cryptography advice ... If they need a shorter hash they should make themselves a favor and use SHAKE and then define the desired output length and desired key size. That draft is just a disaster as written. Specifically they should use KMAC128 as defined in NIST SP 800-185 (which uses cSHAKE128 underneath). Simo. --=20 Simo Sorce Distinguished Engineer RHEL Crypto Team Red Hat, Inc