From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFFDCEB64DB for ; Thu, 15 Jun 2023 21:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232138AbjFOV03 (ORCPT ); Thu, 15 Jun 2023 17:26:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235017AbjFOV0W (ORCPT ); Thu, 15 Jun 2023 17:26:22 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD282D72 for ; Thu, 15 Jun 2023 14:26:17 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-977d55ac17bso358748366b.3 for ; Thu, 15 Jun 2023 14:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686864376; x=1689456376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aDc//YuFtaRzUGzoigOUfnlePn6bsnGkSi4GnqCGPOI=; b=Q+ndHP4r4HVJ3u8v3TCAG+frLji7WtcnSfr01vaPVut7K4QRzIGrbGmnTOXQIuDrHD s1gP6fhHNfMTFYb7Lc3Je8+9Lyfwq47ffhicQjABo2ukXCd7mvGowbv+eqt/leaduiTV JvpOlRtVhhQdl2Vh/YhrtVsLuDzFW4CJqoCADl9shRVm6hQuDLgIjTGBGHPYi4bIxdjz Chgs+zjH6d/Rog4rQwcEze+grM+3KtqPI4V3ubIeVdDqJdo3cSLL/Q7NGri6kTQGi58W 5w74gv8z/oVjAJHIzXFXwq7uUV48vzmwCQzSU2x6Yrb4ZHOdEkyY865bxmEWhJdxhls/ htKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686864376; x=1689456376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aDc//YuFtaRzUGzoigOUfnlePn6bsnGkSi4GnqCGPOI=; b=Kq1XBRC+rlZRyfkYWyfZZWBVNHZ8dK+JKAWJUBtpWWaPDR3+TnkLI4Kl02Tfj0yLul wZVwEw4jFUUZ35L8k2COshqs8Pwei/HjogR8jeHgWyAK+R/KBLKt1H4p0MXIv0Ulp5a5 P5RIEHUK6sSDl9bCk2eQb44rchrLJnKPPjVU7zkZ6MyFxOkO22kCLgBt0QQOONwKu3az C7+wbNSqZAnxJyLpuMASBfoOrBvqy18bSmsms5lkr9OxIry5GPQV9lCsFbhvt7Pj7oAD UlV3M44y9TLqiCDHKicJkNu3EsoLIoCR9500entOwxnAv0LN4mdnQMu/IwH2rqz8/msw BwsQ== X-Gm-Message-State: AC+VfDz2PNJAaUKNPuA/2lUi8Y3jJuvw82mVEDLZtCs4y6l4TS8kqiRZ PoDg2RaZqIA5rKJp3Kbv7/UGWg== X-Google-Smtp-Source: ACHHUZ7wayRGqgUZ8/2y8R0hUAIBjq0zVpTBo4zliveDHPzeqzsSY8uHKSZ1PQ4en2Koy8S8lgiS9A== X-Received: by 2002:a17:906:6a06:b0:94e:e97b:c65 with SMTP id qw6-20020a1709066a0600b0094ee97b0c65mr202766ejc.60.1686864375885; Thu, 15 Jun 2023 14:26:15 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id e10-20020a170906044a00b009845c187bdcsm244451eja.137.2023.06.15.14.26.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jun 2023 14:26:15 -0700 (PDT) Message-ID: <3364339a-908d-7ab6-7d62-a05ab8e67739@linaro.org> Date: Thu, 15 Jun 2023 23:26:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] soc: qcom: icc-bwmon: Don't ignore return values of regmap functions Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230615-topic-bwmonretval-v1-1-223bd048ebf7@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230615-topic-bwmonretval-v1-1-223bd048ebf7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/06/2023 23:12, Konrad Dybcio wrote: > As it turns out, not all regmap accesses succeed. Not knowing this is > particularly suboptimal when there's a breaking change to the regmap > APIs. Monitor the return values of regmap_ calls and propagate errors, > should any occur. > > To keep any level of readability in bwmon_enable(), add some comments > to separate the logical blocks. > > Signed-off-by: Konrad Dybcio Nice coincidence, I just had some talks with a friend about uselessness (IMHO) of regmap MMIO return status checks. Sorry, for me most of this makes the code difficult to read for no gain. Errors are not real. This is some artificial problem. Solving it makes code less maintainable. If we used here readl/writel, you would not add any checks, right? Then don't add for regmap mmio. Best regards, Krzysztof