From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C1B515B971 for ; Mon, 29 Dec 2025 03:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766980347; cv=none; b=j1YZKxHnyCVJnQBH0hK3VxDA+Pn31pTzoJbbK+S0GHdNOQynzCxoC+6CvufMqwKQGeiCoLhEQdZn0oEz/hCqMyJQJbrobh6HePttZ5O1MOPF40qbkMGy4W/91wLDabLSerCFzxTql6V3FQfuEO771V2voSgmtIUGvBovIV9l8D8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766980347; c=relaxed/simple; bh=AEEobN6ehvzz0Cfe2z7/oJNzJN7XNCd2aU514R20S9s=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=VZ1TNgm+1HZWozkDx0jcYRrAPifem4wmhyvbC3Fexv+AtKk3Eq1cSyhrCmyEUvmRAK4TfxhLLYz4k9WC0vpILo0WEs3O0keMvPSRTRAGmqIc91MCBRDM5z2E0MHKeU96dwqhVRxQn2Mx7GcFFPBPWN3rxqP3DCzXcC3MC0YrVEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YwQdzQ5t; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YwQdzQ5t" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2a1462573caso1328705ad.0 for ; Sun, 28 Dec 2025 19:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1766980345; x=1767585145; darn=vger.kernel.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=aB7g6CXDfW6HGExZB4E/LWQMKMOyqE5DaYwLo3Ciu3k=; b=YwQdzQ5tz6yizXDHFwmPHbGFIktZ+4cg5i7xs0Iedbd5nEujXMjRmTun9pfdqif5z5 iNyriFXwR6pPYuoxsvLCWvjNqBmrGgDk/t96pH+s/H8iIWKm5ObeDD4L6z0UPIDQCSx5 WpbLP/SknkmEfmJsLRhpKUfLI+iIPZE+6YileCgp9VJi/zJFd51qJSLEl8ZMQH4RWYBJ XggWX2yDNPKkmLcWSNHSQEc6Z98BkxnDb+Z8ABEqLmivhJvyENRjtV3yOYZMppXaQzmF uFDspl6oWLpU0l9jxS6AaAb0gFg3eCt1UqieUx/gjHebySqeLTXTHMSXqm77muOMScn6 1MJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766980345; x=1767585145; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aB7g6CXDfW6HGExZB4E/LWQMKMOyqE5DaYwLo3Ciu3k=; b=mdAzN3sfhxiXycFFzKR+pey5D/7IcD7gciTxI0W5q7uYcMnV6PMHz72KAK8b/y8ov7 BH8hOriePOLpqS+UA2LSsTSLEWqXFF0ym9BAScAXEf6DEb/KfHX8D77xBVXgzknO6imF yEpt17vDWa8PnTzxowF/fqumUBYYrOESLH43FonAZWqwmVEHLj6lZKBejviQgyYsUjRf gxuHmAbmptxr1gjAFgKb4dHBm8ZoHn4NOPhkPKRb/lNPQc+adsGjBq+T7Dir24KXgNT7 57vD86PRd/sxW0mNSKsqEZRRioaSVLzxM/Md59Gi1ce5fg7zyfv8Pl6XZ0Z1gX3gr9KQ qpNw== X-Forwarded-Encrypted: i=1; AJvYcCVC72VqNI6XGYpg/b1JUuJ5xtMvtKq0ViRkkYXfRFLznBkbxDrVA9lZ8Zvp9lU8/pjhfsXQ4OiHh/MQlTY=@vger.kernel.org X-Gm-Message-State: AOJu0YzNluCWdOAsnIS69LwaTn80q4y3ithSbRdj0yxSJW0Z03UlO+mf 0QxO9A4OhcIHpz69HZP+u0LnOrjBzcAJf4G/8+Li91o9Jk2gxugp9MbXdFprrIxknw== X-Gm-Gg: AY/fxX4Vv8nF1orGnzZlbe4bMMsNQNHYN1R5p7qw5O2LQacSBXZmvO6kn78DA8c9Wa/ uPpIRE/Hgueil1xTchdomNVUbjqjtz1Gc9dOoleNR5nxb1iiEH/JMoqZQhx/FFPwf/dwn5n544F KBLsTijoscWg14I7MfRx6EIvRRmoaUV+h4L+mH995wgrgdM4PwEF7MgFA+Kctr4oFTNnRisEWWb CU51lEGd23Ani7bDAaLkMdchf3iveExX900TXxG5rth8R9ywM7d7A4HlIu50dn2PZlh2c4sMw/2 JVopH1M9yskQE01wnxRH7Zs0Bk8gRpjXVeuTYDZIRrbYYvYQvQ4NLHC/Oj61AGOlCH+12382j5b AAyV134jjRLaB5a0/1ymvIyNCPIwIuGKF0PiEFWaa/p6YBOwJHaOacftEtAkpHQQzrSe1dnKSrd 8288eQZkC6rkt7f7Ammb9FNZLtEZyqvfbLPNN2lG4mLUB3fODBEXZhCxEvdyIqgPd75lbIpeh46 PEmmRuQ7fZugFM0cfhs4go6lxFd2huCMf34dUe5Yg== X-Google-Smtp-Source: AGHT+IGwDgm5TTH1m4KnMuqe8eyyJlsiZm+/PVOJRxv8qkQKTUcBfAhfY33eVNRJQEtmKMKYtaD8Ng== X-Received: by 2002:a17:902:f687:b0:2a3:2844:98cd with SMTP id d9443c01a7336-2a3522d4fabmr5359435ad.8.1766980344398; Sun, 28 Dec 2025 19:52:24 -0800 (PST) Received: from [2a00:79e0:2eb0:8:6aa2:ed72:3a50:d77e] ([2a00:79e0:2eb0:8:6aa2:ed72:3a50:d77e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d5d3e1sm255327115ad.76.2025.12.28.19.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 19:52:23 -0800 (PST) Date: Sun, 28 Dec 2025 19:52:23 -0800 (PST) From: David Rientjes To: Dipendra Khadka cc: Michal Hocko , Andrew Morton , Shakeel Butt , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/oom_kill: Remove unnecessary integer promotion in format string In-Reply-To: <20251228154456.2386-1-kdipendra88@gmail.com> Message-ID: <33688294-ac1a-cec8-527d-a6a010a6128d@google.com> References: <20251228154456.2386-1-kdipendra88@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sun, 28 Dec 2025, Dipendra Khadka wrote: > The 'h' length modifier in '%hd' is unnecessary as short integers are > promoted to int in variadic functions. Use '%d' instead. > > Signed-off-by: Dipendra Khadka I don't have a strong opinion given this will result in the same output. Acked-by: David Rientjes