From: Shuah Khan <skhan@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Alexander Egorenkov <egorenar@linux.ibm.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/ftrace: make kprobe profile testcase description unique
Date: Tue, 30 Nov 2021 09:39:23 -0700 [thread overview]
Message-ID: <33704769-6819-0db8-b005-c68d7b747aea@linuxfoundation.org> (raw)
In-Reply-To: <0fc3e982-456f-628d-17a3-f9c631108f6f@linuxfoundation.org>
On 11/30/21 9:21 AM, Shuah Khan wrote:
> On 11/30/21 9:01 AM, Steven Rostedt wrote:
>> On Tue, 30 Nov 2021 23:11:30 +0900
>> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>>
>>> On Tue, 30 Nov 2021 13:25:46 +0100
>>> Heiko Carstens <hca@linux.ibm.com> wrote:
>>>
>>>> Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
>>>> added a new kprobes testcase, but has a description which does not
>>>> describe what the test case is doing and is duplicating the desription
>
> Typo - I can fix it when I apply. checkpatch.pl does it for you btw.
>
>>>> of another test case.
>>>> Therefore change the test case description, so it is unique and then
>>>> allows easily to tell which test case actually passed or failed.
>>>
>>> Good catch!
>>>
>>> This looks good to me.
>>>
>>> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>>>
>>
>> Shuah,
>>
>> Care to take this through your tree?
>>
>
> Yes. I can queue this up.
>
Heiko,
Applied now to linux-kselftest next. Run get_maintainers.pl and include
linux-kselftest on your future patches.
thanks,
-- Shuah
prev parent reply other threads:[~2021-11-30 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 12:25 Heiko Carstens
2021-11-30 14:11 ` Masami Hiramatsu
2021-11-30 16:01 ` Steven Rostedt
2021-11-30 16:21 ` Shuah Khan
2021-11-30 16:39 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33704769-6819-0db8-b005-c68d7b747aea@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=egorenar@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®