mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Elder <elder@ieee.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
	~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Alex Elder <elder@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range
Date: Thu, 11 Nov 2021 15:25:23 -0600	[thread overview]
Message-ID: <337396cb-0959-561d-8abd-7cf6e48d6fae@ieee.org> (raw)
In-Reply-To: <20211111183724.593478-1-konrad.dybcio@somainline.org>

On 11/11/21 12:37 PM, Konrad Dybcio wrote:
> The source group count was mistakenly assigned to both dst and src loops.
> Fix it to make IPA probe and work again.

Looks good.  Oops.

Reviewed-by: Alex Elder <elder@linaro.org>

> 
> Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
> Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> Changes since v1:
> - Add a "Fixes:" tag, R-b, A-b and fix up the commit message
>   drivers/net/ipa/ipa_resource.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
> index e3da95d69409..06cec7199382 100644
> --- a/drivers/net/ipa/ipa_resource.c
> +++ b/drivers/net/ipa/ipa_resource.c
> @@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
>   				return false;
>   	}
>   
> -	group_count = data->rsrc_group_src_count;
> +	group_count = data->rsrc_group_dst_count;
>   	if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
>   		return false;
>   
> 


  reply	other threads:[~2021-11-11 21:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 18:37 Konrad Dybcio
2021-11-11 21:25 ` Alex Elder [this message]
2021-11-13  4:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=337396cb-0959-561d-8abd-7cf6e48d6fae@ieee.org \
    --to=elder@ieee.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=davem@davemloft.net \
    --cc=elder@kernel.org \
    --cc=jamipkettunen@somainline.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=netdev@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®