From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756474AbdCXIBg (ORCPT ); Fri, 24 Mar 2017 04:01:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49126 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753080AbdCXIAc (ORCPT ); Fri, 24 Mar 2017 04:00:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1A766C05AA48 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1A766C05AA48 Subject: Re: [PATCH v3] extcon: intel-cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver To: Chanwoo Choi , MyungJoo Ham References: <20170323160142.15266-1-hdegoede@redhat.com> <58D4A2AB.6030904@samsung.com> Cc: Takashi Iwai , linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: <33739dc4-c73c-41b5-478a-6a16432c95eb@redhat.com> Date: Fri, 24 Mar 2017 08:59:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <58D4A2AB.6030904@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 24 Mar 2017 07:59:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 24-03-17 05:38, Chanwoo Choi wrote: > Hi, > > On 2017년 03월 24일 01:01, Hans de Goede wrote: >> Add a driver for charger detection / control on the Intel Cherrytrail >> Whiskey Cove PMIC. >> >> Signed-off-by: Hans de Goede >> --- >> Changes in v2: >> -Improve wait for charger detection loop, use jiffies to get an accurate timeout >> -Sort registers by address, remove duplicate definition >> -Return IRQ_NONE on interrupt handling errors >> -Various small style cleanups >> -Fix reporting no charger cable being present when detecting the same >> charger type 2 times in a row >> -Reset to autonomous / hw-mode on probe-error and on remove >> Changes in v3: >> -Add intel prefix to Kconfig symbol and filename >> -Clarified "Unhandled charger type" warning msg >> -Dropped usb_id sysfs attribute >> --- >> drivers/extcon/Kconfig | 7 + >> drivers/extcon/Makefile | 1 + >> drivers/extcon/extcon-intel-cht-wc.c | 352 +++++++++++++++++++++++++++++++++++ >> 3 files changed, 360 insertions(+) >> create mode 100644 drivers/extcon/extcon-intel-cht-wc.c >> > > Applied it on extcon-next branch. Thank you. Regards, Hans > > [snip] > >> + usbsrc = (usbsrc & CHT_WC_USBSRC_TYPE_MASK) >> CHT_WC_USBSRC_TYPE_SHIFT; >> + switch (usbsrc) { >> + default: >> + dev_warn(ext->dev, "Unhandled charger type %d, defaulting to SDP\n", > > Nit: > This line is over length 80. So, I changed it as following > > dev_warn(ext->dev, > "Unhandled charger type %d, defaulting to SDP\n", > >> + ret); >> + /* Fall through, treat as SDP */ >> + case CHT_WC_USBSRC_TYPE_SDP: >> + case CHT_WC_USBSRC_TYPE_FLOAT_DP_DN: >> + case CHT_WC_USBSRC_TYPE_OTHER: >> + return EXTCON_CHG_USB_SDP; >> + case CHT_WC_USBSRC_TYPE_CDP: >> + return EXTCON_CHG_USB_CDP; >> + case CHT_WC_USBSRC_TYPE_DCP: >> + case CHT_WC_USBSRC_TYPE_DCP_EXTPHY: >> + case CHT_WC_USBSRC_TYPE_MHL: /* MHL2+ delivers upto 2A, treat as DCP */ >> + return EXTCON_CHG_USB_DCP; >> + case CHT_WC_USBSRC_TYPE_ACA: >> + return EXTCON_CHG_USB_ACA; >> + } >> +} >