From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90BF5C6778C for ; Tue, 3 Jul 2018 14:28:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 487D523D37 for ; Tue, 3 Jul 2018 14:28:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 487D523D37 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932353AbeGCO2H (ORCPT ); Tue, 3 Jul 2018 10:28:07 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:64611 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932133AbeGCO2F (ORCPT ); Tue, 3 Jul 2018 10:28:05 -0400 Received: from 79.184.254.38.ipv4.supernova.orange.pl (79.184.254.38) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83) id 7e9b108ac1e7119a; Tue, 3 Jul 2018 16:28:04 +0200 From: "Rafael J. Wysocki" To: Pingfan Liu , Grygorii Strashko Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Christoph Hellwig , Bjorn Helgaas , Dave Young , linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCHv3 3/4] drivers/base: clean up the usage of devices_kset_move_last() Date: Tue, 03 Jul 2018 16:26:40 +0200 Message-ID: <3375966.ydPZj5TMVj@aspire.rjw.lan> In-Reply-To: <1530600642-25090-4-git-send-email-kernelfans@gmail.com> References: <1530600642-25090-1-git-send-email-kernelfans@gmail.com> <1530600642-25090-4-git-send-email-kernelfans@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 3, 2018 8:50:41 AM CEST Pingfan Liu wrote: > Clean up the referring to the code in commit 52cdbdd49853 ("driver core: > correct device's shutdown order"). So later we can revert it safely. > > Cc: Greg Kroah-Hartman > Cc: Rafael J. Wysocki > Cc: Grygorii Strashko > Cc: Christoph Hellwig > Cc: Bjorn Helgaas > Cc: Dave Young > Cc: linux-pci@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Pingfan Liu > --- > drivers/base/core.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 684b994..db3deb8 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -127,13 +127,6 @@ static int device_reorder_to_tail(struct device *dev, void *not_used) > { > struct device_link *link; > > - /* > - * Devices that have not been registered yet will be put to the ends > - * of the lists during the registration, so skip them here. > - */ > - if (device_is_registered(dev)) > - devices_kset_move_last(dev); > - > if (device_pm_initialized(dev)) > device_pm_move_last(dev); You can't do this. If you do it, that will break power management in some situations. Thanks, Rafael