From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56B80376BCC for ; Thu, 19 Mar 2026 09:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773913962; cv=none; b=RolMFua/QEpxNfg5C0dAnPg4TyqGQjzaNdsTAX1UsBy0M+HSWePdalYmKuwGEPR9VNsp477MbTl9tEjYamdVQ8eI+3zZPrUabIQIle3VPUHMAVSVviBCvk9HwS6HBLIs9umpO8GUpe/ujX2zu/PFgRvsDkvYOZcRMMhGxBg1YAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773913962; c=relaxed/simple; bh=7uA/BCBTVJ94Aaj2XviPEUjuMABWk6OC0mXxBgWG+pI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HxVd6Q2xRtPojyy6aeEzCKwak3zQFw9DdZ3i+Un+fprbelb+VxRbMMyBfal8b6A3MSTQv8MLMooETEzmfUOank3Uvg9mIzFdtpDy6l53Og29o4cBO4eHZb4Na9NlGlO+EPD6otdncocmBX776eoAhtvQl8PjVP1N2nPaticFSHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=c6EwL7pa; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AX+Aai+K; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c6EwL7pa"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AX+Aai+K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773913960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AWVI4IPyZgF76R5k9iVZditqSOUJj0IJ9hCQO83Ez8E=; b=c6EwL7pajDifaS7mnFuMEwpU//SNIJ27TwjlxFebJUcBI3bQGwRCgpQSatD4zvecvzgVH5 Z3OSd/rjpDcy7MHxvfgC5um0SvLAfcjb6XU1fcQi9pCI1TbGYA6WUqDz0vxwGAnf1UcGoB ckUoipLYrGjbC5nRc0sKgqaTji0pJOw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-M3h2i5n-N52PTztfglE_Ow-1; Thu, 19 Mar 2026 05:52:38 -0400 X-MC-Unique: M3h2i5n-N52PTztfglE_Ow-1 X-Mimecast-MFC-AGG-ID: M3h2i5n-N52PTztfglE_Ow_1773913957 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-485397788b3so3863435e9.2 for ; Thu, 19 Mar 2026 02:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773913957; x=1774518757; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AWVI4IPyZgF76R5k9iVZditqSOUJj0IJ9hCQO83Ez8E=; b=AX+Aai+KHde3OWrOPVpjQ80Oyqz9znVUhHcfl/2YRBURf86ijtcTDZPwDK9oI+jFY/ UFN4zLr2bNCTiLXybEDzJRMFMwb4FItizO5dUzmW2h8VoohB5wldInBNqkPBLZn+xXK5 Rnkdjs1WchAvzVaATC41djQaHL07v33xlmAFgnRz5PKs+Z1UkokvChpcNoghYtGbxdvR dEQWAmhTAa3w4klVBDhnzVS3NmxPwco0ILFlNEO4WpdJsh24HBg59VVpJlxSnF7BucBr 29FhFXS1XA9+BlEf7u9lYW0H4hcnc72gi/jUn+NWWhEMug8dhZohMHaZxw14bxbhfdCw miEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773913957; x=1774518757; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AWVI4IPyZgF76R5k9iVZditqSOUJj0IJ9hCQO83Ez8E=; b=Uf5jfrItijwSPupZg5TvzJ4aisX05ravU6foenkQ8oaazq1uctmMvHmFUmJNggx32w GVj43j553wBLLbVoSYA4ICyvgmqK1y0qlfuEOqNEGHGJ9Z6Jc8bdVvJ5yqrYlfDxqeDS 3m+qj+uT03HuSY2yGKtWP0/aybG1o2I5La4Ss17zIiG2OLek0B4rjbVBW7FESa3CrveH Luwlf2kWM/nWiHZ9DyT23G64zC4OnONxowuXzNNFbTFpBqSYftdVHkHb7Fln7CGtFkij ZDAAX3H/0frlLS2OOF82efPJaQ0DZ35U09q1W0gXhVt3zV1XHwszlrKXGpA5Yt5zoWF4 4XtA== X-Forwarded-Encrypted: i=1; AJvYcCWm0vi8tYjG60gjj56cv/gRMLG8acsAFOqglQE3qUV2nfm/H2gzzWgdta+TFhk0qpiLvaqKmYOCyu3vb+U=@vger.kernel.org X-Gm-Message-State: AOJu0YyNGqF4JnmTggr25p/Ot/DBrTdaj4Qk+rTNKG4NirZ+q5G0qqBn UbfvSp7h/mfIUOlBBwQQy1NcRmwXNVxX1Sx2VDVhQTbXrQn109YTQLvHh3IUr2aO2+FTS3mdfyt s3KzLZv1Po3n1ZNgQrRGxvKgDsd9jdeGw/giUUDm9b1m4J2JPekB7wOUHXqH82Pw+8w== X-Gm-Gg: ATEYQzz8iK+mrxch08JT5p2d8FdN/a8g4Pyq/g11kHuOR7KHPfPgGI//cL1iLzTG9Jr xENtGEXyQTfmau209hBJsgNQ5hA/LG1W1NFXguneY/o9bQIFgypqGqb00MvV/K7NuqqSwSDAPkW 6q8UA8o9KOB9MErRD75X7eaEX6+2nPb4de5moMRgWkcim5wZ5isGyJmnXUbiNMOKtIkeeGZLazm klTWJOkNmkiOcvA54WmHLyEjxcF/UYTodYoVcLX4PNybWwgcRq9fZxqVaoEc1byaNiG9/VzpcyE QHqIBKcsnwGwGzpWnbAiAuvpvGCTUtgwhIkXXHLoN5H9K7f2xEpttW5huoO68P9e+T3qIOjBDOr J7TdJkXMYZo3LMrlqhx1y9gOjyVtauwHGF2vP0p0KAF/0uKisgJYPpGoq X-Received: by 2002:a05:600c:4e46:b0:485:3c8f:e4c5 with SMTP id 5b1f17b1804b1-486f44485b3mr101908095e9.17.1773913957185; Thu, 19 Mar 2026 02:52:37 -0700 (PDT) X-Received: by 2002:a05:600c:4e46:b0:485:3c8f:e4c5 with SMTP id 5b1f17b1804b1-486f44485b3mr101907615e9.17.1773913956651; Thu, 19 Mar 2026 02:52:36 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.196]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f4e48ad5sm170628175e9.1.2026.03.19.02.52.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 02:52:36 -0700 (PDT) Message-ID: <337a938c-8a03-43f8-8402-745020185b37@redhat.com> Date: Thu, 19 Mar 2026 10:52:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 0/5] net: centralize master device offload feature computation To: Hangbin Liu , Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jiri Pirko , Nikolay Aleksandrov , Ido Schimmel , Simon Horman , Sabrina Dubroca , Sridhar Samudrala Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux.dev References: <20260316-offload_compute-v3-0-a5d4a07d86d3@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260316-offload_compute-v3-0-a5d4a07d86d3@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/16/26 5:26 AM, Hangbin Liu wrote: > Currently, master devices (bonding, bridge, team) manually call > netdev_compute_master_upper_features() scattered throughout their port > add/remove operations. This approach requires each driver to remember > to update features at the right times and leads to code duplication. > > The series adds a new ndo_update_offloads callback that is automatically > invoked during feature updates when upper/lower device relationships change. > This centralizes the feature computation flow and removes the burden > from individual drivers. I'm sorry for the late feedback, but I think the driver cleanup and simplification is not worthy the core complexity and the new NDO added. The AI reported issue would probably need very non trivial changes to both team and bond driver to be addressed. Most of the cleanups belong to netdev_compute_master_upper_features() introduction in the failover driver. Factoring out that single change would be IMHO a better option, if possible. The new ndo looks controversial. We already have 2 different ndo at __netdev_update_features() time, with slightly different semantic. Adding another one feels like a design issue. /P