From: Valdis.Kletnieks@vt.edu
To: Andrew Morton <akpm@linux-foundation.org>, mchehab@infradead.org
Cc: linux-kernel@vger.kernel.org, video4linux-list@redhat.com
Subject: 2.6.28-mmotm1230 - include/media/v4l2-ioctl.h prototype mismatch
Date: Fri, 02 Jan 2009 05:51:26 -0500 [thread overview]
Message-ID: <33812.1230893486@turing-police.cc.vt.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]
I'm seeing the following warning message during a kernel build:
CC [M] drivers/media/video/gspca/gspca.o
drivers/media/video/gspca/gspca.c:1811: warning: initialization from incompatible pointer type
The root cause appears to be a missed prototype change in a conversion from
ioctl to unlocked_ioctl - in struct file_operations, the former is an int,
but the latter is a long. So we clean it up.
I have to admit not having checked deeply for second-order effects, but the
kernel builds without warnings and the result works for me. The only other
use of __video_ioctl2 I can see is in drivers/media/video/ivtv/ivtv-ioctl.c,
and there it's used as a return value from a function already defined to return
a long, so we save an int->long cast...
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
--- linux-2.6.28-mmotm1230/include/media/v4l2-ioctl.h.dist 2009-01-01 17:23:00.000000000 -0500
+++ linux-2.6.28-mmotm1230/include/media/v4l2-ioctl.h 2009-01-02 05:40:45.000000000 -0500
@@ -297,7 +297,7 @@ extern int video_usercopy(struct file *f
/* Standard handlers for V4L ioctl's */
/* This prototype is used on fops.unlocked_ioctl */
-extern int __video_ioctl2(struct file *file,
+extern long __video_ioctl2(struct file *file,
unsigned int cmd, unsigned long arg);
/* This prototype is used on fops.ioctl
--- linux-2.6.28-mmotm1230/drivers/media/video/v4l2-ioctl.c.dist 2009-01-01 17:22:50.000000000 -0500
+++ linux-2.6.28-mmotm1230/drivers/media/video/v4l2-ioctl.c 2009-01-02 05:45:39.000000000 -0500
@@ -1852,7 +1852,7 @@ static int __video_do_ioctl(struct file
return ret;
}
-int __video_ioctl2(struct file *file,
+long __video_ioctl2(struct file *file,
unsigned int cmd, unsigned long arg)
{
char sbuf[128];
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next reply other threads:[~2009-01-02 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 10:51 Valdis.Kletnieks [this message]
2009-01-05 7:20 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33812.1230893486@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®