mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [Bug 531] New: cdrom ioctl CDROM_SEND_PACKET broken
Date: Wed, 02 Apr 2003 08:50:07 -0800	[thread overview]
Message-ID: <33830000.1049302207@[10.10.2.4]> (raw)


http://bugme.osdl.org/show_bug.cgi?id=531

           Summary: cdrom ioctl CDROM_SEND_PACKET broken
    Kernel Version: 2.5.66+
            Status: NEW
          Severity: normal
             Owner: bugme-janitors@lists.osdl.org
         Submitter: pee@erkkila.org


Distribution: gentoo/other
Hardware Environment: amd/asus p4/intel
Software Environment:
Problem Description:

  I think i've located the problem with doing generic commands
to atapi drives.

mmc_ioctl calls cdrom_do_cmd with it's own copy of cgc made
from IOCTL_IN

cdrom_do_cmd then does it's thing, and copies back into
the cgc from mmc_ioctl. And then returns, however mmc_ioctl
is returning immediatly w/o updating the user passed in cgc.

The pointers to return to user space never get updated, so if you
set all 1's in a cgc->buffer and send it in you will get all 1's back
as that buffer is not updated correctly. nor is the sense data.

It looks like the copy_to_user needs to move to mmc_ioctl, or mmc_ioctl
needs to update the user cgc correctly.


Steps to reproduce:

Run a small program that calls CDROM_SEND_PACKET, i'll attach one



                 reply	other threads:[~2003-04-02 16:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='33830000.1049302207@[10.10.2.4]' \
    --to=mbligh@aracnet.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®