mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liangyan <liangyan.peng@bytedance.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Yicong Shen <shenyicong.1023@bytedance.com>,
	ziqianlu@bytedance.com, songmuchun@bytedance.com,
	yuanzhu@bytedance.com
Subject: Re: [External] Re: [RFC] genirq: Fix lockup in handle_edge_irq
Date: Tue, 8 Jul 2025 09:43:06 +0800	[thread overview]
Message-ID: <33834852-af8f-451d-9a39-8787330c2694@google.com> (raw)
In-Reply-To: <87o6u0rpaa.ffs@tglx>



On 2025/7/4 22:42, Thomas Gleixner wrote:
> 
> So playing games with the unmask is not really feasible. But let's take
> a step back and look at the actual problem.
> 
> It only happens when the interrupt affinity is moved or the interrupt
> has multiple target CPUs enabled in the effective affinity mask. x86 and
> arm64 enforce the effective affinity to be a single CPU, so on those
> architectures the problem only arises when the interrupt affinity
> changes.
> 
> Now we can use that fact and check whether the CPU, which observes
> INPROGRESS, is the target CPU in the effective affinity mask. If so,
> then the obvious cure is to busy poll the INPROGRESS flag instead of
> doing the mask()/PENDING/unmask() dance.
> 
> Something like the uncompiled and therefore untested patch below should
> do the trick. If you find bugs in it, you can keep and fix them :)
> 
Hello Thomas,

After over a day of testing the patch, the softlockup issue has not
recurred. This confirms that your patch should fix the problem. Thanks.
Would you consider upstreaming this patch?

Regards,
Liangyan

      parent reply	other threads:[~2025-07-08  1:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-01 16:35 Liangyan
2025-07-02 13:17 ` Thomas Gleixner
2025-07-03 15:31   ` [External] " Liangyan
2025-07-04 14:42     ` Thomas Gleixner
2025-07-04 15:36       ` Liangyan
2025-07-08  1:43       ` Liangyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33834852-af8f-451d-9a39-8787330c2694@google.com \
    --to=liangyan.peng@bytedance.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shenyicong.1023@bytedance.com \
    --cc=songmuchun@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=yuanzhu@bytedance.com \
    --cc=ziqianlu@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®