From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20BB639D6D5 for ; Thu, 18 Jun 2026 09:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781774800; cv=none; b=gT57fvgwlgw4+pmGNg4idtnj1R+1re4IEKoWwEtJJyfUjToGYLY4A5QY9cREPwHEBug4QBj437oqIzJeES9urbLC1FWpTVo+S8yXID1zzmsbMxWIv5DQFYKB89PhUTKPeJ3Fw/gwOsU7i0ole6caPVCLaWYtNmaFu5hTRsxLjSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781774800; c=relaxed/simple; bh=PQFzKq4u1Zz/DS7sc8HllALi6A+WiTA8yxPA4PvNbK4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N1dZdv3N/1aRt+LZ6282tSfBMgwhU9GHCmxBwMUDU0HTWrRkuXjJSDxod1DAQSVbzpJIHC/nbphzAT2ikvKjq9+RkgGa+Q986U6URCvxdWR0R7ymlQ1VTbBADioRp0TiCfUzbM/u1mz3UKbJg9rC2n3waBH2Jxe0ugvhxCWwTto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iaLU2eiK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Bpp+yuc2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iaLU2eiK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Bpp+yuc2" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65I8G1ua1157426 for ; Thu, 18 Jun 2026 09:26:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ce3Ew1kgGBzVv6bcwdm6x/HblgO4rzUZSXd+QkZ2/04=; b=iaLU2eiKyGioQKfF /1fGySA5k47KEhF5b7rmC+ewjIjlpA8gHmg1f2K1rynLSajU8h3loDZFIzXimb7U 5Td/y5PXvhBxvY7hi0F0W7TOoNeJsCTT3O8mfhL8d7pLvup+prt1hIiqJcn6cUmY OU17XVNl3Uevnom7ONAipUD/sFYQTqDwTrJI8K2SSViWZqze7un2V+JaK1/E18Ef JKwKRR5OVCcSvbUX8UkMQq7IGCWNAX8d3xtojTjKDlgouxO6hmsQ7F9yFHb04HJt fN+1MT/OC5Nt/WWguR4EMqsV8IqhFPFc3zk9Jmzp4XRq0yJ1UuCau4T8T/GDxd16 ER0Jzg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ev19a2rbk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 09:26:37 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-915976b2dffso15148485a.3 for ; Thu, 18 Jun 2026 02:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781774797; x=1782379597; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ce3Ew1kgGBzVv6bcwdm6x/HblgO4rzUZSXd+QkZ2/04=; b=Bpp+yuc2CVZYKrVbyXR8w1vgB/NtC+URg00vc+C4YDcl02RIGYnO/9e8eFafhxKoFP 8ARkK9zLtGU1zkeqEICgJZ29isUBaDFcwJTmnpjNbIeJbragPx3lBxDAQtZc5Tos80aW qVgjN4veevfn/MPCk+y4US8VN/BKdDjAufJNP1QiVvW4uhJbcfS9+vJkCWiW2M8A7AnB WOLyf92AaLPHbPhgo1KnCfDSmaS2BmzpPLnR4YTaN0Qum9FyZwed8oRBloLLrfjKAopL zLGPD4DxwOOczpp5BJDKWXV/PwCR/tU17VddlsGb7mNHGLjCjVxwMuV9srtRYUWQ01+n 7C4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781774797; x=1782379597; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ce3Ew1kgGBzVv6bcwdm6x/HblgO4rzUZSXd+QkZ2/04=; b=CogPvnOoZf6yxu1T3jT7Eu1+7bWnRisIbJLru81jwjUKUS6lxijTVRkxT0knVPp1kx g6Uj5C0/EH+hvP0n5PnhzsJoaUXyQtuN1jcr0BGA0yo7uxEXcv0SiPAEYsUYt4cr9WUc M9RbpPZHX6SO5ThAdHRs1HCO4hWUDu5S3if/Memkzdf4tI61EoaMgoXESJsgLqbIKDLy ToV/1q7nZMtrsF/Nywb2NxhVtJzWM8Vt5DI0gMDwplXs24hUZ6hMBX21oTmZZmTV7VHz Hfegv3PUmo83TiSzrBL22fnY0HvAc3df5zfCzltSbNxDAc6cAkFDNm8DDQFSnxRg65cw bRow== X-Forwarded-Encrypted: i=1; AFNElJ/5UX4av4QMcqn9jEGMx9Rl7osARFJDIrA/njkd+fja+eDjRkrTXBVN33tpT6ToQGnidIjolCIEsOyxCI8=@vger.kernel.org X-Gm-Message-State: AOJu0YxUW2aHDI5UylJ8O4MkNs8aiKQR4++B4R7ZqtTcg5JVfRPYHixg kKRKj174r3kIVmm4j53EXWqNqaY+zRbQcv3GssEA8VcncaU24R4HEfgjQ0eebwabXX+zt+8WyKb mERLGYh4HxET6f35O7tN1NC4SP5YcYxYfAXTvS8u1cexSI6c5nzySXIjkm813U7P6abg= X-Gm-Gg: Acq92OE36HIZifeCQBA9V7+564p5rdvJS5vzKrXADZ0mPJ03iAE0EgbXHDosL0+nkGK I6RGj28PSuGXOwuqy9D/qgmrJWkMVqjJvD/L3s/aGA9LPqBHUZKpUx03PfeX/oDfpNJAqXVInnA c+pDraU1gGSMWSSSTk2mjzFWx+noknKNgHbfCs/qbBE+nsMxBZExQ2EIlK6ZMC8ScMmBrJxKwo6 wjmWXt5VgVuhH+dgeMdtS72hO5GSYtHc3/yOStPUXsHtaAJiQr6GT8uUjRtdgU2gLz5qkPJ/veG W8bmGMkEzCA5vUBmwsM7Z68rwVmXqdI/KvItbBNOrKOGsYdAEMfRNWg4fji6eE/qPWWNTC60cAM dMQ4kF5nBGB1ssW15+Z7AeQMbBAjr86325m8= X-Received: by 2002:a05:620a:458a:b0:90d:11b2:80f3 with SMTP id af79cd13be357-91f2b477d71mr290816885a.7.1781774797383; Thu, 18 Jun 2026 02:26:37 -0700 (PDT) X-Received: by 2002:a05:620a:458a:b0:90d:11b2:80f3 with SMTP id af79cd13be357-91f2b477d71mr290814085a.7.1781774796807; Thu, 18 Jun 2026 02:26:36 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb83428a8sm925516266b.44.2026.06.18.02.26.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 02:26:35 -0700 (PDT) Message-ID: <3384ecdf-599f-4862-a3c4-9f54b4ddfe63@oss.qualcomm.com> Date: Thu, 18 Jun 2026 11:26:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU To: Bibek Kumar Patro , Dmitry Baryshkov Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com> <20260526-smmu_interconnect_addition-v2-3-2a6d8ca30d63@oss.qualcomm.com> <26d51cbb-2d87-4564-b3c6-cc61ab900e19@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <26d51cbb-2d87-4564-b3c6-cc61ab900e19@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=YbmNIQRf c=1 sm=1 tr=0 ts=6a33b9ce cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=HaZQysj9wVKA4b69cM0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDA4NiBTYWx0ZWRfX2414FgzwDc06 ElFjl7oo+hw5KSjefmOL6XyqKVYt6wAXpbSodZgR9ibUMwRpP89PukIQe1EvAyjkiMuSfHkgJcR /VfhlQIKMOcBSkQgBJNvWSOUB7YhuWI= X-Proofpoint-GUID: 6MvCzZrBUz_SRa2BB2tEoQMhN2xXDKKW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDA4NiBTYWx0ZWRfX3lYtKqD8Y54I 4ydKHNH2LPV6y5Uvc3q6ATtXuTD+u7pCjJX7N+GaxMdXm9BwXd9c6PEna4f7wuspqvPTsaLNPr2 AyMakV43Wz7U9ZFUDDgjMUyNsoJo279Xa32Nomvg534XVA66OeoeVm1+Gbxxxkc5AFF0DH8sJGm kapiWAKCjJYBEzqmgIv8n87NNO7weQj9R6KQXqPBLe08wEQNX1rassApzMXR+g11IiRdedVIAek PjuUpcPYUFPG9B4uWuCCELCz5pq6LUidhWdL6LGaj4r86V6zKwWDO3hV3T/hLa50CLePrmY+Ewv ne12rY+GjVtu4rOUHFD+4cuBUrNtrkTVuih9b+b4cs5Yo2Ae6sijnlSYm5lMmjxOOcKyc/Ps8t4 fAntHu2bFmf2CFYxs7PvtYTJxeQgQX4nxPfjMQxWWracTUo64AeDVR1OBMncYiETN2CMyS9h+5o InnHkqPGlKl9bqXlJGw== X-Proofpoint-ORIG-GUID: 6MvCzZrBUz_SRa2BB2tEoQMhN2xXDKKW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180086 On 6/8/26 4:37 PM, Bibek Kumar Patro wrote: > > > On 6/8/2026 7:27 PM, Dmitry Baryshkov wrote: >> On Tue, May 26, 2026 at 08:12:04PM +0530, Bibek Kumar Patro wrote: >>> On Kodiak platforms, the Adreno SMMU requires a bandwidth vote on >>> the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers >>> are accessible. Without this vote, the SMMU may become unreachable, >>> leading to intermittent probe failures and runtime issues. >>> >>> Add the required interconnect to ensure reliable register access. >> >> Does it only concern the GPU SMMU? What about the APPS SMMU? Should it >> be voting on other interconnects too? I guess so, because currently I >> see that TBUs vote for various interconnects. BTW: should apps_smmu also >> vote on the power domains? >> > > This race mainly occurs in GPU SMMU, where the GDSC can have an Mainly or exclusively? Konrad > independent vote on the Adreno SMMU. However, the GEM_NOC vote may > already have been removed by the GPU (or any consumer of adreno_smmu, > e.g gmu), unless it is explicitly voted by the GPU SMMU (which acts as a > supplier for the GPU). This mismatch can lead to SHUB timeouts or NoC > errors. > > Mostly this race reported in suspend/resume cycle (when gpu/gmu devices moves to slumber/suspend state before adreno_smmu powers down > and the later doesn't have explicit interconnect voting). > > In the case of APPS SMMU, such a race is not expected for any known > use case. APPS SMMU is part of a shared infrastructure block, and its > power is typically kept enabled as long as attached master devices are > active. Therefore, explicit power-domain voting from APPS SMMU may not > be required. > > Thanks, > Bibek > > >>> >>> Signed-off-by: Bibek Kumar Patro >>> --- >>>   arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 ++ >>>   1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>> index fa540d8c2615dc02d941eb16bc7253204c2750bd..eefa4b836a81374ff437ab4bbcbc3fecc1590ab6 100644 >>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>> @@ -3386,6 +3386,8 @@ adreno_smmu: iommu@3da0000 { >>>                 power-domains = <&gpucc GPU_CC_CX_GDSC>; >>>               dma-coherent; >>> +            interconnects = <&gem_noc MASTER_GPU_TCU QCOM_ICC_TAG_ALWAYS >>> +                     &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; >>>           }; >>>             gfx_0_tbu: tbu@3dd9000 { >>> >>> --  >>> 2.34.1 >>> >> > >