From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754439AbdEQMja (ORCPT ); Wed, 17 May 2017 08:39:30 -0400 Received: from mail.ginzinger.com ([31.193.165.229]:38415 "EHLO mail.ginzinger.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754395AbdEQMj1 (ORCPT ); Wed, 17 May 2017 08:39:27 -0400 Subject: Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter To: Rob Herring , References: <1493737259-26210-1-git-send-email-martin.kepplinger@ginzinger.com> <20170508161146.vkmaohiesjd6e6vq@rob-hp-laptop> <2a2d6377-1d3c-8639-0f28-d9519965296c@ginzinger.com> CC: , , , , , , , Schoefegger Stefan , Manfred Schlaegl From: Martin Kepplinger X-Enigmail-Draft-Status: N1110 Message-ID: <33877b30-e903-c0ce-37d7-ec344a03da58@ginzinger.com> Date: Wed, 17 May 2017 14:39:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2a2d6377-1d3c-8639-0f28-d9519965296c@ginzinger.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.1.120] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-11 10:32, Martin Kepplinger wrote: > On 2017-05-08 18:11, Rob Herring wrote: >> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote: >>> The datasheet and application note does not mention an allowed range for >>> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set >>> lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with >>> T5x06 touch. >>> >>> So, lacking a known lower limit, we increase the range for thresholds, >>> and set the lower limit to 0. The documentation is updated accordingly. >>> >>> Signed-off-by: Schoefegger Stefan >>> Signed-off-by: Manfred Schlaegl >>> Signed-off-by: Martin Kepplinger >>> --- >>> Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +- >>> Documentation/input/devices/edt-ft5x06.rst | 2 +- >>> drivers/input/touchscreen/edt-ft5x06.c | 2 +- >>> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> Acked-by: Rob Herring >> > > Dmitry, any objections or thoughts? Hey Dmitry, this still applies to today's -next and wouldn't take too long for you to review :) thanks martin