From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614B8C00140 for ; Fri, 12 Aug 2022 08:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234931AbiHLIab (ORCPT ); Fri, 12 Aug 2022 04:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiHLIa2 (ORCPT ); Fri, 12 Aug 2022 04:30:28 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E370810560 for ; Fri, 12 Aug 2022 01:30:26 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id w15so283365ljw.1 for ; Fri, 12 Aug 2022 01:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=DiGq++8L+onGlbzyqSifDwiKR7o1FzZbcbbtnv3rVuA=; b=SH+X5cbxpgc5TySGkww8khFDFEUxB5zO7WG2WO3wclK6Xr37YjEMpFPR6kM/Rh28za RC9rgAnIGwRN/w9XlihbU4SqQHMAvkObAFCGSg3AySKx4AAIVaVoDkQdjOBFzEBJzoln Ihqn2sgglfpekHM27kQwrF9ZME2ZKw6JzZ9+HjgRjImVPrdT+2J403VVCyqBXqdWcyI/ pEIFhMyZTcgJeTEskdQjL28eIHhuHJDsKDp/nI/Ro0acEV45QN4wSvu+lWMv9WPmeqXx 7BtiDoHQ3ZGHoAJXEC8DAW+FA3dAOPm6ohdyo0aCafaaO3qqjo61AXUKRefqYjw0Dw1m qlyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=DiGq++8L+onGlbzyqSifDwiKR7o1FzZbcbbtnv3rVuA=; b=U40pJVoRHLPOlipeeM6HMO08137O+A6aIHo5mntqa1DCjNRx0NPi8RtGPXugmnisCl ySYM75QNtA3gmQg57fEKDzl9lHcfZQjtXn3rGkzfzD2taeCY7SIYP3M7kRrTY1MJCYUo +0xdwemB6Feht96Ywx0MS8VDjqazvtTD/ByOaAAbNMARqYKhlmwds794OrtXvFZmaPJ/ jF/pKNfth96h6WcLxWWnagUNSOROrH8he/kzfKTPEKLB4OfUTd6lp3WVR6ongtOypge7 JkUkmZVw9xLMOfH2Hj5LkeZ89rlizdRTgA5w1e8l8cYUetLqmPc9SV476DRXLA4GRyIq y0LA== X-Gm-Message-State: ACgBeo3IQm0e5LYyTZyAFxFj8McQBHtJsvxZSJJYeO4oU+F8T1+5gc35 FEE+nm57K6SRu5Jiz7jZ5OYBeA== X-Google-Smtp-Source: AA6agR490Fje+0RZ9nk8vN+xnLWyRcUgRMfN6sb/V25nFrMySDrQMtC7bcbMjipBBsPw2gwOYHf0pg== X-Received: by 2002:a2e:a808:0:b0:25f:f326:f2ab with SMTP id l8-20020a2ea808000000b0025ff326f2abmr927859ljq.152.1660293025328; Fri, 12 Aug 2022 01:30:25 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id m7-20020a056512014700b0048ad80a6d07sm132049lfo.170.2022.08.12.01.30.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 01:30:24 -0700 (PDT) Message-ID: <33877eba-1d59-8e3a-4486-751ab9f955e8@linaro.org> Date: Fri, 12 Aug 2022 11:30:20 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings Content-Language: en-US To: Shenwei Wang , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linus.walleij@linaro.org" , "brgl@bgdev.pl" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "imx@lists.linux.dev" References: <20220811124135.95299-1-shenwei.wang@nxp.com> <20220811124135.95299-2-shenwei.wang@nxp.com> <01c832c4-6631-4865-30b3-7f060e27a7ff@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2022 18:30, Shenwei Wang wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Thursday, August 11, 2022 10:11 AM >> To: Shenwei Wang ; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; brgl@bgdev.pl; >> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; >> festevam@gmail.com; dl-linux-imx >> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev >> Subject: Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver >> bindings >> >> Caution: EXT Email >> >> On 11/08/2022 17:52, Shenwei Wang wrote: >>> >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski >>>> Sent: Thursday, August 11, 2022 9:36 AM >>>> To: Shenwei Wang ; robh+dt@kernel.org; >>>> krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; >>>> brgl@bgdev.pl; shawnguo@kernel.org; s.hauer@pengutronix.de; >>>> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx >>>> >>>> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >>>> gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >>>> imx@lists.linux.dev >>>> Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio >>>> driver bindings >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml >>>>> b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml >>>>> new file mode 100644 >>>>> index 000000000000..a1b024cddc97 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml >>>>> +description: | >>>>> + This module provides the standard interface to control the >>>>> + resource pins in SCU domain on i.MX8 platforms. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - fsl,imx8qxp-sc-gpio >>>> >>>> Now the filename does not match compatible. Use the same compatible >>>> as filename. >>> >>> The subnodes under fsl,scu.yaml have their own naming rule. For >>> example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is >> "fsl,scu-wdt.yaml". >> >> The other files have for example fsl,imx-sc-wdt, so they match compatible. > > I don't see the file fsl,imx-sc-wdt you mentioned under the watchdog directory. > > $ ls fsl* > fsl-imx7ulp-wdt.yaml fsl-imx-wdt.yaml fsl,scu-wdt.yaml Eh, they looked similar enough that I did not spot it during review. fsl,scu-wdt.yaml should be named fsl,imx-sc-wdt.yaml, of course. Best regards, Krzysztof