From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5807B382F2E for ; Mon, 13 Apr 2026 08:28:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776068933; cv=none; b=Ga44zPX31fXF/lP/8lV4iLRY3t/n6XsprunF09x5n7pspJEyp5Z2WY9vxYJ/fbaSjdB2QT8IylOHemnxGHipNdzGttxe3/AxtkZBO3egax59uIrw0HwgUroFiIsCOsozJ1P1rMKES272bdWM/ZJVhzh+3qrw6+WeCnhtbvYygmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776068933; c=relaxed/simple; bh=u70DmloeYG9B8atDr14Mh+dhu99umOa48nnxsXQLips=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mwiBU1rNGDqqddvqR/8WCDD+iJX+MvTZdYIonmLvDO/DW46LbuIAxTxmub1jHtuUBN4d8u/9V1OSLIQER4SvTmlOUq40VcQpDA37mj7FV1n+vqktSNxNalALw0wUwxM3md4a3DgsSwZPylKiBORAaz0EFkEn+KZgjp58d1BmfNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IelQ4kck; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TeHg2Sjv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IelQ4kck"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TeHg2Sjv" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63D7QGkU3709159 for ; Mon, 13 Apr 2026 08:28:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VLMdgLtUvVjpvadR/itTGoqc6ZbV9fFT5xXG0n1J018=; b=IelQ4kcksmPHlwWE sRIbHx/MtDfOYCRBVVe/jxNnE45VPMAXyQzYEdBWkNeuhVQyosgvao9m4MIMhCHY P34gyf37Knae/mtY/GmWXbkF3jrhFFS1wZ9skyQjzXXxLtOVbFosyzyqZ2xJCPXJ H6WGjzoAy19GK7vMG8g2lheuPVVIHakRNRnZRf2caw3eLJ6VJ73wXJY8K78S7nuj vg3jGm/av/1xQCLdnNRAgscDMeQVi2tvljYKFfCkS8yhaRtk0YJFx4sntish+Ncj 4Qy98mhaBtvOnQeRENir8hB/IuGEzpkUA1xnf6CctX7F9B3Cgdij7dhnw9nUaFAh XzlYhg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dfjbpc51d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Apr 2026 08:28:51 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8aca8a79f42so1685706d6.2 for ; Mon, 13 Apr 2026 01:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776068931; x=1776673731; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VLMdgLtUvVjpvadR/itTGoqc6ZbV9fFT5xXG0n1J018=; b=TeHg2SjvfFvJ5bKrIsSZysIVpq1pISLW4ZElr6/sKo/lni2hTRgpmSpbKqfBBcYxT9 1lyoZwAwTSYtKNGVl4Bx1nMNwd0CzXQJsDxKocKGDRxjqYbOAyKq8WNpLRw9f19HgpZd q4BoqEu9rRcrNDprwH3ZdDC7WovKzye6m9NAyhKLcC/fk8IoG5VkFag6k5Jrx0vHNZ0w 6Esnv4YnzZ4BG81XQvBmTdQPSTLYjPqbT1NNf4C0lWsSW88L5qTaLs2hO9Qoi7mISRbs eqa5BWDdQinUCArQYiBXi7EhxRN27rEa6kRGz2iqaah35VM/va7o5oVwA7qxGb7sxT7p sZjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776068931; x=1776673731; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VLMdgLtUvVjpvadR/itTGoqc6ZbV9fFT5xXG0n1J018=; b=lmTwmzCNiZtis39noNV9gWR48aUYLCMMbWf/OmH25bYiMb7NXMezIcVy+e0HszHvLS wi2eeiPKSRwVo2PzYNuMLq2jrMQM8gdNhLpab1r1q0JrNwHWBx4AWER3BLlIz3dzWM+D e+ZRVxyCpSVh2/XAeicoFx4En/71JDwDy7v7fH24VcZZZrmAYx0TYNzqkqOr6DP0Q+hy drKeKvYjgNxjGzKZwqXNfI82G9ElBVJmAQ/P8jKlVsHAR/6pe8pPQtMQoD+/Hr1Kxcbp Nms9dc/TkMRb/apFC5/GkQ+MZS8+f0Dyot/kj31G6kPmGkIwW5J77FrhtHuZ/+qwmqeN HH/A== X-Forwarded-Encrypted: i=1; AFNElJ9D6uYIOCell5XE0S/kLc+8lwZSSFGAbPdtl8e6xr4Sj9+GItHaJmGoWXmlbZ7aRSzibnAGjnBGnSWOCG0=@vger.kernel.org X-Gm-Message-State: AOJu0YzPU9TvU1/lMQ/S93USBfRzxDTNlyZ9AacwCdI9HSh40sd7M9cH yuAFV6q1iq0w3qaFJ0bKF6A5HGnbOpm7OhxpaNos6q0ZebJaFw6BFPrYBNB86GZypu+WJG1k8Sc LRorl0hDmJYZA9vLf2kZ8urSXLWTQP9mCxCHKMMQtIdnQuTLFe8Sa3dqU2gzq6yDgpVw= X-Gm-Gg: AeBDiev1CvaGODLlJgWwkcwXBzsuAx7dc7sNtH407ZANZiACnjzSNMXOGzb7+iewh15 w/SqSKF8a6zJtEwJCvqvI6q7bwiM7sfRddY4+NMmvNps6eKEafaD+JhHrNsaGMGjo/CBCiYXTW6 6M5mUHHDC36y6KSt/ILqVpfKHZt9mvWe4ILOqPvYhA2ANKhtA7tY2Fq/Cp9O+jzmUVUKKomtyHN TinCcFMFhaYEIAcblMIDiCkH8U2cDkaRO9jLn2Mvxc3JxK8F1EAoZFuPFEXb2b0xk/xElqrXPVA q/9RMHKMFwhFhZeUhMxFm47Mwz5XRLzRv/mh26qtL5le1+9J3RnS3mqAYe6zbz6ohDQEnKj0dOq G2wO4xl8Sq5T+llcT5hC4x1huBarask4Vo/gPcW+epo8K9Bnmq3i93uBVtTsFDGPBUoencPFenM x/GcM= X-Received: by 2002:a05:6214:1d02:b0:8ac:b4d5:50f0 with SMTP id 6a1803df08f44-8acb4d55df5mr10040846d6.7.1776068930563; Mon, 13 Apr 2026 01:28:50 -0700 (PDT) X-Received: by 2002:a05:6214:1d02:b0:8ac:b4d5:50f0 with SMTP id 6a1803df08f44-8acb4d55df5mr10040646d6.7.1776068930083; Mon, 13 Apr 2026 01:28:50 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e5c5af1sm283525766b.39.2026.04.13.01.28.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 01:28:49 -0700 (PDT) Message-ID: <338935d9-055a-4f0f-a591-0ed07c471e7b@oss.qualcomm.com> Date: Mon, 13 Apr 2026 10:28:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/35] irqchip/qcom-pdc: Split __pdc_enable_intr() into per-version helpers To: Mukesh Ojha , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260410184124.1068210-1-mukesh.ojha@oss.qualcomm.com> <20260410184124.1068210-3-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260410184124.1068210-3-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PuijqQM3 c=1 sm=1 tr=0 ts=69dca943 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=7VHkyeIEd6B37TvAa9YA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-ORIG-GUID: UtknJzR-4rpsoezSEZPe2YZZyTw--AIU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEzMDA4MSBTYWx0ZWRfX1K/amq1f637w x0B9KdOl+JSmzBGgQ7QF1qWO3cT01YaepgVyGI6wZyejb2j/PcTjxC0NtP/bDu8ryX3Dtil26HI NVZK2MnUD4+cRsHZ2VSKS3aRyUmnWHpHO6/P0tcilmXnUvWKfsAdT/QjA0L0B9aXbvYRp4jXpFW 3Wx8JildlCuCEUQ23PndzlF8yBJPmzPPemh/tJ32GWKrmlbvk2IAB0pVTEHwXwJ21/LOLWqg7oq 2M7D/VTnjst8BOPZ1CFtdLQOoHPjIUPqeukev8sDqFaRcx1FMkWJfKdiu7CX5TLR2tJrailYwvU DDKzmLR+emIAno8HtIcqE18oHE3kVjzvwKA4HgX9Jgsu1+y06spk6pvzQSjwRsBPrdYKw4OEpae uDiKh6NI8B3taUYzLnCEXJlyvfOs+uI8mF5xNiPuJVh5tMm+8i4FRfOA6G4tmex3nt+k2+7ONZG awzNsLwnqss/p8uJpOA== X-Proofpoint-GUID: UtknJzR-4rpsoezSEZPe2YZZyTw--AIU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-13_02,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604130081 On 4/10/26 8:40 PM, Mukesh Ojha wrote: > The __pdc_enable_intr() function contains a version branch that selects > between two distinct enable mechanisms: a bank-based IRQ_ENABLE_BANK > register for HW < 3.2, and a per-pin enable bit in IRQ_i_CFG for > HW >= 3.2. These two paths share no code and serve different hardware. > > Split them into two focused static functions: pdc_enable_intr_bank() > for HW < 3.2 and pdc_enable_intr_cfg() for HW >= 3.2. No functional > change. > > Signed-off-by: Mukesh Ojha > --- Reviewed-by: Konrad Dybcio Konrad