From: daniel watson <ozzloy@challenge-bot.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Daniel Watson <ozzloy@challenge-bot.com>
Subject: [PATCH v2 3/4] staging: r8188eu: call rtw_IOL_append_WD_cmd directly
Date: Tue, 14 Jun 2022 17:49:27 -0700 [thread overview]
Message-ID: <338bf7d1067d625299c2077fcd01d7bb09c2bc37.1655249804.git.ozzloy@challenge-bot.com> (raw)
In-Reply-To: <cover.1655249804.git.ozzloy@challenge-bot.com>
From: Daniel Watson <ozzloy@challenge-bot.com>
Call rtw_IOL_append_WD_cmd directly, instead of using wrapper macro.
Delete wrapper macro, which is not needed.
Signed-off-by: Daniel Watson <ozzloy@challenge-bot.com>
---
Changes in v2:
- Make the commit message clearer
Note: This code has not been run on hardware.
drivers/staging/r8188eu/core/rtw_iol.c | 2 +-
drivers/staging/r8188eu/include/rtw_iol.h | 6 ++----
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_iol.c b/drivers/staging/r8188eu/core/rtw_iol.c
index 7292bab126074..b7ee3833c908c 100644
--- a/drivers/staging/r8188eu/core/rtw_iol.c
+++ b/drivers/staging/r8188eu/core/rtw_iol.c
@@ -95,7 +95,7 @@ int rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, u16 addr, u16 value, u1
return rtw_IOL_append_cmds(xmit_frame, (u8 *)&cmd, cmd.length);
}
-int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, u32 value, u32 mask)
+int rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, u32 value, u32 mask)
{
struct ioreg_cfg cmd = {8, IOREG_CMD_WD_REG, 0x0, 0x0, 0x0};
diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8188eu/include/rtw_iol.h
index c99d7d5151099..9ad467759ef1c 100644
--- a/drivers/staging/r8188eu/include/rtw_iol.h
+++ b/drivers/staging/r8188eu/include/rtw_iol.h
@@ -45,12 +45,10 @@ int rtw_IOL_append_WB_cmd(struct xmit_frame *xmit_frame, u16 addr,
u8 value, u8 mask);
int rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, u16 addr,
u16 value, u16 mask);
-int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr,
- u32 value, u32 mask);
+int rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr,
+ u32 value, u32 mask);
int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path,
u16 addr, u32 value, u32 mask);
-#define rtw_IOL_append_WD_cmd(xmit_frame, addr, value, mask) \
- _rtw_IOL_append_WD_cmd((xmit_frame), (addr), (value), (mask))
#define rtw_IOL_append_WRF_cmd(xmit_frame, rf_path, addr, value, mask) \
_rtw_IOL_append_WRF_cmd((xmit_frame),(rf_path), (addr), (value), (mask))
--
2.34.1
next prev parent reply other threads:[~2022-06-15 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 0:49 [PATCH v2 0/4] call rtw_IOL_append_*_cmd directly daniel watson
2022-06-15 0:49 ` [PATCH v2 1/4] staging: r8188eu: call rtw_IOL_append_WB_cmd directly daniel watson
2022-06-15 0:49 ` [PATCH v2 2/4] staging: r8188eu: call rtw_IOL_append_WW_cmd directly daniel watson
2022-06-15 0:49 ` daniel watson [this message]
2022-06-15 0:49 ` [PATCH v2 4/4] staging: r8188eu: call rtw_IOL_append_WRF_cmd directly daniel watson
2022-06-15 8:37 ` [PATCH v2 0/4] call rtw_IOL_append_*_cmd directly Dan Carpenter
2022-06-15 17:16 ` daniel watson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=338bf7d1067d625299c2077fcd01d7bb09c2bc37.1655249804.git.ozzloy@challenge-bot.com \
--to=ozzloy@challenge-bot.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®