mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Samuel Holland <samuel.holland@sifive.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Inochi Amaoto <inochiama@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: THEAD_C901_ACLINT_SSWI should depend on ARCH_THEAD
Date: Tue, 12 Nov 2024 10:38:11 -0600	[thread overview]
Message-ID: <338c06d8-627e-4ca9-b5d0-6ce87b5cc83c@sifive.com> (raw)
In-Reply-To: <1097d054ed4c67f714679de1253e45a034e647a0.1731425416.git.geert+renesas@glider.be>

Hi Geert,

On 2024-11-12 9:31 AM, Geert Uytterhoeven wrote:
> The T-HEAD ACLINT S-mode IPI Interrupt Controller is only present on
> T-HEAD SoCs.  Hence add a dependency on ARCH_THEAD, to prevent asking

This is not correct. This interrupt controller is part of the T-HEAD CPU IP, so
it is included in SoCs from other vendors (Allwinner, Sophgo, etc.) that use
T-HEAD CPUs as well.

Regards,
Samuel

> the user about this driver when configuring a kernel without T-HEAD SoC
> support.
> 
> Fixes: 25caea955cc95050 ("irqchip: Add T-HEAD C900 ACLINT SSWI driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/irqchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 28c19bde55206847..3f4cfcbecc5a4041 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -617,6 +617,7 @@ config THEAD_C900_ACLINT_SSWI
>  	bool "THEAD C9XX ACLINT S-mode IPI Interrupt Controller"
>  	depends on RISCV
>  	depends on SMP
> +	depends on ARCH_THEAD || COMPILE_TEST
>  	select IRQ_DOMAIN_HIERARCHY
>  	select GENERIC_IRQ_IPI_MUX
>  	help


  reply	other threads:[~2024-11-12 16:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 15:31 Geert Uytterhoeven
2024-11-12 16:38 ` Samuel Holland [this message]
2024-11-12 16:44   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=338c06d8-627e-4ca9-b5d0-6ce87b5cc83c@sifive.com \
    --to=samuel.holland@sifive.com \
    --cc=geert+renesas@glider.be \
    --cc=inochiama@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®