From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755865AbcFIGvZ (ORCPT ); Thu, 9 Jun 2016 02:51:25 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:15950 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbcFIGvX (ORCPT ); Thu, 9 Jun 2016 02:51:23 -0400 X-AuditID: cbfec7f4-f796c6d000001486-86-575911e797c3 Subject: Re: [RFC PATCH 15/15] iommu/exynos: update to use iommu big-endian To: Matthew Leach , Krzysztof Kozlowski , Ben Dooks References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-16-matthew@mattleach.net> Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joerg Roedel , Kukjin Kim , iommu@lists.linux-foundation.org From: Marek Szyprowski Message-id: <338cbdc6-2830-813b-713e-1cc40d23d1f9@samsung.com> Date: Thu, 09 Jun 2016 08:51:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-version: 1.0 In-reply-to: <20160608183110.13851-16-matthew@mattleach.net> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xq7rPBSPDDa4tUrF4cKuVyWLBfmuL ztkb2C1evzC06H/8mtli0+NrrBaXd81hs5hxfh+TRePSZSwOnB5PDs5j8nj2cjKTx6ZVnWwe m5fUe0y+sZzRY+qHdSwefVtWMXp83iQXwBHFZZOSmpNZllqkb5fAlTFl3Q3GgkWCFZ97bzI1 MHbwdTFyckgImEjM+3+DEcIWk7hwbz1bFyMXh5DAUkaJjs5WRgjnOaNE079f7F2MHBzCAt4S G6eCFYkINDNKzGt+xAbSLSSQIzH5z0WwBLPAOUaJPzdXM4Mk2AQMJbredoEV8QrYSVyYcxQs ziKgKtF0ZTXYalGBGInG24fZIWoEJX5MvscCYnMK2Eg09ixmArGZBcwkvrw8zAphy0tsXvOW eQKjwCwkLbOQlM1CUraAkXkVo2hqaXJBcVJ6rqFecWJucWleul5yfu4mRkhUfNnBuPiY1SFG AQ5GJR5ezZSIcCHWxLLiytxDjBIczEoivMXskeFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeefu eh8iJJCeWJKanZpakFoEk2Xi4JRqYEx5HeoRtztItf581MUPdatZu98dCA/2n7Frasm/t1c3 7c1yfXTn19f7+9r91vqdmbLqQNhJvjeZ3OeCg0N2tVmIHU1rPzZnZ/Ris71v764Sqz/puUHX t4fFmvfiVGbrtR1Lf3MufPbEUPv7qqZG+4BLmjEGFbHWBdVXLMPP7+Tzi7q9Sf5KygslluKM REMt5qLiRACqEH/EhgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 2016-06-08 20:31, Matthew Leach wrote: > From: Ben Dooks > > Add initial support for big endian by always writing the pte > in le32. Note, revisit if hardware capable of doing big endian > fetches. > > Signed-off-by: Ben Dooks Acked-by: Marek Szyprowski Just to keep my curiosity satisfied - what's the reason to use big-endian on ARM? Good luck with fixing the kernel and userspace codes, which usually assume little-endian is the only possible order! > --- > Cc: Marek Szyprowski > Cc: Joerg Roedel > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: iommu@lists.linux-foundation.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org (open list) > --- > drivers/iommu/exynos-iommu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index 5ecc86c..dd8b3b3 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -54,6 +54,10 @@ typedef u32 sysmmu_pte_t; > #define lv2ent_small(pent) ((*(pent) & 2) == 2) > #define lv2ent_large(pent) ((*(pent) & 3) == 1) > > +#ifdef CONFIG_BIG_ENDIAN > +#warning "revisit driver if we can enable big-endian ptes" > +#endif > + This warning can be removed. There is no way to force SYSMMU to operate with big-endian PTEs according to the datasheet. > /* > * v1.x - v3.x SYSMMU supports 32bit physical and 32bit virtual address spaces > * v5.0 introduced support for 36bit physical address space by shifting > @@ -716,7 +720,7 @@ static inline void update_pte(sysmmu_pte_t *ent, sysmmu_pte_t val) > { > dma_sync_single_for_cpu(dma_dev, virt_to_phys(ent), sizeof(*ent), > DMA_TO_DEVICE); > - *ent = val; > + *ent = cpu_to_le32(val); > dma_sync_single_for_device(dma_dev, virt_to_phys(ent), sizeof(*ent), > DMA_TO_DEVICE); > } Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland