From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbdH3Xli (ORCPT ); Wed, 30 Aug 2017 19:41:38 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:48511 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbdH3Xlh (ORCPT ); Wed, 30 Aug 2017 19:41:37 -0400 From: "Rafael J. Wysocki" To: Colin King Cc: Viresh Kumar , linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: speedstep-lib: make several arrays static, makes code smaller Date: Thu, 31 Aug 2017 01:32:53 +0200 Message-ID: <3397376.XDXHdZtiYO@aspire.rjw.lan> In-Reply-To: <20170825170016.23719-1-colin.king@canonical.com> References: <20170825170016.23719-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, August 25, 2017 7:00:16 PM CEST Colin King wrote: > From: Colin Ian King > > Don't populate arrays on the stack, instead make them static. > Makes the object code smaller by over 860 bytes: > > Before: > text data bss dec hex filename > 10716 5196 0 15912 3e28 drivers/cpufreq/speedstep-lib.o > > After: > text data bss dec hex filename > 9690 5356 0 15046 3ac6 drivers/cpufreq/speedstep-lib.o > > Signed-off-by: Colin Ian King > --- > drivers/cpufreq/speedstep-lib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c > index 1b8062182c81..ccab452a4ef5 100644 > --- a/drivers/cpufreq/speedstep-lib.c > +++ b/drivers/cpufreq/speedstep-lib.c > @@ -35,7 +35,7 @@ static int relaxed_check; > static unsigned int pentium3_get_frequency(enum speedstep_processor processor) > { > /* See table 14 of p3_ds.pdf and table 22 of 29834003.pdf */ > - struct { > + static const struct { > unsigned int ratio; /* Frequency Multiplier (x10) */ > u8 bitmap; /* power on configuration bits > [27, 25:22] (in MSR 0x2a) */ > @@ -58,7 +58,7 @@ static unsigned int pentium3_get_frequency(enum speedstep_processor processor) > }; > > /* PIII(-M) FSB settings: see table b1-b of 24547206.pdf */ > - struct { > + static const struct { > unsigned int value; /* Front Side Bus speed in MHz */ > u8 bitmap; /* power on configuration bits [18: 19] > (in MSR 0x2a) */ > Applied, thanks!