From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 055F9C77B7E for ; Thu, 1 Jun 2023 13:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233883AbjFAN14 (ORCPT ); Thu, 1 Jun 2023 09:27:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233799AbjFAN1r (ORCPT ); Thu, 1 Jun 2023 09:27:47 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F60B1B9 for ; Thu, 1 Jun 2023 06:27:29 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-51492ae66a4so1310160a12.1 for ; Thu, 01 Jun 2023 06:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685626045; x=1688218045; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=0Bh0NwcmQVDulBJjQlFxoXeFk9v1DzA4S7ePzbUk4+w=; b=q1iotZxbLy8szFOTeC5e/G0VQdDeibKUxN1V13zopsKDoRyLSyc6Z3+4NCEAYIHRcr 0Y+SOKRkc0h/8PrlcU2NIUN1lDLPBiHpGdDNpR2mlagpo/gvLvFSQS3CValEhaAtjE+2 RE+eVynh/sqxFzs+LL8qvlWKtlmi6qvz/TKHDm0/IH+D5aOrdEusPcJwXPMYNre/ulBW FI9QWATMBhOQi00g1fzNaUT9uFmVOiAy+PvM5ML4OmjN50l9Q4JqXau5CjGGmBr819kT fq1kDhA1u4fUCbzvrfZF+RjuYK9zU0Wo40z60SZLVIhSRl3FKihyEIC7AAk5scS9W995 Kp9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685626045; x=1688218045; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Bh0NwcmQVDulBJjQlFxoXeFk9v1DzA4S7ePzbUk4+w=; b=ZjN8i5L6VMsgGmru/SykL2wbzXHW6tH724SVWj/23cOnAMy+y4FmSMS0Q18ZbcauCb GHJi7PwAApluZJcE8NmiFXNojcJN9HqzT0MTfcKwj7NH+7LfMoLQsfGOQ7asCGtSUEqY r9/Dj1k7vIdkZYJ0c8lL5vioaL1mnSlt9ebAHzPrJA1KFQGWeuUnXBxMK37fQT4u/9et oNM9a8rXJRQDDC72ubnL1zNa0fRo7qdVq9uY9maY1qM+OreweFFsn6uLIOCm7iIEcsQn OMKJHZXKsXhqfWm5OjBCfkElxxoE3sns7oY0RT8lvXt3gNSFU0JRyz+tOwo2W0uF6Stn WuLg== X-Gm-Message-State: AC+VfDyDrN60zF3Krecb9UPEELaXKFRMs0OuMxtf9ZPf8RN+YoE9VVRe S+X3ALmgGuv05mkfyzB774D6fg== X-Google-Smtp-Source: ACHHUZ56vTDQLpgZcsfUFAD+UPccMtNn7lITWkhbfSA78O9BcUWWDHiZ5WDLxtlvxFtNO3fcz/01mw== X-Received: by 2002:a05:6402:12ce:b0:514:938a:67cd with SMTP id k14-20020a05640212ce00b00514938a67cdmr5009231edx.38.1685626045251; Thu, 01 Jun 2023 06:27:25 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id y1-20020aa7c241000000b0050bfeb15049sm7070997edo.60.2023.06.01.06.27.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 06:27:24 -0700 (PDT) Message-ID: <33979417-2c0c-5474-23e0-7e72add99873@linaro.org> Date: Thu, 1 Jun 2023 15:27:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver From: Krzysztof Kozlowski To: Sricharan Ramabadhran , andy.shevchenko@gmail.com Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robimarko@gmail.com References: <20230519125409.497439-1-quic_srichara@quicinc.com> <20230519125409.497439-5-quic_srichara@quicinc.com> <1823419a-6bb4-03f7-d5ae-e32204c5e598@quicinc.com> <664940c3-9ec1-b4bd-9db5-fa3529e3d1ff@linaro.org> <8146f367-c539-bea5-12b6-424213018488@quicinc.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2023 13:53, Krzysztof Kozlowski wrote: > On 01/06/2023 13:41, Sricharan Ramabadhran wrote: >> >> >> On 6/1/2023 3:21 PM, Krzysztof Kozlowski wrote: >>> On 01/06/2023 11:50, Sricharan Ramabadhran wrote: >>>> >>>> >>>> On 5/29/2023 9:25 PM, andy.shevchenko@gmail.com wrote: >>>>> Mon, May 29, 2023 at 03:58:09PM +0530, Sricharan Ramabadhran kirjoitti: >>>>>> On 5/20/2023 12:17 AM, Andy Shevchenko wrote: >>>>>>> On Fri, May 19, 2023 at 3:55 PM Sricharan Ramabadhran >>>>>>> wrote: >>>>> >>>>> ... >>>>> >>>>>>> depends on OF || COMPILE_TEST >>>>>> >>>>>> Yeah sure. COMPILE_TEST could be standalone. Will fix it and repost. >>>>> >>>>> Standalone COMPILE_TEST will give you definitely NOT what you want. >>>>> And actually it's strange to have it standalone. >>>>> >>>> >>>> Ho ok, i meant like this, "depends on ARM64 || COMPILE_TEST" >>> >>> Don't do it differently than all other drivers. Open the Kconfig and >>> look at existing entries. >>> >> The latest added has this below, will use this >> >> depends on OF || COMPILE_TEST > > I would even drop this... Lemme check, it looks odd. We depend on > ARCH_QCOM which uses OF. We have few drivers which depend on ACPI, but > that also seems wrong. These are platform drivers so they should expect > platform select proper firmware interface. I think none of other > platform drivers do like this (neither Samsung pinctrl nor other > Qualcomm drivers)). > > I will fix this. For your patch I would just skip OF entirely. Correction: you need OF :( Best regards, Krzysztof