From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6B0C4332F for ; Wed, 27 Oct 2021 09:00:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 864BB60D43 for ; Wed, 27 Oct 2021 09:00:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232420AbhJ0JDM (ORCPT ); Wed, 27 Oct 2021 05:03:12 -0400 Received: from foss.arm.com ([217.140.110.172]:41002 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232047AbhJ0JDH (ORCPT ); Wed, 27 Oct 2021 05:03:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C1B131063; Wed, 27 Oct 2021 02:00:41 -0700 (PDT) Received: from [10.57.24.210] (unknown [10.57.24.210]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D667C3F70D; Wed, 27 Oct 2021 02:00:38 -0700 (PDT) Subject: Re: [PATCH v2 2/5] thermal: cpufreq_cooling: Use new thermal pressure update function To: Dietmar Eggemann Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk, gregkh@linuxfoundation.org, rafael@kernel.org, viresh.kumar@linaro.org, amitk@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, thara.gopinath@linaro.org, bjorn.andersson@linaro.org, agross@kernel.org References: <20211015144550.23719-1-lukasz.luba@arm.com> <20211015144550.23719-3-lukasz.luba@arm.com> <495d461a-d643-5dbf-7da8-74ddbdc486ca@arm.com> From: Lukasz Luba Message-ID: <3397e593-637a-8b23-f65e-2aca4d84e627@arm.com> Date: Wed, 27 Oct 2021 10:00:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <495d461a-d643-5dbf-7da8-74ddbdc486ca@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/21 5:51 PM, Dietmar Eggemann wrote: > On 15/10/2021 16:45, Lukasz Luba wrote: > > [...] > >> @@ -479,10 +478,7 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, >> if (ret >= 0) { >> cpufreq_cdev->cpufreq_state = state; >> cpus = cpufreq_cdev->policy->related_cpus; >> - max_capacity = arch_scale_cpu_capacity(cpumask_first(cpus)); >> - capacity = frequency * max_capacity; >> - capacity /= cpufreq_cdev->policy->cpuinfo.max_freq; > > Took me a while to realize that `cpufreq_cdev->policy->cpuinfo.max_freq` > is 1000 * per_cpu(freq_factor, cpu), the latter being used now in > arch_thermal_pressure_update(). Maybe worth mentioning in the patch header? > OK, I will put that information into the patch description in the next version.