From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jessica Zhang <jesszhan0024@gmail.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 17/39] drm/msm/dp: Add catalog support for 3rd/4th stream MST
Date: Mon, 25 May 2026 20:01:09 +0800 [thread overview]
Message-ID: <339aac36-db5a-4013-aa7f-58715f3fb9d3@oss.qualcomm.com> (raw)
In-Reply-To: <4t6jaqelrjdcoczdtnig5pwpsm4fj3fxo4sqh7222dh26dzq3o@yc3t7y2amsl3>
On 5/25/2026 4:25 PM, Dmitry Baryshkov wrote:
> On Mon, May 25, 2026 at 04:06:17PM +0800, Yongxing Mou wrote:
>>
>>
>> On 4/12/2026 2:24 AM, Dmitry Baryshkov wrote:
>>> Nit, there is no catalog anymore, please fix the subject line.
>>>
>>> On Fri, Apr 10, 2026 at 05:33:52PM +0800, Yongxing Mou wrote:
>>>> To support 4-stream MST, the link clocks for stream 3 and stream 4 are
>>>> controlled by MST_2_LCLK and MST_3_LCLK which share the same register
>>>> definitions but use different base addresses.
>>>>
>>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>>> ---
>>>> drivers/gpu/drm/msm/dp/dp_ctrl.c | 225 ++++++++++++++++++++++--------------
>>>> drivers/gpu/drm/msm/dp/dp_ctrl.h | 4 +-
>>>> drivers/gpu/drm/msm/dp/dp_display.c | 24 +++-
>>>> drivers/gpu/drm/msm/dp/dp_panel.c | 135 +++++++++++++++++-----
>>>> drivers/gpu/drm/msm/dp/dp_panel.h | 2 +
>>>> drivers/gpu/drm/msm/dp/dp_reg.h | 16 ++-
>>>> 6 files changed, 283 insertions(+), 123 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
>>>> index a52bcd9ea2a3..1109b2df21be 100644
>>>> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
>>>> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
>>>> @@ -118,6 +118,8 @@ struct msm_dp_ctrl_private {
>>>> struct msm_dp_link *link;
>>>> void __iomem *ahb_base;
>>>> void __iomem *link_base;
>>>> + void __iomem *mst2link_base;
>>>> + void __iomem *mst3link_base;
>>>> struct phy *phy;
>>>> @@ -158,19 +160,45 @@ static inline void msm_dp_write_ahb(struct msm_dp_ctrl_private *ctrl,
>>>> writel(data, ctrl->ahb_base + offset);
>>>> }
>>>> -static inline u32 msm_dp_read_link(struct msm_dp_ctrl_private *ctrl, u32 offset)
>>>> +static inline u32 msm_dp_read_link(struct msm_dp_ctrl_private *ctrl,
>>>> + enum msm_dp_stream_id stream_id, u32 offset)
>>>> {
>>>> - return readl_relaxed(ctrl->link_base + offset);
>>>> + switch (stream_id) {
>>>> + case DP_STREAM_0:
>>>> + case DP_STREAM_1:
>>>
>>> Continuing the comment from the previous patch:
>>>
>>> Or, can we remap all offsets here? It would be much, much easier to
>>> always pass REG_DP_foo and then here, in the link reading code, remap
>>> the offsets for DP_STREAM_1.
>>>
>> The stream 1 offsets relative to stream 0 are not uniform:
>> REG_DP_CONFIGURATION_CTRL 0x008 -> 0x400 (diff 0x3F8)
>> REG_DP_MISC1_MISC0 0x02C -> 0x42C (diff 0x400)
>> So remapping inside msm_dp_read/write_link would require a full lookup
>> table, which seems not help for current status.
>>
>> Can we introduce a small helper msm_dp_stream_reg() that selects the correct
>> register address at the call site:
>> //dp_panel.h
>> static inline u32 msm_dp_stream_reg(enum msm_dp_stream_id id,
>> u32 reg_s0, u32 reg_s1, u32 reg_mst)
>> {
>> if (id > DP_STREAM_1)
>> return reg_mst;
>> return id == DP_STREAM_1 ? reg_s1 : reg_s0;
>> }
>
> No, that's what I want to get rid of. You are spreading these lookups
> all over the code. Push them to a single function (or a single set of
> functions, one per the stream, but having a single frontend to be called
> by the rest of the driver).
>
Okay. I should got how to do..
void msm_dp_write_link ()
{
offset = msm_dp_stream_reg(stream_id, offset);
switch (stream_id) {
....
}
msm_dp_stream_reg() will handle all the offset. then callers then simply do:
msm_dp_write_link(ctrl, panel->stream_id, REG_DP_MISC1_MISC0, val);
Does this match what you had in mind?
>>
>> //dp_panel.c and dp_ctrl.c
>> u32 reg = msm_dp_stream_reg(stream_id,
>> REG_DP_MISC1_MISC0,
>> REG_DP1_MISC1_MISC0,
>> REG_DP_MSTLINK_MISC1_MISC0);
>
> And then, if we need to support more streams or if the map for the
> registers change, we'd need to go through all caller sites. No, that's a
> bad idea.
>
>> msm_dp_read_link(ctrl, stream_id, reg);
>>>> + return readl_relaxed(ctrl->link_base + offset);
>>>> + case DP_STREAM_2:
>>>> + return readl_relaxed(ctrl->mst2link_base + offset);
>>>> + case DP_STREAM_3:
>>>> + return readl_relaxed(ctrl->mst3link_base + offset);
>>>> + default:
>>>> + DRM_ERROR("error stream_id\n");
>>>> + return 0;
>>>> + }
>>>> }
>>>> static inline void msm_dp_write_link(struct msm_dp_ctrl_private *ctrl,
>>>> - u32 offset, u32 data)
>>>> + enum msm_dp_stream_id stream_id, u32 offset, u32 data)
>>>> {
>>>> /*
>>>> * To make sure link reg writes happens before any other operation,
>>>> * this function uses writel() instread of writel_relaxed()
>>>> */
>>>> - writel(data, ctrl->link_base + offset);
>>>> + switch (stream_id) {
>>>> + case DP_STREAM_0:
>>>> + case DP_STREAM_1:
>>>> + writel(data, ctrl->link_base + offset);
>>>> + break;
>>>> + case DP_STREAM_2:
>>>> + writel(data, ctrl->mst2link_base + offset);
>>>> + break;
>>>> + case DP_STREAM_3:
>>>> + writel(data, ctrl->mst3link_base + offset);
>>>> + break;
>>>> + default:
>>>> + DRM_ERROR("error stream_id\n");
>>>> + break;
>>>> + }
>>>> }
>>>> static int msm_dp_aux_link_configure(struct drm_dp_aux *aux,
>>>> @@ -294,18 +322,18 @@ static void msm_dp_ctrl_psr_mainlink_enable(struct msm_dp_ctrl_private *ctrl)
>>>> {
>>>> u32 val;
>>>> - val = msm_dp_read_link(ctrl, REG_DP_MAINLINK_CTRL);
>>>> + val = msm_dp_read_link(ctrl, 0, REG_DP_MAINLINK_CTRL);
>>>> val |= DP_MAINLINK_CTRL_ENABLE;
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, val);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, val);
>>>
>>> Are those always using the link0 base? If so, can we keep the existing
>>> API for the stream-independent registers and introduce a separate API
>>> call for the stream-dependent calls? Generally, if you keep the existing
>>> function, I think, it becomes easier to squash this and the previous
>>> patches.
>>>
>> Here will always using the link0 base. After introducing the helper func,
>> will squash this patch into the previous one.
>>>> }
>>>> static void msm_dp_ctrl_psr_mainlink_disable(struct msm_dp_ctrl_private *ctrl)
>>>> {
>>>> u32 val;
>>>> - val = msm_dp_read_link(ctrl, REG_DP_MAINLINK_CTRL);
>>>> + val = msm_dp_read_link(ctrl, 0, REG_DP_MAINLINK_CTRL);
>>>> val &= ~DP_MAINLINK_CTRL_ENABLE;
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, val);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, val);
>>>> }
>>>> static void msm_dp_ctrl_mainlink_enable(struct msm_dp_ctrl_private *ctrl)
>>>> @@ -314,21 +342,21 @@ static void msm_dp_ctrl_mainlink_enable(struct msm_dp_ctrl_private *ctrl)
>>>> drm_dbg_dp(ctrl->drm_dev, "enable\n");
>>>> - mainlink_ctrl = msm_dp_read_link(ctrl, REG_DP_MAINLINK_CTRL);
>>>> + mainlink_ctrl = msm_dp_read_link(ctrl, 0, REG_DP_MAINLINK_CTRL);
>>>> mainlink_ctrl &= ~(DP_MAINLINK_CTRL_RESET |
>>>> DP_MAINLINK_CTRL_ENABLE);
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> mainlink_ctrl |= DP_MAINLINK_CTRL_RESET;
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> mainlink_ctrl &= ~DP_MAINLINK_CTRL_RESET;
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> mainlink_ctrl |= (DP_MAINLINK_CTRL_ENABLE |
>>>> DP_MAINLINK_FB_BOUNDARY_SEL);
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> }
>>>> static void msm_dp_ctrl_mainlink_disable(struct msm_dp_ctrl_private *ctrl)
>>>> @@ -337,23 +365,23 @@ static void msm_dp_ctrl_mainlink_disable(struct msm_dp_ctrl_private *ctrl)
>>>> drm_dbg_dp(ctrl->drm_dev, "disable\n");
>>>> - mainlink_ctrl = msm_dp_read_link(ctrl, REG_DP_MAINLINK_CTRL);
>>>> + mainlink_ctrl = msm_dp_read_link(ctrl, 0, REG_DP_MAINLINK_CTRL);
>>>> mainlink_ctrl &= ~DP_MAINLINK_CTRL_ENABLE;
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> }
>>>> static void msm_dp_setup_peripheral_flush(struct msm_dp_ctrl_private *ctrl)
>>>> {
>>>> u32 mainlink_ctrl;
>>>> - mainlink_ctrl = msm_dp_read_link(ctrl, REG_DP_MAINLINK_CTRL);
>>>> + mainlink_ctrl = msm_dp_read_link(ctrl, 0, REG_DP_MAINLINK_CTRL);
>>>> if (ctrl->hw_revision >= DP_HW_VERSION_1_2)
>>>> mainlink_ctrl |= DP_MAINLINK_FLUSH_MODE_SDE_PERIPH_UPDATE;
>>>> else
>>>> mainlink_ctrl |= DP_MAINLINK_FLUSH_MODE_UPDATE_SDP;
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, mainlink_ctrl);
>>>> }
>>>> static bool msm_dp_ctrl_mainlink_ready(struct msm_dp_ctrl_private *ctrl)
>>>> @@ -380,7 +408,7 @@ void msm_dp_ctrl_push_idle(struct msm_dp_ctrl *msm_dp_ctrl)
>>>> ctrl = container_of(msm_dp_ctrl, struct msm_dp_ctrl_private, msm_dp_ctrl);
>>>> reinit_completion(&ctrl->idle_comp);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, DP_STATE_CTRL_PUSH_IDLE);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, DP_STATE_CTRL_PUSH_IDLE);
>>>> if (!wait_for_completion_timeout(&ctrl->idle_comp,
>>>> IDLE_PATTERN_COMPLETION_TIMEOUT_JIFFIES))
>>>> @@ -395,7 +423,11 @@ static void msm_dp_ctrl_config_ctrl_streams(struct msm_dp_ctrl_private *ctrl,
>>>> u32 config = 0, tbd;
>>>> u32 reg_offset = 0;
>>>> - config = msm_dp_read_link(ctrl, REG_DP_CONFIGURATION_CTRL);
>>>> + if (msm_dp_panel->stream_id == DP_STREAM_0)
>>>> + config = msm_dp_read_link(ctrl, 0, REG_DP_CONFIGURATION_CTRL);
>>>> +
>>>> + if (msm_dp_panel->stream_id == DP_STREAM_1)
>>>> + reg_offset = REG_DP1_CONFIGURATION_CTRL - REG_DP_CONFIGURATION_CTRL;
>>>> if (msm_dp_panel->msm_dp_mode.out_fmt_is_yuv_420)
>>>> config |= DP_CONFIGURATION_CTRL_RGB_YUV; /* YUV420 */
>>>> @@ -410,8 +442,10 @@ static void msm_dp_ctrl_config_ctrl_streams(struct msm_dp_ctrl_private *ctrl,
>>>> drm_dbg_dp(ctrl->drm_dev, "stream DP_CONFIGURATION_CTRL=0x%x\n", config);
>>>> - if (msm_dp_panel->stream_id == DP_STREAM_1)
>>>> - reg_offset = REG_DP1_CONFIGURATION_CTRL - REG_DP_CONFIGURATION_CTRL;
>>>> + msm_dp_write_link(ctrl, msm_dp_panel->stream_id, msm_dp_panel->stream_id > 1 ?
>>>> + REG_DP_MSTLINK_CONFIGURATION_CTRL :
>>>> + REG_DP_CONFIGURATION_CTRL + reg_offset, config);
>>>> +
>>>
>>> Yep, it would definitely help to handle these differences in the link
>>> writing code.
>>>
>>>> }
>>>> static void msm_dp_ctrl_config_ctrl_link(struct msm_dp_ctrl_private *ctrl)
>>>> @@ -441,7 +475,7 @@ static void msm_dp_ctrl_config_ctrl_link(struct msm_dp_ctrl_private *ctrl)
>>>> drm_dbg_dp(ctrl->drm_dev, "link DP_CONFIGURATION_CTRL=0x%x\n", config);
>>>> - msm_dp_write_link(ctrl, REG_DP_CONFIGURATION_CTRL, config);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_CONFIGURATION_CTRL, config);
>>>> }
>>>> static void msm_dp_ctrl_lane_mapping(struct msm_dp_ctrl_private *ctrl)
>>>> @@ -454,8 +488,8 @@ static void msm_dp_ctrl_lane_mapping(struct msm_dp_ctrl_private *ctrl)
>>>> ln_mapping |= lane_map[2] << LANE2_MAPPING_SHIFT;
>>>> ln_mapping |= lane_map[3] << LANE3_MAPPING_SHIFT;
>>>> - msm_dp_write_link(ctrl, REG_DP_LOGICAL2PHYSICAL_LANE_MAPPING,
>>>> - ln_mapping);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_LOGICAL2PHYSICAL_LANE_MAPPING,
>>>> + ln_mapping);
>>>> }
>>>> static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl,
>>>> @@ -471,7 +505,8 @@ static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl,
>>>> if (msm_dp_panel->stream_id == DP_STREAM_1)
>>>> reg_offset = REG_DP1_MISC1_MISC0 - REG_DP_MISC1_MISC0;
>>>> - misc_val = msm_dp_read_link(ctrl, REG_DP_MISC1_MISC0 + reg_offset);
>>>> + misc_val = msm_dp_read_link(ctrl, msm_dp_panel->stream_id, msm_dp_panel->stream_id > 1 ?
>>>> + REG_DP_MSTLINK_MISC1_MISC0 : REG_DP_MISC1_MISC0 + reg_offset);
>>>> /* clear bpp bits */
>>>> misc_val &= ~(0x07 << DP_MISC0_TEST_BITS_DEPTH_SHIFT);
>>>> @@ -481,7 +516,10 @@ static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl,
>>>> misc_val |= DP_MISC0_SYNCHRONOUS_CLK;
>>>> drm_dbg_dp(ctrl->drm_dev, "misc settings = 0x%x\n", misc_val);
>>>> - msm_dp_write_link(ctrl, REG_DP_MISC1_MISC0 + reg_offset, misc_val);
>>>> + msm_dp_write_link(ctrl, msm_dp_panel->stream_id,
>>>> + msm_dp_panel->stream_id > 1 ?
>>>> + REG_DP_MSTLINK_MISC1_MISC0 : REG_DP_MISC1_MISC0 + reg_offset,
>>>> + misc_val);
>>>> }
>>>> static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl,
>>>> @@ -1307,9 +1345,9 @@ static void msm_dp_ctrl_setup_tr_unit(struct msm_dp_ctrl_private *ctrl)
>>>> pr_debug("dp_tu=0x%x, valid_boundary=0x%x, valid_boundary2=0x%x\n",
>>>> msm_dp_tu, valid_boundary, valid_boundary2);
>>>> - msm_dp_write_link(ctrl, REG_DP_VALID_BOUNDARY, valid_boundary);
>>>> - msm_dp_write_link(ctrl, REG_DP_TU, msm_dp_tu);
>>>> - msm_dp_write_link(ctrl, REG_DP_VALID_BOUNDARY_2, valid_boundary2);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_VALID_BOUNDARY, valid_boundary);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_TU, msm_dp_tu);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_VALID_BOUNDARY_2, valid_boundary2);
>>>> }
>>>> static int msm_dp_ctrl_wait4video_ready(struct msm_dp_ctrl_private *ctrl)
>>>> @@ -1426,7 +1464,7 @@ static int msm_dp_ctrl_set_pattern_state_bit(struct msm_dp_ctrl_private *ctrl,
>>>> bit = BIT(state_bit - 1);
>>>> drm_dbg_dp(ctrl->drm_dev, "hw: bit=%d train=%d\n", bit, state_bit);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, bit);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, bit);
>>>> bit = BIT(state_bit - 1) << DP_MAINLINK_READY_LINK_TRAINING_SHIFT;
>>>> @@ -1453,7 +1491,7 @@ static int msm_dp_ctrl_link_train_1(struct msm_dp_ctrl_private *ctrl,
>>>> delay_us = drm_dp_read_clock_recovery_delay(ctrl->aux,
>>>> ctrl->panel->dpcd, dp_phy, false);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, 0);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, 0);
>>>> *training_step = DP_TRAINING_1;
>>>> @@ -1577,7 +1615,7 @@ static int msm_dp_ctrl_link_train_2(struct msm_dp_ctrl_private *ctrl,
>>>> delay_us = drm_dp_read_channel_eq_delay(ctrl->aux,
>>>> ctrl->panel->dpcd, dp_phy, false);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, 0);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, 0);
>>>> *training_step = DP_TRAINING_2;
>>>> @@ -1694,7 +1732,7 @@ static int msm_dp_ctrl_link_train(struct msm_dp_ctrl_private *ctrl,
>>>> }
>>>> end:
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, 0);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, 0);
>>>> return ret;
>>>> }
>>>> @@ -1840,34 +1878,34 @@ static int msm_dp_ctrl_enable_mainlink_clocks(struct msm_dp_ctrl_private *ctrl)
>>>> static void msm_dp_ctrl_enable_sdp(struct msm_dp_ctrl_private *ctrl)
>>>> {
>>>> /* trigger sdp */
>>>> - msm_dp_write_link(ctrl, MMSS_DP_SDP_CFG3, UPDATE_SDP);
>>>> - msm_dp_write_link(ctrl, MMSS_DP_SDP_CFG3, 0x0);
>>>> + msm_dp_write_link(ctrl, 0, MMSS_DP_SDP_CFG3, UPDATE_SDP);
>>>> + msm_dp_write_link(ctrl, 0, MMSS_DP_SDP_CFG3, 0x0);
>>>> }
>>>> static void msm_dp_ctrl_psr_enter(struct msm_dp_ctrl_private *ctrl)
>>>> {
>>>> u32 cmd;
>>>> - cmd = msm_dp_read_link(ctrl, REG_PSR_CMD);
>>>> + cmd = msm_dp_read_link(ctrl, 0, REG_PSR_CMD);
>>>> cmd &= ~(PSR_ENTER | PSR_EXIT);
>>>> cmd |= PSR_ENTER;
>>>> msm_dp_ctrl_enable_sdp(ctrl);
>>>> - msm_dp_write_link(ctrl, REG_PSR_CMD, cmd);
>>>> + msm_dp_write_link(ctrl, 0, REG_PSR_CMD, cmd);
>>>> }
>>>> static void msm_dp_ctrl_psr_exit(struct msm_dp_ctrl_private *ctrl)
>>>> {
>>>> u32 cmd;
>>>> - cmd = msm_dp_read_link(ctrl, REG_PSR_CMD);
>>>> + cmd = msm_dp_read_link(ctrl, 0, REG_PSR_CMD);
>>>> cmd &= ~(PSR_ENTER | PSR_EXIT);
>>>> cmd |= PSR_EXIT;
>>>> msm_dp_ctrl_enable_sdp(ctrl);
>>>> - msm_dp_write_link(ctrl, REG_PSR_CMD, cmd);
>>>> + msm_dp_write_link(ctrl, 0, REG_PSR_CMD, cmd);
>>>> }
>>>> void msm_dp_ctrl_config_psr(struct msm_dp_ctrl *msm_dp_ctrl)
>>>> @@ -1880,9 +1918,9 @@ void msm_dp_ctrl_config_psr(struct msm_dp_ctrl *msm_dp_ctrl)
>>>> return;
>>>> /* enable PSR1 function */
>>>> - cfg = msm_dp_read_link(ctrl, REG_PSR_CONFIG);
>>>> + cfg = msm_dp_read_link(ctrl, 0, REG_PSR_CONFIG);
>>>> cfg |= PSR1_SUPPORTED;
>>>> - msm_dp_write_link(ctrl, REG_PSR_CONFIG, cfg);
>>>> + msm_dp_write_link(ctrl, 0, REG_PSR_CONFIG, cfg);
>>>> msm_dp_ctrl_config_psr_interrupt(ctrl);
>>>> msm_dp_ctrl_enable_sdp(ctrl);
>>>> @@ -1921,16 +1959,16 @@ void msm_dp_ctrl_set_psr(struct msm_dp_ctrl *msm_dp_ctrl, bool enter)
>>>> }
>>>> msm_dp_ctrl_push_idle(msm_dp_ctrl);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, 0);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, 0);
>>>> msm_dp_ctrl_psr_mainlink_disable(ctrl);
>>>> } else {
>>>> msm_dp_ctrl_psr_mainlink_enable(ctrl);
>>>> msm_dp_ctrl_psr_exit(ctrl);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, DP_STATE_CTRL_SEND_VIDEO);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, DP_STATE_CTRL_SEND_VIDEO);
>>>> msm_dp_ctrl_wait4video_ready(ctrl);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, 0);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, 0);
>>>> }
>>>> }
>>>> @@ -2041,7 +2079,7 @@ static int msm_dp_ctrl_link_maintenance(struct msm_dp_ctrl_private *ctrl)
>>>> msm_dp_ctrl_clear_training_pattern(ctrl, DP_PHY_DPRX);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, DP_STATE_CTRL_SEND_VIDEO);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, DP_STATE_CTRL_SEND_VIDEO);
>>>> ret = msm_dp_ctrl_wait4video_ready(ctrl);
>>>> end:
>>>> @@ -2056,72 +2094,72 @@ static void msm_dp_ctrl_send_phy_pattern(struct msm_dp_ctrl_private *ctrl,
>>>> u32 value = 0x0;
>>>> /* Make sure to clear the current pattern before starting a new one */
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, 0x0);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, 0x0);
>>>> drm_dbg_dp(ctrl->drm_dev, "pattern: %#x\n", pattern);
>>>> switch (pattern) {
>>>> case DP_PHY_TEST_PATTERN_D10_2:
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL,
>>>> - DP_STATE_CTRL_LINK_TRAINING_PATTERN1);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL,
>>>> + DP_STATE_CTRL_LINK_TRAINING_PATTERN1);
>>>> break;
>>>> case DP_PHY_TEST_PATTERN_ERROR_COUNT:
>>>> value &= ~(1 << 16);
>>>> - msm_dp_write_link(ctrl, REG_DP_HBR2_COMPLIANCE_SCRAMBLER_RESET,
>>>> - value);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_HBR2_COMPLIANCE_SCRAMBLER_RESET,
>>>> + value);
>>>> value |= SCRAMBLER_RESET_COUNT_VALUE;
>>>> - msm_dp_write_link(ctrl, REG_DP_HBR2_COMPLIANCE_SCRAMBLER_RESET,
>>>> - value);
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_LEVELS,
>>>> - DP_MAINLINK_SAFE_TO_EXIT_LEVEL_2);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL,
>>>> - DP_STATE_CTRL_LINK_SYMBOL_ERR_MEASURE);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_HBR2_COMPLIANCE_SCRAMBLER_RESET,
>>>> + value);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_LEVELS,
>>>> + DP_MAINLINK_SAFE_TO_EXIT_LEVEL_2);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL,
>>>> + DP_STATE_CTRL_LINK_SYMBOL_ERR_MEASURE);
>>>> break;
>>>> case DP_PHY_TEST_PATTERN_PRBS7:
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL,
>>>> - DP_STATE_CTRL_LINK_PRBS7);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL,
>>>> + DP_STATE_CTRL_LINK_PRBS7);
>>>> break;
>>>> case DP_PHY_TEST_PATTERN_80BIT_CUSTOM:
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL,
>>>> - DP_STATE_CTRL_LINK_TEST_CUSTOM_PATTERN);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL,
>>>> + DP_STATE_CTRL_LINK_TEST_CUSTOM_PATTERN);
>>>> /* 00111110000011111000001111100000 */
>>>> - msm_dp_write_link(ctrl, REG_DP_TEST_80BIT_CUSTOM_PATTERN_REG0,
>>>> - 0x3E0F83E0);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_TEST_80BIT_CUSTOM_PATTERN_REG0,
>>>> + 0x3E0F83E0);
>>>> /* 00001111100000111110000011111000 */
>>>> - msm_dp_write_link(ctrl, REG_DP_TEST_80BIT_CUSTOM_PATTERN_REG1,
>>>> - 0x0F83E0F8);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_TEST_80BIT_CUSTOM_PATTERN_REG1,
>>>> + 0x0F83E0F8);
>>>> /* 1111100000111110 */
>>>> - msm_dp_write_link(ctrl, REG_DP_TEST_80BIT_CUSTOM_PATTERN_REG2,
>>>> - 0x0000F83E);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_TEST_80BIT_CUSTOM_PATTERN_REG2,
>>>> + 0x0000F83E);
>>>> break;
>>>> case DP_PHY_TEST_PATTERN_CP2520:
>>>> - value = msm_dp_read_link(ctrl, REG_DP_MAINLINK_CTRL);
>>>> + value = msm_dp_read_link(ctrl, 0, REG_DP_MAINLINK_CTRL);
>>>> value &= ~DP_MAINLINK_CTRL_SW_BYPASS_SCRAMBLER;
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, value);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, value);
>>>> value = DP_HBR2_ERM_PATTERN;
>>>> - msm_dp_write_link(ctrl, REG_DP_HBR2_COMPLIANCE_SCRAMBLER_RESET,
>>>> - value);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_HBR2_COMPLIANCE_SCRAMBLER_RESET,
>>>> + value);
>>>> value |= SCRAMBLER_RESET_COUNT_VALUE;
>>>> - msm_dp_write_link(ctrl, REG_DP_HBR2_COMPLIANCE_SCRAMBLER_RESET,
>>>> - value);
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_LEVELS,
>>>> - DP_MAINLINK_SAFE_TO_EXIT_LEVEL_2);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL,
>>>> - DP_STATE_CTRL_LINK_SYMBOL_ERR_MEASURE);
>>>> - value = msm_dp_read_link(ctrl, REG_DP_MAINLINK_CTRL);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_HBR2_COMPLIANCE_SCRAMBLER_RESET,
>>>> + value);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_LEVELS,
>>>> + DP_MAINLINK_SAFE_TO_EXIT_LEVEL_2);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL,
>>>> + DP_STATE_CTRL_LINK_SYMBOL_ERR_MEASURE);
>>>> + value = msm_dp_read_link(ctrl, 0, REG_DP_MAINLINK_CTRL);
>>>> value |= DP_MAINLINK_CTRL_ENABLE;
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL, value);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL, value);
>>>> break;
>>>> case DP_PHY_TEST_PATTERN_SEL_MASK:
>>>> - msm_dp_write_link(ctrl, REG_DP_MAINLINK_CTRL,
>>>> - DP_MAINLINK_CTRL_ENABLE);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL,
>>>> - DP_STATE_CTRL_LINK_TRAINING_PATTERN4);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_MAINLINK_CTRL,
>>>> + DP_MAINLINK_CTRL_ENABLE);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL,
>>>> + DP_STATE_CTRL_LINK_TRAINING_PATTERN4);
>>>> break;
>>>> default:
>>>> @@ -2149,7 +2187,7 @@ static bool msm_dp_ctrl_send_phy_test_pattern(struct msm_dp_ctrl_private *ctrl)
>>>> msm_dp_ctrl_update_phy_vx_px(ctrl, DP_PHY_DPRX);
>>>> msm_dp_link_send_test_response(ctrl->link);
>>>> - pattern_sent = msm_dp_read_link(ctrl, REG_DP_MAINLINK_READY);
>>>> + pattern_sent = msm_dp_read_link(ctrl, 0, REG_DP_MAINLINK_READY);
>>>> switch (pattern_sent) {
>>>> case MR_LINK_TRAINING1:
>>>> @@ -2522,8 +2560,14 @@ static void msm_dp_ctrl_config_msa(struct msm_dp_ctrl_private *ctrl,
>>>> nvid *= 3;
>>>> drm_dbg_dp(ctrl->drm_dev, "mvid=0x%x, nvid=0x%x\n", mvid, nvid);
>>>> - msm_dp_write_link(ctrl, REG_DP_SOFTWARE_MVID + mvid_reg_off, mvid);
>>>> - msm_dp_write_link(ctrl, REG_DP_SOFTWARE_NVID + nvid_reg_off, nvid);
>>>> + msm_dp_write_link(ctrl, msm_dp_panel->stream_id,
>>>> + msm_dp_panel->stream_id > 1 ?
>>>> + REG_MSTLINK_SOFTWARE_MVID : REG_DP_SOFTWARE_MVID + mvid_reg_off,
>>>> + mvid);
>>>> + msm_dp_write_link(ctrl, msm_dp_panel->stream_id,
>>>> + msm_dp_panel->stream_id > 1 ?
>>>> + REG_MSTLINK_SOFTWARE_NVID : REG_DP_SOFTWARE_NVID + nvid_reg_off,
>>>> + nvid);
>>>> }
>>>> int msm_dp_ctrl_prepare_stream_on(struct msm_dp_ctrl *msm_dp_ctrl, bool force_link_train)
>>>> @@ -2593,7 +2637,8 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, struct msm_dp_panel *
>>>> msm_dp_ctrl_lane_mapping(ctrl);
>>>> msm_dp_setup_peripheral_flush(ctrl);
>>>> - msm_dp_ctrl_config_ctrl_link(ctrl);
>>>> + if (msm_dp_panel->stream_id == DP_STREAM_0)
>>>> + msm_dp_ctrl_config_ctrl_link(ctrl);
>>>> msm_dp_ctrl_configure_source_params(ctrl, msm_dp_panel);
>>>> @@ -2607,7 +2652,7 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, struct msm_dp_panel *
>>>> msm_dp_ctrl_setup_tr_unit(ctrl);
>>>> - msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, DP_STATE_CTRL_SEND_VIDEO);
>>>> + msm_dp_write_link(ctrl, 0, REG_DP_STATE_CTRL, DP_STATE_CTRL_SEND_VIDEO);
>>>> ret = msm_dp_ctrl_wait4video_ready(ctrl);
>>>> if (ret)
>>>> @@ -2787,7 +2832,9 @@ struct msm_dp_ctrl *msm_dp_ctrl_get(struct device *dev, struct msm_dp_link *link
>>>> struct phy *phy,
>>>> int max_stream,
>>>> void __iomem *ahb_base,
>>>> - void __iomem *link_base)
>>>> + void __iomem *link_base,
>>>> + void __iomem *mst2link_base,
>>>> + void __iomem *mst3link_base)
>>>> {
>>>> struct msm_dp_ctrl_private *ctrl;
>>>> int ret;
>>>> @@ -2827,6 +2874,8 @@ struct msm_dp_ctrl *msm_dp_ctrl_get(struct device *dev, struct msm_dp_link *link
>>>> ctrl->phy = phy;
>>>> ctrl->ahb_base = ahb_base;
>>>> ctrl->link_base = link_base;
>>>> + ctrl->mst2link_base = mst2link_base;
>>>> + ctrl->mst3link_base = mst3link_base;
>>>> ret = msm_dp_ctrl_clk_init(&ctrl->msm_dp_ctrl, max_stream);
>>>> if (ret) {
>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h b/drivers/gpu/drm/msm/dp/dp_ctrl.h
>>>> index 6fed3ff3a72d..e72d501ac1ce 100644
>>>> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h
>>>> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h
>>>> @@ -31,7 +31,9 @@ struct msm_dp_ctrl *msm_dp_ctrl_get(struct device *dev,
>>>> struct phy *phy,
>>>> int max_stream,
>>>> void __iomem *ahb_base,
>>>> - void __iomem *link_base);
>>>> + void __iomem *link_base,
>>>> + void __iomem *mst2link_base,
>>>> + void __iomem *mst3link_base);
>>>> void msm_dp_ctrl_reset(struct msm_dp_ctrl *msm_dp_ctrl);
>>>> void msm_dp_ctrl_phy_init(struct msm_dp_ctrl *msm_dp_ctrl);
>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
>>>> index ff506064a3fa..a924fbd825f7 100644
>>>> --- a/drivers/gpu/drm/msm/dp/dp_display.c
>>>> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
>>>> @@ -85,6 +85,12 @@ struct msm_dp_display_private {
>>>> void __iomem *link_base;
>>>> size_t link_len;
>>>> + void __iomem *mst2link_base;
>>>> + size_t mst2link_len;
>>>> +
>>>> + void __iomem *mst3link_base;
>>>> + size_t mst3link_len;
>>>> +
>>>> void __iomem *pixel_base[DP_STREAM_MAX];
>>>> size_t pixel_len;
>>>> @@ -561,7 +567,8 @@ static int msm_dp_init_sub_modules(struct msm_dp_display_private *dp)
>>>> goto error_link;
>>>> }
>>>> - dp->panel = msm_dp_panel_get(dev, dp->aux, dp->link, dp->link_base, dp->pixel_base[0]);
>>>> + dp->panel = msm_dp_panel_get(dev, dp->aux, dp->link, dp->link_base,
>>>> + dp->mst2link_base, dp->mst3link_base, dp->pixel_base[0]);
>>>> if (IS_ERR(dp->panel)) {
>>>> rc = PTR_ERR(dp->panel);
>>>> DRM_ERROR("failed to initialize panel, rc = %d\n", rc);
>>>> @@ -570,7 +577,8 @@ static int msm_dp_init_sub_modules(struct msm_dp_display_private *dp)
>>>> }
>>>> dp->ctrl = msm_dp_ctrl_get(dev, dp->link, dp->panel, dp->aux,
>>>> - phy, dp->max_stream, dp->ahb_base, dp->link_base);
>>>> + phy, dp->max_stream, dp->ahb_base,
>>>> + dp->link_base, dp->mst2link_base, dp->mst3link_base);
>>>> if (IS_ERR(dp->ctrl)) {
>>>> rc = PTR_ERR(dp->ctrl);
>>>> DRM_ERROR("failed to initialize ctrl, rc = %d\n", rc);
>>>> @@ -883,6 +891,10 @@ void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp)
>>>> msm_dp_display->aux_base, "dp_aux");
>>>> msm_disp_snapshot_add_block(disp_state, msm_dp_display->link_len,
>>>> msm_dp_display->link_base, "dp_link");
>>>> + msm_disp_snapshot_add_block(disp_state, msm_dp_display->mst2link_len,
>>>> + msm_dp_display->mst2link_base, "dp_mst2link");
>>>> + msm_disp_snapshot_add_block(disp_state, msm_dp_display->mst3link_len,
>>>> + msm_dp_display->mst3link_base, "dp_mst3link");
>>>> msm_disp_snapshot_add_block(disp_state, msm_dp_display->pixel_len,
>>>> msm_dp_display->pixel_base[0], "dp_p0");
>>>> msm_disp_snapshot_add_block(disp_state, msm_dp_display->pixel_len,
>>>> @@ -1228,6 +1240,14 @@ static int msm_dp_display_get_io(struct msm_dp_display_private *display)
>>>> }
>>>> }
>>>> + display->mst2link_base = msm_dp_ioremap(pdev, 7, &display->mst2link_len);
>>>> + if (IS_ERR(display->mst2link_base))
>>>> + DRM_DEBUG_DP("unable to remap link region: %pe\n", display->mst2link_base);
>>>> +
>>>> + display->mst3link_base = msm_dp_ioremap(pdev, 8, &display->mst3link_len);
>>>> + if (IS_ERR(display->mst3link_base))
>>>> + DRM_DEBUG_DP("unable to remap link region: %pe\n", display->mst3link_base);
>>>> +
>>>> return 0;
>>>> }
>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
>>>> index 6c88cc7e3037..a8a6297b37e3 100644
>>>> --- a/drivers/gpu/drm/msm/dp/dp_panel.c
>>>> +++ b/drivers/gpu/drm/msm/dp/dp_panel.c
>>>> @@ -25,23 +25,50 @@ struct msm_dp_panel_private {
>>>> struct drm_dp_aux *aux;
>>>> struct msm_dp_link *link;
>>>> void __iomem *link_base;
>>>> + void __iomem *mst2link_base;
>>>> + void __iomem *mst3link_base;
>>>> void __iomem *pixel_base;
>>>> bool panel_on;
>>>> };
>>>> static inline u32 msm_dp_read_link(struct msm_dp_panel_private *panel, u32 offset)
>>>> {
>>>> - return readl_relaxed(panel->link_base + offset);
>>>> + switch (panel->msm_dp_panel.stream_id) {
>>>> + case DP_STREAM_0:
>>>> + case DP_STREAM_1:
>>>> + return readl_relaxed(panel->link_base + offset);
>>>> + case DP_STREAM_2:
>>>> + return readl_relaxed(panel->mst2link_base + offset);
>>>> + case DP_STREAM_3:
>>>> + return readl_relaxed(panel->mst3link_base + offset);
>>>> + default:
>>>> + DRM_ERROR("error stream_id\n");
>>>> + return 0;
>>>> + }
>>>> }
>>>> static inline void msm_dp_write_link(struct msm_dp_panel_private *panel,
>>>> - u32 offset, u32 data)
>>>> + u32 offset, u32 data)
>>>> {
>>>> /*
>>>> * To make sure link reg writes happens before any other operation,
>>>> * this function uses writel() instread of writel_relaxed()
>>>> */
>>>> - writel(data, panel->link_base + offset);
>>>> + switch (panel->msm_dp_panel.stream_id) {
>>>> + case DP_STREAM_0:
>>>> + case DP_STREAM_1:
>>>> + writel(data, panel->link_base + offset);
>>>> + break;
>>>> + case DP_STREAM_2:
>>>> + writel(data, panel->mst2link_base + offset);
>>>> + break;
>>>> + case DP_STREAM_3:
>>>> + writel(data, panel->mst3link_base + offset);
>>>> + break;
>>>> + default:
>>>> + DRM_ERROR("error stream_id\n");
>>>> + break;
>>>> + }
>>>> }
>>>> static inline void msm_dp_write_pn(struct msm_dp_panel_private *panel,
>>>> @@ -444,38 +471,51 @@ void msm_dp_panel_clear_dsc_dto(struct msm_dp_panel *msm_dp_panel)
>>>> static void msm_dp_panel_send_vsc_sdp(struct msm_dp_panel_private *panel, struct dp_sdp *vsc_sdp)
>>>> {
>>>> + u32 id = panel->msm_dp_panel.stream_id;
>>>> u32 header[2];
>>>> u32 val;
>>>> int i;
>>>> u32 offset = 0;
>>>> - if (panel->msm_dp_panel.stream_id == DP_STREAM_1)
>>>> + if (id == DP_STREAM_1)
>>>> offset = MMSS_DP1_GENERIC0_0 - MMSS_DP_GENERIC0_0;
>>>> msm_dp_utils_pack_sdp_header(&vsc_sdp->sdp_header, header);
>>>> - msm_dp_write_link(panel, MMSS_DP_GENERIC0_0 + offset, header[0]);
>>>> - msm_dp_write_link(panel, MMSS_DP_GENERIC0_1 + offset, header[1]);
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_GENERIC0_0 : MMSS_DP_GENERIC0_0 + offset,
>>>> + header[0]);
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_GENERIC0_1 : MMSS_DP_GENERIC0_1 + offset,
>>>> + header[1]);
>>>> for (i = 0; i < sizeof(vsc_sdp->db); i += 4) {
>>>> val = ((vsc_sdp->db[i]) | (vsc_sdp->db[i + 1] << 8) | (vsc_sdp->db[i + 2] << 16) |
>>>> (vsc_sdp->db[i + 3] << 24));
>>>> - msm_dp_write_link(panel, MMSS_DP_GENERIC0_2 + i + offset, val);
>>>> +
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_GENERIC0_2 + i : MMSS_DP_GENERIC0_2 + i + offset,
>>>> + val);
>>>> }
>>>> }
>>>> static void msm_dp_panel_update_sdp(struct msm_dp_panel_private *panel)
>>>> {
>>>> + u32 id = panel->msm_dp_panel.stream_id;
>>>> u32 hw_revision = panel->msm_dp_panel.hw_revision;
>>>> u32 offset = 0;
>>>> - if (panel->msm_dp_panel.stream_id == DP_STREAM_1)
>>>> + if (id == DP_STREAM_1)
>>>> offset = MMSS_DP1_SDP_CFG3 - MMSS_DP_SDP_CFG3;
>>>> if (hw_revision >= DP_HW_VERSION_1_0 &&
>>>> hw_revision < DP_HW_VERSION_1_2) {
>>>> - msm_dp_write_link(panel, MMSS_DP_SDP_CFG3 + offset, UPDATE_SDP);
>>>> - msm_dp_write_link(panel, MMSS_DP_SDP_CFG3 + offset, 0x0);
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG3 : MMSS_DP_SDP_CFG3 + offset,
>>>> + UPDATE_SDP);
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG3 : MMSS_DP_SDP_CFG3 + offset,
>>>> + 0x0);
>>>> }
>>>> }
>>>> @@ -483,26 +523,34 @@ void msm_dp_panel_enable_vsc_sdp(struct msm_dp_panel *msm_dp_panel, struct dp_sd
>>>> {
>>>> struct msm_dp_panel_private *panel =
>>>> container_of(msm_dp_panel, struct msm_dp_panel_private, msm_dp_panel);
>>>> + u32 id = msm_dp_panel->stream_id;
>>>> u32 cfg, cfg2, misc;
>>>> u32 misc_reg_offset = 0;
>>>> u32 sdp_cfg_offset = 0;
>>>> u32 sdp_cfg2_offset = 0;
>>>> - if (msm_dp_panel->stream_id == DP_STREAM_1) {
>>>> + if (id == DP_STREAM_1) {
>>>> misc_reg_offset = REG_DP1_MISC1_MISC0 - REG_DP_MISC1_MISC0;
>>>> sdp_cfg_offset = MMSS_DP1_SDP_CFG - MMSS_DP_SDP_CFG;
>>>> sdp_cfg2_offset = MMSS_DP1_SDP_CFG2 - MMSS_DP_SDP_CFG2;
>>>> }
>>>> - cfg = msm_dp_read_link(panel, MMSS_DP_SDP_CFG + sdp_cfg_offset);
>>>> - cfg2 = msm_dp_read_link(panel, MMSS_DP_SDP_CFG2 + sdp_cfg2_offset);
>>>> - misc = msm_dp_read_link(panel, REG_DP_MISC1_MISC0 + misc_reg_offset);
>>>> + cfg = msm_dp_read_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG : MMSS_DP_SDP_CFG + sdp_cfg_offset);
>>>> + cfg2 = msm_dp_read_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG2 : MMSS_DP_SDP_CFG2 + sdp_cfg2_offset);
>>>> + misc = msm_dp_read_link(panel, id > 1 ?
>>>> + REG_DP_MSTLINK_MISC1_MISC0 : REG_DP_MISC1_MISC0 + misc_reg_offset);
>>>> cfg |= GEN0_SDP_EN;
>>>> - msm_dp_write_link(panel, MMSS_DP_SDP_CFG + sdp_cfg_offset, cfg);
>>>> -
>>>> cfg2 |= GENERIC0_SDPSIZE_VALID;
>>>> - msm_dp_write_link(panel, MMSS_DP_SDP_CFG2 + sdp_cfg2_offset, cfg2);
>>>> +
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG : MMSS_DP_SDP_CFG + sdp_cfg_offset,
>>>> + cfg);
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG2 : MMSS_DP_SDP_CFG2 + sdp_cfg2_offset,
>>>> + cfg2);
>>>> msm_dp_panel_send_vsc_sdp(panel, vsc_sdp);
>>>> @@ -512,7 +560,9 @@ void msm_dp_panel_enable_vsc_sdp(struct msm_dp_panel *msm_dp_panel, struct dp_sd
>>>> drm_dbg_dp(panel->drm_dev, "vsc sdp enable=1\n");
>>>> pr_debug("misc settings = 0x%x\n", misc);
>>>> - msm_dp_write_link(panel, REG_DP_MISC1_MISC0 + misc_reg_offset, misc);
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + REG_DP_MSTLINK_MISC1_MISC0 : REG_DP_MISC1_MISC0 + misc_reg_offset,
>>>> + misc);
>>>> msm_dp_panel_update_sdp(panel);
>>>> }
>>>> @@ -521,26 +571,34 @@ void msm_dp_panel_disable_vsc_sdp(struct msm_dp_panel *msm_dp_panel)
>>>> {
>>>> struct msm_dp_panel_private *panel =
>>>> container_of(msm_dp_panel, struct msm_dp_panel_private, msm_dp_panel);
>>>> + u32 id = msm_dp_panel->stream_id;
>>>> u32 cfg, cfg2, misc;
>>>> u32 misc_reg_offset = 0;
>>>> u32 sdp_cfg_offset = 0;
>>>> u32 sdp_cfg2_offset = 0;
>>>> - if (msm_dp_panel->stream_id == DP_STREAM_1) {
>>>> + if (id == DP_STREAM_1) {
>>>> misc_reg_offset = REG_DP1_MISC1_MISC0 - REG_DP_MISC1_MISC0;
>>>> sdp_cfg_offset = MMSS_DP1_SDP_CFG - MMSS_DP_SDP_CFG;
>>>> sdp_cfg2_offset = MMSS_DP1_SDP_CFG2 - MMSS_DP_SDP_CFG2;
>>>> }
>>>> - cfg = msm_dp_read_link(panel, MMSS_DP_SDP_CFG + sdp_cfg_offset);
>>>> - cfg2 = msm_dp_read_link(panel, MMSS_DP_SDP_CFG2 + sdp_cfg2_offset);
>>>> - misc = msm_dp_read_link(panel, REG_DP_MISC1_MISC0 + misc_reg_offset);
>>>> + cfg = msm_dp_read_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG : MMSS_DP_SDP_CFG + sdp_cfg_offset);
>>>> + cfg2 = msm_dp_read_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG2 : MMSS_DP_SDP_CFG2 + sdp_cfg2_offset);
>>>> + misc = msm_dp_read_link(panel, id > 1 ?
>>>> + REG_DP_MSTLINK_MISC1_MISC0 : REG_DP_MISC1_MISC0 + misc_reg_offset);
>>>> cfg &= ~GEN0_SDP_EN;
>>>> - msm_dp_write_link(panel, MMSS_DP_SDP_CFG + sdp_cfg_offset, cfg);
>>>> -
>>>> cfg2 &= ~GENERIC0_SDPSIZE_VALID;
>>>> - msm_dp_write_link(panel, MMSS_DP_SDP_CFG2 + sdp_cfg2_offset, cfg2);
>>>> +
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG : MMSS_DP_SDP_CFG + sdp_cfg_offset,
>>>> + cfg);
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + MMSS_DP_MSTLINK_SDP_CFG2 : MMSS_DP_SDP_CFG2 + sdp_cfg2_offset,
>>>> + cfg2);
>>>> /* switch back to MSA */
>>>> misc &= ~DP_MISC1_VSC_SDP;
>>>> @@ -548,7 +606,9 @@ void msm_dp_panel_disable_vsc_sdp(struct msm_dp_panel *msm_dp_panel)
>>>> drm_dbg_dp(panel->drm_dev, "vsc sdp enable=0\n");
>>>> pr_debug("misc settings = 0x%x\n", misc);
>>>> - msm_dp_write_link(panel, REG_DP_MISC1_MISC0 + misc_reg_offset, misc);
>>>> + msm_dp_write_link(panel, id > 1 ?
>>>> + REG_DP_MSTLINK_MISC1_MISC0 : REG_DP_MISC1_MISC0 + misc_reg_offset,
>>>> + misc);
>>>> msm_dp_panel_update_sdp(panel);
>>>> }
>>>> @@ -598,6 +658,7 @@ static int msm_dp_panel_setup_vsc_sdp_yuv_420(struct msm_dp_panel *msm_dp_panel)
>>>> int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en)
>>>> {
>>>> + u32 id = msm_dp_panel->stream_id;
>>>> u32 data, total_ver, total_hor;
>>>> struct msm_dp_panel_private *panel;
>>>> struct drm_display_mode *drm_mode;
>>>> @@ -621,7 +682,7 @@ int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en)
>>>> drm_mode->vsync_start - drm_mode->vdisplay,
>>>> drm_mode->vsync_end - drm_mode->vsync_start);
>>>> - if (msm_dp_panel->stream_id == DP_STREAM_1)
>>>> + if (id == DP_STREAM_1)
>>>> offset = REG_DP1_TOTAL_HOR_VER - REG_DP_TOTAL_HOR_VER;
>>>> total_hor = drm_mode->htotal;
>>>> @@ -654,10 +715,18 @@ int msm_dp_panel_timing_cfg(struct msm_dp_panel *msm_dp_panel, bool wide_bus_en)
>>>> msm_dp_active = data;
>>>> - msm_dp_write_link(panel, REG_DP_TOTAL_HOR_VER + offset, total);
>>>> - msm_dp_write_link(panel, REG_DP_START_HOR_VER_FROM_SYNC + offset, sync_start);
>>>> - msm_dp_write_link(panel, REG_DP_HSYNC_VSYNC_WIDTH_POLARITY + offset, width_blanking);
>>>> - msm_dp_write_link(panel, REG_DP_ACTIVE_HOR_VER + offset, msm_dp_active);
>>>> + msm_dp_write_link(panel,
>>>> + id > 1 ? REG_DP_MSTLINK_TOTAL_HOR_VER :
>>>> + REG_DP_TOTAL_HOR_VER + offset, total);
>>>> + msm_dp_write_link(panel,
>>>> + id > 1 ? REG_DP_MSTLINK_START_HOR_VER_FROM_SYNC :
>>>> + REG_DP_START_HOR_VER_FROM_SYNC + offset, sync_start);
>>>> + msm_dp_write_link(panel,
>>>> + id > 1 ? REG_DP_MSTLINK_HSYNC_VSYNC_WIDTH_POLARITY :
>>>> + REG_DP_HSYNC_VSYNC_WIDTH_POLARITY + offset, width_blanking);
>>>> + msm_dp_write_link(panel,
>>>> + id > 1 ? REG_DP_MSTLINK_ACTIVE_HOR_VER :
>>>> + REG_DP_ACTIVE_HOR_VER + offset, msm_dp_active);
>>>> reg = msm_dp_read_pn(panel, MMSS_DP_INTF_CONFIG);
>>>> if (wide_bus_en)
>>>> @@ -726,6 +795,8 @@ int msm_dp_panel_init_panel_info(struct msm_dp_panel *msm_dp_panel)
>>>> struct msm_dp_panel *msm_dp_panel_get(struct device *dev, struct drm_dp_aux *aux,
>>>> struct msm_dp_link *link,
>>>> void __iomem *link_base,
>>>> + void __iomem *mst2link_base,
>>>> + void __iomem *mst3link_base,
>>>> void __iomem *pixel_base)
>>>> {
>>>> struct msm_dp_panel_private *panel;
>>>> @@ -745,6 +816,8 @@ struct msm_dp_panel *msm_dp_panel_get(struct device *dev, struct drm_dp_aux *aux
>>>> panel->link = link;
>>>> panel->link_base = link_base;
>>>> panel->pixel_base = pixel_base;
>>>> + panel->mst2link_base = mst2link_base;
>>>> + panel->mst3link_base = mst3link_base;
>>>> msm_dp_panel = &panel->msm_dp_panel;
>>>> msm_dp_panel->max_bw_code = DP_LINK_BW_8_1;
>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.h b/drivers/gpu/drm/msm/dp/dp_panel.h
>>>> index fe4ac3e47e17..4873c55bd693 100644
>>>> --- a/drivers/gpu/drm/msm/dp/dp_panel.h
>>>> +++ b/drivers/gpu/drm/msm/dp/dp_panel.h
>>>> @@ -101,5 +101,7 @@ static inline bool is_lane_count_valid(u32 lane_count)
>>>> struct msm_dp_panel *msm_dp_panel_get(struct device *dev, struct drm_dp_aux *aux,
>>>> struct msm_dp_link *link,
>>>> void __iomem *link_base,
>>>> + void __iomem *mst2link_base,
>>>> + void __iomem *mst3link_base,
>>>> void __iomem *pixel_base);
>>>> #endif /* _DP_PANEL_H_ */
>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_reg.h b/drivers/gpu/drm/msm/dp/dp_reg.h
>>>> index 295c1161e6b7..1c2d3d8d029d 100644
>>>> --- a/drivers/gpu/drm/msm/dp/dp_reg.h
>>>> +++ b/drivers/gpu/drm/msm/dp/dp_reg.h
>>>> @@ -162,7 +162,6 @@
>>>> #define REG_DP_START_HOR_VER_FROM_SYNC (0x00000020)
>>>> #define REG_DP_HSYNC_VSYNC_WIDTH_POLARITY (0x00000024)
>>>> #define REG_DP_ACTIVE_HOR_VER (0x00000028)
>>>> -
>>>> #define REG_DP_MISC1_MISC0 (0x0000002C)
>>>> #define DP_MISC0_SYNCHRONOUS_CLK (0x00000001)
>>>> #define DP_MISC0_COLORIMETRY_CFG_SHIFT (0x00000001)
>>>> @@ -343,6 +342,21 @@
>>>> #define MMSS_DP1_SDP_CFG2 (0x000004E4)
>>>> #define MMSS_DP1_SDP_CFG3 (0x000004E8)
>>>> +#define REG_DP_MSTLINK_CONFIGURATION_CTRL (0x00000034)
>>>> +#define REG_MSTLINK_SOFTWARE_MVID (0x00000040)
>>>> +#define REG_MSTLINK_SOFTWARE_NVID (0x00000044)
>>>> +#define REG_DP_MSTLINK_TOTAL_HOR_VER (0x00000048)
>>>> +#define REG_DP_MSTLINK_START_HOR_VER_FROM_SYNC (0x0000004C)
>>>> +#define REG_DP_MSTLINK_HSYNC_VSYNC_WIDTH_POLARITY (0x00000050)
>>>> +#define REG_DP_MSTLINK_ACTIVE_HOR_VER (0x00000054)
>>>> +#define REG_DP_MSTLINK_MISC1_MISC0 (0x00000058)
>>>> +#define MMSS_DP_MSTLINK_GENERIC0_0 (0x000000BC)
>>>> +#define MMSS_DP_MSTLINK_GENERIC0_1 (0x000000C0)
>>>> +#define MMSS_DP_MSTLINK_GENERIC0_2 (0x000000C4)
>>>> +#define MMSS_DP_MSTLINK_SDP_CFG (0x0000010c)
>>>> +#define MMSS_DP_MSTLINK_SDP_CFG2 (0x0000011c)
>>>> +#define MMSS_DP_MSTLINK_SDP_CFG3 (0x00000114)
>>>> +
>>>> #define MMSS_DP_ASYNC_FIFO_CONFIG (0x00000088)
>>>> #define REG_DP_PHY_AUX_INTERRUPT_CLEAR (0x0000004C)
>>>>
>>>> --
>>>> 2.43.0
>>>>
>>>
>>
>
next prev parent reply other threads:[~2026-05-25 12:01 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 9:33 [PATCH v4 00/39] drm/msm/dp: Add MST support for MSM chipsets Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 01/39] drm/msm/dp: remove cached drm_edid from panel Yongxing Mou
2026-04-10 13:52 ` Dmitry Baryshkov
2026-05-19 7:27 ` Yongxing Mou
2026-05-20 9:22 ` Dmitry Baryshkov
2026-05-20 10:09 ` Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 02/39] drm/msm/dp: drop deprecated .mode_set() and use .atomic_enable Yongxing Mou
2026-04-11 17:23 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 03/39] drm/msm/dp: break up dp_display_enable into two parts Yongxing Mou
2026-04-11 17:33 ` Dmitry Baryshkov
2026-04-12 0:20 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 04/39] drm/msm/dp: re-arrange dp_display_disable() into functional parts Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 05/39] drm/msm/dp: splite msm_dp_ctrl_config_ctrl() into link parts and stream parts Yongxing Mou
2026-04-11 17:34 ` Dmitry Baryshkov
2026-05-19 7:46 ` Yongxing Mou
2026-05-20 9:23 ` Dmitry Baryshkov
2026-05-20 10:16 ` Yongxing Mou
2026-05-20 10:20 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 06/39] drm/msm/dp: extract MISC1_MISC0 configuration into a separate function Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 07/39] drm/msm/dp: split link setup from source params Yongxing Mou
2026-04-11 17:36 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 08/39] drm/msm/dp: allow dp_ctrl stream APIs to use any panel passed to it Yongxing Mou
2026-04-11 17:38 ` Dmitry Baryshkov
2026-05-19 7:52 ` Yongxing Mou
2026-05-20 9:24 ` Dmitry Baryshkov
2026-05-20 10:31 ` Yongxing Mou
2026-05-20 12:36 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 09/39] drm/msm/dp: move the pixel clock control to its own API Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 10/39] drm/msm/dp: split dp_ctrl_off() into stream and link parts Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 11/39] drm/msm/dp: make bridge helpers use dp_display to allow re-use Yongxing Mou
2026-04-11 17:41 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 12/39] drm/msm/dp: separate dp_display_prepare() into its own API Yongxing Mou
2026-04-11 17:42 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 13/39] drm/msm/dp: introduce stream_id for each DP panel Yongxing Mou
2026-04-11 17:55 ` Dmitry Baryshkov
2026-05-19 8:26 ` Yongxing Mou
2026-05-20 9:27 ` Dmitry Baryshkov
2026-04-11 18:04 ` Dmitry Baryshkov
2026-05-20 8:54 ` Yongxing Mou
2026-04-12 0:04 ` Dmitry Baryshkov
2026-05-20 8:54 ` Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 14/39] drm/msm/dp: introduce max_streams for DP controller MST support Yongxing Mou
2026-04-11 17:59 ` Dmitry Baryshkov
2026-05-21 11:34 ` Yongxing Mou
2026-05-21 12:07 ` Dmitry Baryshkov
2026-05-22 7:58 ` Yongxing Mou
2026-05-25 8:16 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 15/39] drm/msm/dp: Add support for programming p1/p2/p3 register blocks Yongxing Mou
2026-04-11 18:07 ` Dmitry Baryshkov
2026-05-21 11:50 ` Yongxing Mou
2026-05-21 12:20 ` Dmitry Baryshkov
2026-05-22 7:51 ` Yongxing Mou
2026-05-25 8:19 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 16/39] drm/msm/dp: use stream_id to change offsets in dp_catalog Yongxing Mou
2026-04-11 18:12 ` Dmitry Baryshkov
2026-05-25 8:06 ` Yongxing Mou
2026-05-25 8:21 ` Dmitry Baryshkov
2026-05-25 12:13 ` Yongxing Mou
2026-05-25 13:31 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 17/39] drm/msm/dp: Add catalog support for 3rd/4th stream MST Yongxing Mou
2026-04-11 18:24 ` Dmitry Baryshkov
2026-05-25 8:06 ` Yongxing Mou
2026-05-25 8:25 ` Dmitry Baryshkov
2026-05-25 12:01 ` Yongxing Mou [this message]
2026-05-25 13:32 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 18/39] drm/msm/dp: add support to send ACT packets for MST Yongxing Mou
2026-04-11 18:57 ` Dmitry Baryshkov
2026-06-15 8:21 ` Yongxing Mou
2026-06-16 0:41 ` Dmitry Baryshkov
2026-06-16 9:36 ` Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 19/39] drm/msm/dp: Add support to enable MST in mainlink control Yongxing Mou
2026-04-11 18:59 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 20/39] drm/msm/dp: no need to update tu calculation for mst Yongxing Mou
2026-04-11 19:00 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 21/39] drm/msm/dp: Add support for MST channel slot allocation Yongxing Mou
2026-04-11 23:58 ` Dmitry Baryshkov
2026-04-10 9:33 ` [PATCH v4 22/39] drm/msm/dp: Add support for sending VCPF packets in DP controller Yongxing Mou
2026-04-11 19:24 ` Dmitry Baryshkov
2026-06-15 8:35 ` Yongxing Mou
2026-06-16 0:44 ` Dmitry Baryshkov
2026-06-16 9:23 ` Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 23/39] drm/msm/dp: Always program MST_FIFO_CONSTANT_FILL for MST use cases Yongxing Mou
2026-04-10 9:33 ` [PATCH v4 24/39] drm/msm/dp: simplify link and clock disable sequence Yongxing Mou
2026-04-12 0:00 ` Dmitry Baryshkov
2026-04-10 9:34 ` [PATCH v4 25/39] drm/msm/dp: pass panel to display enable/disable helpers Yongxing Mou
2026-04-12 0:05 ` Dmitry Baryshkov
2026-05-28 10:13 ` Yongxing Mou
2026-04-10 9:34 ` [PATCH v4 26/39] drm/msm/dp: abstract out the dp_display stream helpers to accept a panel Yongxing Mou
2026-04-12 0:07 ` Dmitry Baryshkov
2026-04-10 9:34 ` [PATCH v4 27/39] drm/msm/dp: replace power_on with active_stream_cnt for dp_display Yongxing Mou
2026-04-12 0:11 ` Dmitry Baryshkov
2026-06-15 8:45 ` Yongxing Mou
2026-04-10 9:34 ` [PATCH v4 28/39] drm/msm/dp: Mark the SST bridge disconnected when mst is active Yongxing Mou
2026-04-12 0:11 ` Dmitry Baryshkov
2026-06-15 8:47 ` Yongxing Mou
2026-04-10 9:34 ` [PATCH v4 29/39] drm/msm/dp: add an API to initialize MST on sink side Yongxing Mou
2026-04-12 0:15 ` Dmitry Baryshkov
2026-06-15 9:02 ` Yongxing Mou
2026-06-16 0:45 ` Dmitry Baryshkov
2026-06-16 9:44 ` Yongxing Mou
2026-04-10 9:34 ` [PATCH v4 30/39] drm/msm/dp: add dp_display_get_panel() to initialize DP panel Yongxing Mou
2026-04-12 0:17 ` Dmitry Baryshkov
2026-04-10 9:34 ` [PATCH v4 31/39] drm/msm/dp: add prepared to manage link-level operations Yongxing Mou
2026-04-12 0:19 ` Dmitry Baryshkov
2026-04-10 9:34 ` [PATCH v4 32/39] drm/msm/dpu: initialize encoders per stream for DP MST Yongxing Mou
2026-04-11 19:31 ` Dmitry Baryshkov
2026-04-10 9:34 ` [PATCH v4 33/39] drm/msm/dp: initialize dp_mst module for each DP MST controller Yongxing Mou
2026-04-11 23:36 ` Dmitry Baryshkov
2026-04-10 9:34 ` [PATCH v4 34/39] drm/msm/dp: add dp_mst_drm to manage DP MST bridge operations Yongxing Mou
2026-04-11 23:51 ` Dmitry Baryshkov
2026-05-18 12:00 ` Yongxing Mou
2026-04-10 9:34 ` [PATCH v4 35/39] drm/msm/dp: wire MST helpers into atomic check and commit paths Yongxing Mou
2026-04-11 23:55 ` Dmitry Baryshkov
2026-04-10 9:34 ` [PATCH v4 36/39] drm/msm/dp: add connector abstraction for DP MST Yongxing Mou
2026-04-11 23:30 ` Dmitry Baryshkov
2026-04-10 9:34 ` [PATCH v4 37/39] drm/msm/dp: add HPD callback for dp MST Yongxing Mou
2026-04-11 22:00 ` Dmitry Baryshkov
2026-06-15 10:05 ` Yongxing Mou
2026-06-16 0:50 ` Dmitry Baryshkov
2026-06-16 9:51 ` Yongxing Mou
2026-04-10 9:34 ` [PATCH v4 38/39] drm/msm/dpu: use msm_dp_get_mst_intf_id() to get the intf id Yongxing Mou
2026-04-10 9:34 ` [PATCH v4 39/39] drm/msm/dp: Add MST stream support for supported DP controllers Yongxing Mou
2026-04-10 10:23 ` Konrad Dybcio
2026-04-11 19:26 ` Dmitry Baryshkov
2026-04-10 13:53 ` [PATCH v4 00/39] drm/msm/dp: Add MST support for MSM chipsets Dmitry Baryshkov
2026-04-12 0:34 ` Dmitry Baryshkov
2026-05-22 8:07 ` Yongxing Mou
2026-05-25 8:26 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=339aac36-db5a-4013-aa7f-58715f3fb9d3@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®