From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE611C43464 for ; Fri, 18 Sep 2020 08:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E3592084C for ; Fri, 18 Sep 2020 08:32:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="f+HiGThg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbgIRIcA (ORCPT ); Fri, 18 Sep 2020 04:32:00 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37706 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726743AbgIRIbz (ORCPT ); Fri, 18 Sep 2020 04:31:55 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08I87k8R074586; Fri, 18 Sep 2020 04:31:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=OVwmFcDXD14Sj/el2nOYFGLk1fFCIlWriAqJljEUo+g=; b=f+HiGThgP4uwy/48e0sVNC+ByHLIedn9Im1NJzlCPDbf3cO2sWSf9JWtgQ8i8fdt6moK WxxQgA3/lBvy86scsw1iPi23TZKgtOQYIe4dEVkum5u2qm+2q7Il4Ie6eEZ4sY8/MOU0 UMQVTqPsd3FyGfYbJUOqjFfz5Dr9303ZKQOqpgCnMMkWotXFAgw0NTHTnwh/ID+B/MqC VB+tzs7lrxUvHJRB2pI10HgANK7mkW99b7t3gJ/zaSbzDuK1K500LT1SYUrHBzf+EcuG ht9CX8iUh73UsOsJwnayqwP5eMEjbTPLA0Z7jsYIkmYgZmAK4lXGRWYiFIWoBAqh/aSF qg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 33mrut1cpg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 04:31:31 -0400 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 08I839bt058396; Fri, 18 Sep 2020 04:31:31 -0400 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 33mrut1cnq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 04:31:31 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 08I8S312002386; Fri, 18 Sep 2020 08:31:29 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma06ams.nl.ibm.com with ESMTP id 33k9geatfd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 08:31:29 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 08I8VQ7T30736842 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Sep 2020 08:31:26 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D2B411C04A; Fri, 18 Sep 2020 08:31:26 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB0A411C050; Fri, 18 Sep 2020 08:31:23 +0000 (GMT) Received: from [9.199.44.250] (unknown [9.199.44.250]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 18 Sep 2020 08:31:23 +0000 (GMT) Subject: Re: [PATCH v6 0/8] powerpc/watchpoint: Bug fixes plus new feature flag To: Rogerio Alves Cc: mpe@ellerman.id.au, christophe.leroy@c-s.fr, mikey@neuling.org, jniethe5@gmail.com, pedromfc@linux.ibm.com, linux-kernel@vger.kernel.org, paulus@samba.org, rogealve@linux.ibm.com, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, Ravi Bangoria References: <20200902042945.129369-1-ravi.bangoria@linux.ibm.com> <6927523d-de63-910a-e789-5fab424c7eb9@linux.ibm.com> From: Ravi Bangoria Message-ID: <339e69c6-947c-031b-8018-f590afe8569e@linux.ibm.com> Date: Fri, 18 Sep 2020 14:01:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <6927523d-de63-910a-e789-5fab424c7eb9@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-18_06:2020-09-16,2020-09-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009180062 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/17/20 6:54 PM, Rogerio Alves wrote: > On 9/2/20 1:29 AM, Ravi Bangoria wrote: >> Patch #1 fixes issue for quardword instruction on p10 predecessors. >> Patch #2 fixes issue for vector instructions. >> Patch #3 fixes a bug about watchpoint not firing when created with >>           ptrace PPC_PTRACE_SETHWDEBUG and CONFIG_HAVE_HW_BREAKPOINT=N. >>           The fix uses HW_BRK_TYPE_PRIV_ALL for ptrace user which, I >>           guess, should be fine because we don't leak any kernel >>           addresses and PRIV_ALL will also help to cover scenarios when >>           kernel accesses user memory. >> Patch #4,#5 fixes infinite exception bug, again the bug happens only >>           with CONFIG_HAVE_HW_BREAKPOINT=N. >> Patch #6 fixes two places where we are missing to set hw_len. >> Patch #7 introduce new feature bit PPC_DEBUG_FEATURE_DATA_BP_ARCH_31 >>           which will be set when running on ISA 3.1 compliant machine. >> Patch #8 finally adds selftest to test scenarios fixed by patch#2,#3 >>           and also moves MODE_EXACT tests outside of BP_RANGE condition. >> [...] > > Tested this patch set for: > - SETHWDEBUG when CONFIG_HAVE_HW_BREAKPOINT=N = OK > - Fix exception handling for CONFIG_HAVE_HW_BREAKPOINT=N = OK > - Check for PPC_DEBUG_FEATURE_DATA_BP_ARCH_31 = OK > - Fix quarword instruction handling on p10 predecessors = OK > - Fix handling of vector instructions = OK > > Also tested for: > - Set second watchpoint (P10 Mambo) = OK > - Infinity loop on sc instruction = OK Thanks Rogerio! Ravi