mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linaro.org>
To: tglx@linutronix.de
Cc: arnd@arndb.de, john.stultz@linaro.org, pang.xunlei@linaro.org,
	mingo@kernel.org, peterz@infradead.org,
	linux-kernel@vger.kernel.org, baolin.wang@linaro.org,
	y2038@lists.linaro.org
Subject: [PATCH v5 02/24] timekeeping: Introduce current_kernel_time64()
Date: Fri, 12 Jun 2015 15:30:32 +0800	[thread overview]
Message-ID: <33ad31f2dbcb7613dec1b44c9a5e23ef38fe76bc.1434079262.git.baolin.wang@linaro.org> (raw)
In-Reply-To: <lfywpz1987>
In-Reply-To: <cover.1434079262.git.baolin.wang@linaro.org>

The current_kernel_time() is not year 2038 safe on 32bit systems
due to return timespec value. Introduce current_kernel_time64()
function which returns timespec64 value, also as a helper function
calling by current_kernel_time().

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
 include/linux/timekeeping.h |   10 +++++++++-
 kernel/time/timekeeping.c   |    6 +++---
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h
index 3aa72e6..f886bdb 100644
--- a/include/linux/timekeeping.h
+++ b/include/linux/timekeeping.h
@@ -18,10 +18,18 @@ extern int do_sys_settimeofday(const struct timespec *tv,
  * Kernel time accessors
  */
 unsigned long get_seconds(void);
-struct timespec current_kernel_time(void);
+struct timespec64 current_kernel_time64(void);
 /* does not take xtime_lock */
 struct timespec __current_kernel_time(void);
 
+static inline struct timespec current_kernel_time(void)
+{
+	struct timespec64 now = current_kernel_time64();
+
+	return timespec64_to_timespec(now);
+}
+
 /*
  * timespec based interfaces
  */
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 0d784b3..5fe9b77 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -1857,7 +1857,7 @@ struct timespec __current_kernel_time(void)
 	return timespec64_to_timespec(tk_xtime(tk));
 }
 
-struct timespec current_kernel_time(void)
+struct timespec64 current_kernel_time64(void)
 {
 	struct timekeeper *tk = &tk_core.timekeeper;
 	struct timespec64 now;
@@ -1869,9 +1869,9 @@ struct timespec current_kernel_time(void)
 		now = tk_xtime(tk);
 	} while (read_seqcount_retry(&tk_core.seq, seq));
 
-	return timespec64_to_timespec(now);
+	return now;
 }
-EXPORT_SYMBOL(current_kernel_time);
+EXPORT_SYMBOL(current_kernel_time64);
 
 struct timespec64 get_monotonic_coarse64(void)
 {
-- 
1.7.9.5


  parent reply	other threads:[~2015-06-12  7:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <lfywpz1987>
2015-06-12  7:19 ` [PATCH v5 00/24] Convert the posix_clock_operations and k_clock structure to ready for 2038 Baolin Wang
2015-06-12  7:27   ` [PATCH v5 01/24] time: Introduce struct itimerspec64 Baolin Wang
2015-06-12  7:30   ` Baolin Wang [this message]
2015-06-12  7:37   ` [PATCH v5 03/24] security: Introduce security_settime64() Baolin Wang
2015-06-12  7:44   ` [PATCH v5 04/24] time: Introduce do_sys_settimeofday64() Baolin Wang
2015-06-12  7:48   ` [PATCH v5 05/24] posix-timers: Introduce {get,put}_timespec and {get,put}_itimerspec Baolin Wang
2015-06-12  7:48   ` [PATCH v5 06/24] posix-timers: Factor out the guts of 'timer_gettime' for reusing Baolin Wang
2015-06-12  7:48   ` [PATCH v5 07/24] posix-timers: Implement y2038 safe timer_get64() callback Baolin Wang
2015-06-12  7:48   ` [PATCH v5 08/24] posix-timers: Factor out the guts of 'timer_settime' for reusing Baolin Wang
2015-06-12  7:48   ` [PATCH v5 09/24] posix-timers: Implement y2038 safe timer_set64() callback Baolin Wang
2015-06-12  7:48   ` [PATCH v5 10/24] posix-timers: Factor out the guts of 'clock_settime' for reusing Baolin Wang
2015-06-12  7:48   ` [PATCH v5 11/24] posix-timers: Implement y2038 safe clock_set64() callback Baolin Wang
2015-06-12  7:48   ` [PATCH v5 12/24] posix-timers: Factor out the guts of 'clock_gettime' for reusing Baolin Wang
2015-06-12  7:48   ` [PATCH v5 13/24] posix-timers: Implement y2038 safe clock_get64() callback Baolin Wang
2015-06-12  7:48   ` [PATCH v5 14/24] posix-timers: Factor out the guts of 'clcok_getres' for reusing Baolin Wang
2015-06-12  7:48   ` [PATCH v5 15/24] posix-timers: Implement y2038 safe clock_getres64() callback Baolin Wang
2015-06-12  7:53   ` [PATCH v5 16/24] timekeeping: Change the implementation of timekeeping_clocktai() Baolin Wang
2015-06-12  7:56   ` [PATCH v5 17/24] posix-timers: Convert to y2038 safe callbacks Baolin Wang
2015-06-12  7:58   ` [PATCH v5 18/24] mmtimer: " Baolin Wang
2015-06-12  8:00   ` [PATCH v5 19/24] alarmtimer: " Baolin Wang
2015-06-12  8:03   ` [PATCH v5 20/24] posix-clock: " Baolin Wang
2015-06-12  8:06   ` [PATCH v5 21/24] time: Introduce timespec64_to_jiffies()/jiffies_to_timespec64() Baolin Wang
2015-06-12  8:10   ` [PATCH v5 22/24] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang
2015-06-12  8:12   ` [PATCH v5 23/24] posix-cpu-timers: Convert to y2038 safe callbacks Baolin Wang
2015-06-12  8:12   ` [PATCH v5 24/24] k_clock: Remove y2038 unsafe callbacks Baolin Wang
2015-06-12 13:16   ` [PATCH v5 00/24] Convert the posix_clock_operations and k_clock structure to ready for 2038 Thomas Gleixner
2015-06-15  2:27     ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33ad31f2dbcb7613dec1b44c9a5e23ef38fe76bc.1434079262.git.baolin.wang@linaro.org \
    --to=baolin.wang@linaro.org \
    --cc=arnd@arndb.de \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pang.xunlei@linaro.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®