mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-wireless@vger.kernel.org, James Minor <james.minor@ni.com>,
	Kalle Valo <kvalo@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Steve deRosier <steve.derosier@lairdtech.com>,
	Julia Lawall <julia.lawall@inria.fr>
Subject: [PATCH 3/3] ath6kl: Reduce scopes for two variables in ath6kl_sdio_power_on()
Date: Sat, 21 Sep 2024 14:06:07 +0200	[thread overview]
Message-ID: <33b08664-fa25-4cef-86b2-49f65b4369c9@web.de> (raw)
In-Reply-To: <d5a19bb5-f940-4f07-9f98-c670d96cc839@web.de>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 21 Sep 2024 13:30:48 +0200

Adjust the definitions for the local variables "func" and "ret"
so that the corresponding setting will be performed a bit later.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/wireless/ath/ath6kl/sdio.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c
index e4d15cc9b36c..689f83f6bce5 100644
--- a/drivers/net/wireless/ath/ath6kl/sdio.c
+++ b/drivers/net/wireless/ath/ath6kl/sdio.c
@@ -503,17 +503,15 @@ static void ath6kl_sdio_irq_handler(struct sdio_func *func)
 static int ath6kl_sdio_power_on(struct ath6kl *ar)
 {
 	struct ath6kl_sdio *ar_sdio = ath6kl_sdio_priv(ar);
-	struct sdio_func *func = ar_sdio->func;
-	int ret = 0;

 	if (!ar_sdio->is_disabled)
 		return 0;

 	ath6kl_dbg(ATH6KL_DBG_BOOT, "sdio power on\n");
-
+	struct sdio_func *func = ar_sdio->func;
 	sdio_claim_host(func);

-	ret = sdio_enable_func(func);
+	int ret = sdio_enable_func(func);
 	sdio_release_host(func);
 	if (ret) {
 		ath6kl_err("Unable to enable sdio func: %d)\n", ret);
--
2.46.0


  parent reply	other threads:[~2024-09-21 12:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-21 12:00 [PATCH 0/3] ath6kl: Adjustments for ath6kl_sdio_power_on() Markus Elfring
2024-09-21 12:02 ` [PATCH 1/3] ath6kl: Use sdio_release_host(func) call only once in ath6kl_sdio_power_on() Markus Elfring
2024-09-21 12:04 ` [PATCH 2/3] ath6kl: Omit a label " Markus Elfring
2024-09-21 12:06 ` Markus Elfring [this message]
2024-09-23 16:41   ` [PATCH 3/3] ath6kl: Reduce scopes for two variables " Jeff Johnson
2024-09-23 17:00     ` Markus Elfring
2024-09-23 18:21       ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33b08664-fa25-4cef-86b2-49f65b4369c9@web.de \
    --to=markus.elfring@web.de \
    --cc=james.minor@ni.com \
    --cc=julia.lawall@inria.fr \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=steve.derosier@lairdtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®