From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAD7B39C00F for ; Tue, 10 Mar 2026 14:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151984; cv=none; b=f6XyUTLcE4lmYWtlSxDK1N1EqKGVh7euDx+fhKPHSzeQbJh138YiMiKHxqwEgdJAXTrWXk03GGOtBWwk01h5oHRCQjV5FyIFcS91DNMxyrEtbluZ+X6jDUBKVXAOplcMcvejXM0nIITosN8/IWjnhnebXmFcaDZ6U8kiz4wbpxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151984; c=relaxed/simple; bh=5e1avswzIdmR90jxg3X+B+Ty4A5EkdVEGxOjLBbWb40=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LjCPYc2F2MjZcC2nqDIKb7mdcAP8ZP0S4CVrah7B+JHN8eATtkRfu6vlAlIguJ245Js+8BhjN4Gc3aRotvv35df0SZ/4P5HMymNVy2hQ0dD8qshcAGhnvlSmh4NTbQGS2V3Wm/zsTllqh8IV/vIUVQDoZVfeiND2weXbMwB8bAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pgmMYoQk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QzuzUdtv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pgmMYoQk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QzuzUdtv" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACaVAh1502944 for ; Tue, 10 Mar 2026 14:13:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= viDjOwaw/yqQllLUim5qk+i23DOu8Ji1UjzfbpgTqK8=; b=pgmMYoQkeEk61lUi 8/A6DcPji19sWHbMBixbgYn9jvuX5P5DEjbgVf0om2omBa4g4kjpQ9kMq+G1zC1v 4EZyjHFDTO5Xnn68sEYljYOeDfB28gjxTIDuSOa46fhB5zZhe/oyZbGZnz0oHx9y QRK359kQHLf+rJwaw4Gic2/bXvCaTASNEH2WbTHkKtTByZuT3sH1F+Wb7nsWo2Mg YgBAxQ0ZwvoFYjxL+Hjsn/RjhFE9AzCTxLpQXT9HQvVuhS79X8Ux+d6RNgtAuLjW vwyxYXVUW9GHjC2A/1V519Nk+xD/2/eBYhieHmdEZL8sE5A397u0LWyU/uiWZl2n B14BaA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctdf8huq5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 14:13:01 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8954b9b5da7so5458096d6.2 for ; Tue, 10 Mar 2026 07:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773151981; x=1773756781; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=viDjOwaw/yqQllLUim5qk+i23DOu8Ji1UjzfbpgTqK8=; b=QzuzUdtv5sp5QcF9fGsTLespGvWfkCt0KbPV9+ZbmpX5CZ5Qq4k1xFD/B7i9XXI2d0 F04z2LdzOWt5HGyLpyN2O+o2esKOsfrId5gA0K7qk7eS2LKhr60qgm93YTQesfJAJw/Y tOH5Bcbky/DCWgyQPKSDvKXh/IZpHh6CrTRTgjKcC2RH1WK2433N55BKQUwar+Ed7RFs 06I7kwCLW08yi4lvjXEr+DBhYwPRAiegV2whj+YjHf3qGddh38t3qJ8o65TH7PiwIRiM 3ty6D7IQIBmwD/2IQRgUAeYy+NHsJgwz5Hv3i22OegUryI/JXo3MhZva45P/qgljso6J WgyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773151981; x=1773756781; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=viDjOwaw/yqQllLUim5qk+i23DOu8Ji1UjzfbpgTqK8=; b=c7FiobOk4X96gOgZNv48H8PX0xA7nBAu2ChZyzQ+EX0/0Hy7qCBp6i0ti+B6mvMOeJ AGuxlQhmHmLnxgiruq44vZGpGAXklMSnX0kWatYUy3MAyjnGatoK77ujEF+2m8tHycOK R1vSn1uzyoDDlXH7MjADNqDTIm6pHN1Bs+5rmzYdi4s2haHWhFi6tafP85eOMBh33WAm A75JiuA9O+/Gox+2euz57R2wqBwVdy89clXebe6gc+u7pgq0uDJ+4wnm9qymJercvVQN q13+jkr0uWtRTAWXHlD8Uckg/KdoeRk9fAc5JOj0udC+xhxHA0VY8U4SadRPq67sQO00 lCmw== X-Forwarded-Encrypted: i=1; AJvYcCXFnuSYixNP17Rbp59SxLi93gPAINdL4//eCw9nmakaBNUZTPyBwluDdJHAcSLI4IRx43QE/sP3eZRAge0=@vger.kernel.org X-Gm-Message-State: AOJu0YzX7cjQ12hKzbejMUC85NMA0o13kgJgRdGCASv1AlgoUSZb9thp NXsewwaEEJlRdW4wGs7BfZ3WbOPECeEOIJxy2Cw7k8+IyDBX/NiPmq8hDzGaLZ+qFVo4L7a29w+ v7rDyl5AdRFoe96W7MuT34+MDMDa0TMsnBK86ghxGT5XbZzyKVyTSS7MvEB528fxxOo8= X-Gm-Gg: ATEYQzyZRKGe1VDQgMP7IrISieSUEU6/UB1hizhW/9IrDHhmFg6eE9xwk++SyDz5J3q 7T/cZp9x1asVdjJZ8cDBimuC2mb1nXnsjyRy1IzWuJL5CpIQOvIqGGxBw7HbJAa7X+aQPLf9K5Z V9+2+yuuNsaYDkNch6d8eJFhWp7dSn53oSIlv9ceEobQbizhaKjOzhmu6a/QySo1Kpl0rdbGz/p YxYldgw1jiTHz2jgVoHj/ufKbaPDCdFPoF2EhRmY3MdZ5W8+O0+vncvDeQOCHO38CS4taLRxpXU 9pqRQbS4lEgmkLieKPGotVaaYWhCgIPScW0WAtrb9mEG4zdRGz1NwW+Eq21xkQprxVgb+3A0U4o lsWqL+3DWAzpqtVmFgyE/vCmFQNhRHRTc4Wair99ZiofecAnWoDo5FDMvT9SE8118JlQAV+8oh1 i/+N0= X-Received: by 2002:a05:620a:4087:b0:8cd:7fc0:ee15 with SMTP id af79cd13be357-8cd7fc0f6dbmr1089001785a.5.1773151980761; Tue, 10 Mar 2026 07:13:00 -0700 (PDT) X-Received: by 2002:a05:620a:4087:b0:8cd:7fc0:ee15 with SMTP id af79cd13be357-8cd7fc0f6dbmr1088995085a.5.1773151980118; Tue, 10 Mar 2026 07:13:00 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-661a3c66d3fsm4317323a12.2.2026.03.10.07.12.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 07:12:59 -0700 (PDT) Message-ID: <33b27a0e-d369-4311-8372-82da4c331256@oss.qualcomm.com> Date: Tue, 10 Mar 2026 15:12:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/11] arm64: dts: qcom: sm8450: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-7-b9c2a5471d9e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-7-b9c2a5471d9e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEyNCBTYWx0ZWRfX03VEj3/Awn5u XAH57PKu7fsK658cX6LCBKim3q6FSRdfbTeJxHC4lO0tyfOwRDEGA03ZKVhvf6jzXX/3EMR2v54 89S1h2OrZaFmO4PrWC9ASADaEVmH2ih/NCnI/aBWtceiwO9izRi+7r6nS0VuQQCNXzRWt63SMU4 Wi4jqjPGfLwcWsZn3PUQcyGp3EY8ocd7KFUY+xK7a8jZStSRqzz3jiEyyJ0/6dQTyHXn5qzlPqI WIvDAjtST8V+8u0XtxjWJB7cgRSo10m2iKLMadULFIBoWKeefnxtHbJmVhtAhHFmvvkwOx3O9+D zyo+UgozpvP/iwoNAy0TANeW2oy6abr6U2qOiFnKQUvOS+9qDvDbMbcmjxXjbXbCHGF4QATwh2R aPRxpFvc8muuadGO+8cPDoHVLoDblJZu7dL6yo74AbNrUNTTP+3deetCkucClWBNfw34IkjP4up J9yrNYHTeKqgTXDfAXg== X-Proofpoint-ORIG-GUID: 887XxO_f32xsvgxJQVm-XsRBdyDsLuv8 X-Proofpoint-GUID: 887XxO_f32xsvgxJQVm-XsRBdyDsLuv8 X-Authority-Analysis: v=2.4 cv=b+W/I9Gx c=1 sm=1 tr=0 ts=69b026ed cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=z_dnvKGLtVwtNw_c-ccA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100124 On 3/10/26 9:06 AM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the UFS_PHY_GDSC power domain is enabled. Specify both the > UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8450. > > Fixes: 86b0aef435851 ("arm64: dts: qcom: sm8450: Use standalone ICE node for UFS") > Signed-off-by: Harshal Dev > --- Reviewed-by: Konrad Dybcio Konrad