From: Krzysztof Kozlowski <krzk@kernel.org>
To: Olivier Louvignes <olivier@mgcrea.io>,
Andi Shyti <andi.shyti@kernel.org>
Cc: Paul Cercueil <paul@crapouillou.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: i2c: ingenic,i2c: Add the X1600
Date: Mon, 26 Oct 2026 09:06:43 +0100 [thread overview]
Message-ID: <33b5ee36-e293-4356-9906-54e99ba3557e@kernel.org> (raw)
In-Reply-To: <20261024212520.91401-3-olivier@mgcrea.io>
On 24/10/2026 23:25, Olivier Louvignes wrote:
> The X1600's I2C controller has the X1000's registers, so it falls back
> to ingenic,x1000-i2c.
>
> Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
Why changing order of patches? Previous was correct one.
Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
With this fixed:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-26 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 21:25 [PATCH v2 0/2] i2c: jz4780: Program the spike filter, add " Olivier Louvignes
2026-10-24 21:25 ` [PATCH v2 1/2] i2c: jz4780: Program the spike suppression length Olivier Louvignes
2026-10-24 21:25 ` [PATCH v2 2/2] dt-bindings: i2c: ingenic,i2c: Add the X1600 Olivier Louvignes
2026-10-26 8:06 ` Krzysztof Kozlowski [this message]
2026-10-26 9:54 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33b5ee36-e293-4356-9906-54e99ba3557e@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=olivier@mgcrea.io \
--cc=paul@crapouillou.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®