From: Markus Elfring <Markus.Elfring@web.de>
To: James Calligeros <jcalligeros99@gmail.com>,
linux-sound@vger.kernel.org, Baojun Xu <baojun.xu@ti.com>,
Jaroslav Kysela <perex@perex.cz>, Kevin Lu <kevin-lu@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Sen Wang <sen@ti.com>,
Shenghao Ding <shenghao-ding@ti.com>,
Takashi Iwai <tiwai@suse.com>
Cc: asahi@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: tas2770: Only treat negative return codes as errors set_tdm_idle
Date: Sat, 24 Oct 2026 13:30:12 +0200 [thread overview]
Message-ID: <33b90e9d-096f-4a85-8d17-2e43b0609140@web.de> (raw)
In-Reply-To: <20261024-tas2770-idle-fix-v1-1-07b02d46ec2e@gmail.com>
> snd_soc_component_update_bits returns 1 on a successful update, and
> we were returning from tas2770_set_dai_tdm_idle early on any nonzero
> return code. Change this so that only negative return codes are
> treated as errors.
https://elixir.bootlin.com/linux/v7.3/source/sound/soc/codecs/tas2770.c#L495-L567
* How do you think about to refine the summary phrase another bit
like “Fix error detection in tas2770_set_dai_tdm_idle()”?
* See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.3#n34
Regards,
Markus
prev parent reply other threads:[~2026-10-24 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 10:58 James Calligeros
2026-10-24 11:30 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33b90e9d-096f-4a85-8d17-2e43b0609140@web.de \
--to=markus.elfring@web.de \
--cc=asahi@lists.linux.dev \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=jcalligeros99@gmail.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®