From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D0CC433FE for ; Sun, 23 Oct 2022 22:43:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbiJWWnW (ORCPT ); Sun, 23 Oct 2022 18:43:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiJWWnR (ORCPT ); Sun, 23 Oct 2022 18:43:17 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D8CA61116 for ; Sun, 23 Oct 2022 15:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1666564996; x=1698100996; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=JiVf7tTAUIo6+w69Pt3MFGZguCkRYTb2fsa6haF8SGQ=; b=F45zGGJ5juhpDq+Af7Xqz4qmLc64PaxX+xKMv31D2vqUXICVFdT+jPn7 P4vT0uFvyhi3aF91oYPJXMPLzJktk9loOByZtk05h/Dvf9/3VZFn5CFqd VolQv/xbA7duce+YVQwJ31L6GoFnOdoPuvyLuz885g/o32kwNceVaYE5q yC3OR7WHmm3RpISSSIUdakloFF22z/Jm3xW1kFxMetm+lrk8/AnEt9gzj TfK/PGqPIr789YMsrLOFcR7BhQJmykMDA2bY7OjiLgENmnRMQfTQSXPxz pI4CLwWSn/VvNQB9HBSYpj3hYTRvSvnsCpawMqGrLx+o3rJpgKyZScYM5 Q==; X-IronPort-AV: E=Sophos;i="5.95,207,1661788800"; d="scan'208";a="212855926" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 24 Oct 2022 06:43:14 +0800 IronPort-SDR: c26+CtD+jf9mpHeFpvKmOUh9IKWRs/XbS2Ebzz/QW4MjKN5+UlaKdsS92VipKX/j8lyLtlbImv n3HSCFnYLflgDn0m7NPv0Nx+BCBPc5Y3V+ynAvNcqdmtvOKSg2dTN8f3qeDM60Ii5SnY1QlC1X IXKe38WJ1sSeNzNYIe0iinxPQTPoYyAfY4aubb3qRSdTBLryuKdpDIcjPu3oLC8QCZZLtbCNLs tHTr/v+oEa/J3IimFN8SIxh7T+xQy1MljzEG8Prm8Gc6Vh2SxPyc09NqfkjERE8bgBoGe90iqq E66UqQlPvPL2/HckhlTYtzIK Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Oct 2022 15:02:39 -0700 IronPort-SDR: a17Ud51/pPHwOqdBADSdW3pNHxRkxKoepb90YZZa+4JaEYdwndCx0WQeM03JnYh9PNm/Wb0DU8 uHqqEXm23+zalIxdIagsZ3E0z9pb5byhoULhebq/yPVZy1kdPbCBJdp0jQCRKsayU4ZfXH6Lud dQSqnohV6ZXGnlW0K+HvEG95rUcOvslU2Jlo+VLaroka09tqYGENFrqZGNLYtRkEcWJVq81jN8 Ky0/DwCoI3IfXFUCV7b6NgqMtwX+K6BAR9wogHxzRlZMNm8jiEdnIZBCU/Zi3cD5KheieNqLbu PsY= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Oct 2022 15:43:14 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MwYBn5ybPz1Rwrq for ; Sun, 23 Oct 2022 15:43:13 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:references:to:from:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1666564992; x=1669156993; bh=JiVf7tTAUIo6+w69Pt3MFGZguCkRYTb2fsa 6haF8SGQ=; b=k8HehEGTPpvMsMTyAjfIHlsTkJxJzPV4G50QJ0Ox274++M0sw1+ Wzbs31nHl3s1IqCLoDomkdkK3/VXeuGbXa5YAVMERMYISkdjLVopXH7hIN12NG2a hH4Z6u+M1wrAdDBD/k0TzqLCxuH4KnA+Wt1BOpC2tVTDAELqQi6YEwCpYoFxAR57 G5VevmifspbmVd847XNYvUcqFMcPbX7Ke3nkiv1+8uH8mEQNlCFkUxX9/Z7IRRIE AmWMH0WeONOL/Aw43DHkGwosA2YKmeOvo/QmsaUgDKePG2PWuFwVeUJPl/tx6/Wt t02wF+j1iu1ezqfhuCCu0kYSGqGVSyopmCQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xtQGiAK7lKKy for ; Sun, 23 Oct 2022 15:43:12 -0700 (PDT) Received: from [10.225.163.126] (unknown [10.225.163.126]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MwYBl2kymz1RvLy; Sun, 23 Oct 2022 15:43:11 -0700 (PDT) Message-ID: <33b942d9-e589-34b7-2967-bbb939fef121@opensource.wdc.com> Date: Mon, 24 Oct 2022 07:43:10 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 09/21] pata: remove samsung_cf driver Content-Language: en-US From: Damien Le Moal To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Ben Dooks , Simtec Linux Team , Arnd Bergmann , Sergey Shtylyov , Hannes Reinecke , linux-ide@vger.kernel.org References: <20221021202254.4142411-1-arnd@kernel.org> <20221021203329.4143397-9-arnd@kernel.org> Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/22 07:41, Damien Le Moal wrote: > On 10/22/22 05:27, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> This device was only used by the smdk6410 board file that is now >> gone, so the driver can be removed as well. >> >> Signed-off-by: Arnd Bergmann > > Arnd, > > This patch does not apply to the for-6.2 branch of libata tree. I can fix > that easily, but I am concerned about the fact that this deletes the > header file include/linux/platform_data/ata-samsung_cf.h, which has some > function declarations for gpio used under arch/arm/mach-s3c. So If I apply > this before you queue the other patches for this driver in for-next, we > may endup with build failures. No ? It may be simpler for you to take this patch ? If yes, then: Acked-by: Damien Le Moal > >> --- >> drivers/ata/Kconfig | 10 - >> drivers/ata/Makefile | 1 - >> drivers/ata/pata_samsung_cf.c | 662 ------------------- >> include/linux/platform_data/ata-samsung_cf.h | 31 - >> 4 files changed, 704 deletions(-) >> delete mode 100644 drivers/ata/pata_samsung_cf.c >> delete mode 100644 include/linux/platform_data/ata-samsung_cf.h >> >> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig >> index 6b446cfc3455..3b8cb7a29efd 100644 >> --- a/drivers/ata/Kconfig >> +++ b/drivers/ata/Kconfig >> @@ -1136,16 +1136,6 @@ config PATA_RZ1000 >> >> If unsure, say N. >> >> -config PATA_SAMSUNG_CF >> - tristate "Samsung SoC PATA support" >> - depends on SAMSUNG_DEV_IDE || COMPILE_TEST >> - select PATA_TIMINGS >> - help >> - This option enables basic support for Samsung's S3C/S5P board >> - PATA controllers via the new ATA layer >> - >> - If unsure, say N. >> - >> config PATA_WINBOND_VLB >> tristate "Winbond W83759A VLB PATA support (Experimental)" >> depends on ISA >> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile >> index 2cca9f500649..4ee5c0761d90 100644 >> --- a/drivers/ata/Makefile >> +++ b/drivers/ata/Makefile >> @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o >> obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o >> obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o >> obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o >> -obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o >> >> obj-$(CONFIG_PATA_PXA) += pata_pxa.o >> >> diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c >> deleted file mode 100644 >> index aba1536ddd44..000000000000 >> diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h >> deleted file mode 100644 >> index fccf969dc4da..000000000000 > -- Damien Le Moal Western Digital Research