Re: [PATCH v2] platform/x86: ideapad-laptop: Add Yoga Pro 7 14IAH10 Mode key

[Hans de Goede <hansg@kernel.org>]

Hi,

On 14-Sep-26 3:42 PM, Navon John Lukose wrote:
> The F9 "Mode" key emits WMI fn-key event 0x46, which the keymap does not
> cover, so it reaches userspace as KEY_UNKNOWN and cannot be remapped from
> there. Under Windows it opens a performance profile chooser. The Fn+Q
> button already cycles platform_profile through
> ideapad_check_special_buttons(), so map 0x46 to KEY_PROG4 as a
> user-assignable key rather than cycling the profile a second way.
> 
> Signed-off-by: Navon John Lukose <navonjohnlukose@gmail.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans


> ---
> v2: reword the entry comment and explain why 0x46 is not routed through
> platform_profile_cycle() (Hans).
> 
> https://lore.kernel.org/platform-driver-x86/2eab84cb-6d2f-4ec3-9869-e2aa9c1d75da@kernel.org/
> 
> Lenovo Yoga Pro 7 14IAH10 (83KF), BIOS QGCN35WW.
> 
> Measured with dyndbg on ideapad-laptop.c and a kprobe on
> platform_profile_cycle():
> 
>   Mode key (plain F9), 2 presses:
>       WMI fn-key event: 0x46, twice
>       no platform_profile change
> 
>   Fn+Q, 2 presses:
>       platform_profile_cycle() twice, called from ideapad_acpi_notify()
>       no WMI fn-key event
> 
>  drivers/platform/x86/lenovo/ideapad-laptop.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c b/drivers/platform/x86/lenovo/ideapad-laptop.c
> index 8213524..35c13d9 100644
> --- a/drivers/platform/x86/lenovo/ideapad-laptop.c
> +++ b/drivers/platform/x86/lenovo/ideapad-laptop.c
> @@ -1360,6 +1360,8 @@ static const struct key_entry ideapad_keymap[] = {
>  	{ KE_KEY,	0x45 | IDEAPAD_WMI_KEY, { KEY_PROG3 } },
>  	/* Performance toggle also Fn+Q, handled inside ideapad_wmi_notify() */
>  	{ KE_KEY,	0x3d | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
> +	/* Mode, opens a profile chooser; the Fn+Q button cycles the profile */
> +	{ KE_KEY,	0x46 | IDEAPAD_WMI_KEY, { KEY_PROG4 } },
>  	/* shift + prtsc */
>  	{ KE_KEY,   0x2d | IDEAPAD_WMI_KEY, { KEY_SELECTIVE_SCREENSHOT } },
>  	{ KE_KEY,   0x29 | IDEAPAD_WMI_KEY, { KEY_TOUCHPAD_TOGGLE } },